In the absence of a specific forum for singular, I'd like to propose a few changes to the way singular works. In revision 280 I made a few small changes to the way CompositeBuilder constructs composites for the current context. Previously, it was only possible to have 1 composite for any given context and it was always the last context found. The two main changes I made was to a) return a list of matched composites for the context in a priority selector and b) implement a priority method attribute which allows basic ordering of matched composites. To see an example of this in use, check out the Priest/Common.cs => CreatePriestCommonCombatSpells(). In short this checks a few conditions in an attempt to try to use one of a few mana returning spells for all specs so it doesn't need to be individually added and updated in each spec and rotation. CreateShadowPriestPullBuffs() (incorrectly named, but screw you) also attempts to pw:shield before every pull on every spec if the setting is on. I propose to create a ClassSpecific/Common folder in which, initially, would create Racial.cs and Trinket.cs moving the composites out of being specifically set in the root singularroutine and into the priority tree, adhering to the options as set in the CC config. Also, I'll add spec:all and class:all to the attribute enums. If successful, I think this would also be a good place to look at potentially moving some rest behaviour and some of the pvp helper stuff. I'm not going to make any changes along these lines without further consultation. Any comments/suggestions/ideas/love notes? Please don't reply unless you know what you're talking aboot.
