• Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • MerchantFrame.Instance.Merchant has been bugged for a while now

    Discussion in 'Honorbuddy Support' started by Inrego, Oct 18, 2013.

    1. Inrego

      Inrego New Member Buddy Store Developer

      Joined:
      Feb 7, 2010
      Messages:
      2,765
      Likes Received:
      71
      Trophy Points:
      0
      MerchantFrame.Instance.Merchant returns null, and has done so for quite a while now. I imagine you're not aware of it since I doubt many people use this, but I use it in my AntiCap plugin and this broken api has caused the plugin to not work for a few months now. Could you please fix it? :)
       
    2. CodenameG

      CodenameG New Member

      Joined:
      Jan 15, 2010
      Messages:
      38,369
      Likes Received:
      231
      Trophy Points:
      0
      i haven't had issues with Mr.GearBuyer.
       
    3. Inrego

      Inrego New Member Buddy Store Developer

      Joined:
      Feb 7, 2010
      Messages:
      2,765
      Likes Received:
      71
      Trophy Points:
      0
      Are you using this particular api call?
       
    4. Inrego

      Inrego New Member Buddy Store Developer

      Joined:
      Feb 7, 2010
      Messages:
      2,765
      Likes Received:
      71
      Trophy Points:
      0
      I just looked through your code, and you are not using this api call, so it's not really relevant for this topic :)

      Could a HB dev please check it out and fix it? I've made a temporary workaround, but it's not as failproof, so I'd prefer to use this.
       
    5. CodenameG

      CodenameG New Member

      Joined:
      Jan 15, 2010
      Messages:
      38,369
      Likes Received:
      231
      Trophy Points:
      0
      im pulling data from merchantframe.instace. and its been fine.
       
    6. Inrego

      Inrego New Member Buddy Store Developer

      Joined:
      Feb 7, 2010
      Messages:
      2,765
      Likes Received:
      71
      Trophy Points:
      0
      Yeah, I'm not having any problems with MerchantFrame.Instance, but with MerchantFrame.Instance.Merchant which is always null.
       
    7. Giwin

      Giwin Well-Known Member Buddy Store Developer

      Joined:
      Dec 3, 2011
      Messages:
      3,431
      Likes Received:
      49
      Trophy Points:
      48
      Just tested the Merchant property and I can say it doesn't work.

      Code:
              public WoWUnit Merchant()
              {
                  return MerchantFrame.Instance.IsVisible ? MerchantFrame.Instance.Merchant : null;
              }
      
      Code:
      
      
                          try
                          {
                              Logging.Write("Merchant: " + Merchant().Name);
                          }
                          catch (Exception e)
                          {
                              Logging.Write(e.Message + " | " + e.Data + " | " + e.Source);
                          }
      
      EDIT1: Hold on...

      EDIT2: Definitely doesn't work on the Release version although this may have been fixed in the Beta, tried on several NPCs which included Armorsmith, Innkeeper, General Goods etc.
       
    8. Inrego

      Inrego New Member Buddy Store Developer

      Joined:
      Feb 7, 2010
      Messages:
      2,765
      Likes Received:
      71
      Trophy Points:
      0
      Maybe they've been fast at fixing it after my report :p
       

    Share This Page