KingWoW Shaman

awsome thnx attilio

 

I think there is some issues with Goblin Shammy when healing in dungeons:

It spams this all the time:
07:002[Racial Abilitie] Rocket Barrage
07:741[Racial Abilitie] Rocket Barrage
08:513[Racial Abilitie] Rocket Barrage
09:321[Racial Abilitie] Rocket Barrage
10:031[Racial Abilitie] Rocket Barrage
10:333 my HP% 100 MANA% 99.34 Riptide: <REMOVED NAME>
12:043[Racial Abilitie] Rocket Barrage
12:816[Racial Abilitie] Rocket Barrage
13:621[Racial Abilitie] Rocket Barrage
14:430[Racial Abilitie] Rocket Barrage
15:238[Racial Abilitie] Rocket Barrage
15:945[Racial Abilitie] Rocket Barrage
16:650[Racial Abilitie] Rocket Barrage
17:258target HP%=80.14 Healing Wave: <REMOVED NAME>
17:628target HP%=80.14 Riptide: <REMOVED NAME>
19:070[Racial Abilitie] Rocket Barrage
19:814[Racial Abilitie] Rocket Barrage
20:517[Racial Abilitie] Rocket Barrage
21:255[Racial Abilitie] Rocket Barrage
21:961[Racial Abilitie] Rocket Barrage
22:696[Racial Abilitie] Rocket Barrage
23:399[Racial Abilitie] Rocket Barrage
24:174[Racial Abilitie] Rocket Barrage
25:010[Racial Abilitie] Rocket Barrage
25:748[Racial Abilitie] Rocket Barrage
26:455[Racial Abilitie] Rocket Barrage
27:195[Racial Abilitie] Rocket Barrage
27:893[Racial Abilitie] Rocket Barrage
28:636[Racial Abilitie] Rocket Barrage
29:343[Racial Abilitie] Rocket Barrage

using SVN version

 

FIXED Wind Shear spam.

@AEUS: disable use racials in Utility settings in GUI

 

Ah thx!

 

If im not mistaken, this is the line, correct?

Code:

 if (!Me.Combat && !Me.Mounted && !utils.isAuraActive(DRINK) && !utils.isAuraActive(FOOD) && Me.ManaPercent >= 50 && Me.HealthPercent < 95

I changed it to:

Code:

                if (!Me.Combat && !Me.Mounted && !utils.isAuraActive(DRINK) && !utils.isAuraActive(FOOD) && Me.ManaPercent >= 95 && Me.HealthPercent < 70 || ((!Me.Combat && !Me.Mounted && Me.HealthPercent < 90) && (utils.PlayerCountBuff(MAELSTROM_WEAPON) == 5) || (Me.ManaPercent >= 90 && utils.PlayerCountBuff(MAELSTROM_WEAPON) >= 3)))

If im not mistaken, please feel free to correct me or my code, this should use Healing Surge with you are out of combat with mana >= 95 AND my health < 70 OR when im out of combat, my health is < 90% AND i have 5 stacks of Malestorm Weapon OR my mana is >= 90 AND i have >= 3 Stacks of Maelstorm Weapon.

I did this cause almost every time after the combat routine casted healing surge, bringing me in combat with half of mana bar.

BTW, Yeah, i like to complicate things and customize them to slightest detail

 

The routine doesnt show on my HB. Dont know what happen, i was using this and loving it a month ago, but after a break from the game (do to RL issues) i return and did an update to the program and routine, and now cant make this work.
I use other routines and work fine, even try on fresh installations and different classes (priest, pala and shaman).

 

post a log!

 

Alright so I downloaded this and used it one time and it worked great. Went to use it today and keep having a problem. Everytime I open honorbuddy now I get an error that says can't read bytes from 6247AE50 (299). Please can someone help me out? Thanks

 

same here the routine only works 1time, after closing HB delete kingwow and create new svncheckout works

 

The error [299] is an know HB issue: try run HB as administrator.
Is not a CC error but an HB bug.
read here http://www.thebuddyforum.com/honorbuddy-forum/developer-forum/96252-bug-report-could-not-read-bytes-02079efa-299-a.html

 

Hello Attilio,

I did noticed something, a issue in rotation.

Rotation will in many cases use "Lava Lash" before "Flame Shock" this result in DPS loss since "Lava Lash" should always be cast after first "Flame Shock" and after that used when ever its on CD while "Flame shock" debuff is on target.
So, in Single target combat it should always be like this:
Searing Totem > Unleashed Elements > StormStrike > Flame Shock > Lava Lash on CD, but ONLY when target have "Flame Shock" debuff > Earth Shock and 5 Maelstorm weapons Lightning Bolt (Preferably when Stormstrike buff is up) as fillers.

This issue hurts the most AoE rotation, where, if Routine casted "Flame Shock" on one mob, which dies in mean time, it will use "Lava Lash" on other mob, ignoring that target dont have "Flame shock" debuff. After this, "flame Shock" will be casted, but then "Lava Lash" will be on CD, again delaying spreading of "flame Shock" debuff on all targets, which with "Fire Nova" does extended damage and its our main part of AOE rotation.

As for AoE combat rotation with < 7 mobs:
Searing Totem > Unleashed Elements > StormStrike > Flame Shock > Lava Lash on CD, but ONLY when target have "Flame Shock" debuff > Fire Nova > Earth Shock and 5 Maelstorm weapons Chain Lightning (Preferably when Stormstrike buff is up) as fillers.

As for AoE combat rotation with > 7 mobs:
Magma Totem > Unleashed Elements > StormStrike > Flame Shock > Lava Lash on CD, but ONLY when target have "Flame Shock" debuff > Fire Nova > Earth Shock and 5 Maelstorm weapons Chain Lightning (Preferably when Stormstrike buff is up) as fillers.

This issue forces me to manually use "Flame Shock" before my character gets in melee range of mob so "Lava Lash" can be cast on that target to spread "Flame Shock" debuff on other targets in AoE:
I also noticed that Fire Nova is hardly used at all, again, forcing me to manually use it when i spread "Flame Shock" on all targets.

I Edited lines for Lava Lash to this:

Code:

 if (target.IsWithinMeleeRange && utils.GetSpellCooldown(LAVA_LASH).Milliseconds <= StyxWoW.WoWClient.Latency && utils.isAuraActive(FLAME_SHOCK,target))
		{
                    utils.LogActivity(LAVA_LASH, target.Name);
                    return utils.Cast(LAVA_LASH, target);
                }

I think that this should fix the issue, but i havent had chance to test it yet.

Cheers mate and keep up the good work.

 

ty for your repots. Atm i'm studing 5.2 changes and some fix for other CC, but i will start work asap on this.

 

SVN UPDATE:
Some performance emprovements: hope no more FPS loss and healing faster.

ps: i will fix enhancement rotation asap.

 

Updated SVN just now, I'll go run some quick TOES LFR's and see how the improvement on resto is. I'll report back when I'm done.

 

Hello attilio once more

I did noticed that you havent codded few spells for Enhance shamans, like "Ancestral Guidance" and "Astral Shift" so i played around a bit and edited a bit your routine and added this since im using routine currently for grinding rep.

Code:

 
        if (Me.HealthPercent <= 40 && utils.CanCast(ANCESTRAL_GUIDANCE))
		{
                        utils.LogActivity(ANCESTRAL_GUIDANCE);
                        return utils.Cast(ANCESTRAL_GUIDANCE);
		}
	if (utils.isAuraActive(ANCESTRAL_GUIDANCE) && utils.CanCast(ASTRAL_SHIFT)) 
		{
                        utils.LogActivity(ASTRAL_SHIFT);
                        return utils.Cast(ASTRAL_SHIFT);
                }
	if (utils.isAuraActive(ANCESTRAL_GUIDANCE) && utils.CanCast(FERAL_SPIRIT)) 
		{
                        utils.LogActivity(FERAL_SPIRIT);
                        return utils.Cast(FERAL_SPIRIT);
                }
			

I think that you could formulate this code far better, but you get the idea of what it does. It saved my poor geared panda butt countless of times from dying, so i thought that its worth mentioning.

You could add this code and something like "Save my butt" option in your UI to toggle it.

Anyhow, great work on update, routine feels much better!

 

SVN UPDATE:
New CrownControlled unit implementation (TY singular developers)
Option to get target to attack avoiding CCed enemy (used actually only on Disc Priest; default enabled: disable to improve performance)
Fix enhancement Rotation (TY gorunn)
Add in Discipline GUI option for very fast dispell priority (default disabled)
Need Test

 

How to disable auto-facing while in resto spec?

 

yup, auto-facing in resto looks really botish. It would be nice to add option to disable auto-face in UI settings.

 

SVN UPDATE:
Added an option in GUI for autoface target (default enabled)

 

Hello Attilio

First, to be polite and say thank you for all fast updates, fixes and all your time that your'e putting in these routines.

Now, may i ask you to add GUI option to disable auto-target too? The reason why i ask this is that, i had a chance to test your routine in HC raids and routine kept removing my targeting and auto-targeting mob that routine wants it self.
Example: "Stone guard boss" in MV, routine kept changing targets between Quilen's by it self, removing my current target. Same thing is happening on trash mobs before pretty much every boss, but its most noticeable on trash before Gara'jal where im standing in melee range of caster mob, trying to CC/interrupt it, but routine kept changing target to rogue and tanking mobs. This kept happening during whole raid.

Now, few bugs that i noticed regarding enhance:
1. AoE rotation completely ignores settings for healing, its only firing my "save my butt" part of code that i posted few posts back.
2. AoE rotation completely ignores spending maelstorm weapon stacks and Using Flame Nova when you are in AoE fight with 10+ mobs (trash in front of Stone Guard, Gara'jal)
3. In AoE fights where Flame shock is spread from target A to target B with Lava Lash used on Target A, routine will not use Lava Lash at all if your'e targeting Target B, even so target B has a Flame Shock debuff. This is fixed by reapplying Flame Shock to target B. In short, routine will not use Lava Lash on any target in AoE fight which received Flame Shock debuff from main target.
4. Routine ignores changed settings for number of targets when Fire Nova will be used. I have it set to 3, it doesnt fire at all, even on 4 mobs, but it fires as it should if you are in fight with more than 5 targets.
5. Auto-Move is interrupting healing cast, that is if you use, for example Grind Bot, and you are below low HP threshold routine will start casting Healing Surge and after a sec continue to move, canceling cast and leaving you to enter new pull with low HP (thats why i added my "Save my butt" code.
6. After combat, if you are below settings for low HP threshold, routine will ignore if you are mounted and try to heal, that is, even if you are mounted and flying, routine will dismount and try to heal you, making my character, in most cases like a pancake splatted and dead on the ground.
7. If weapon buffs expire during combat, routine will not refresh them, instead it will try to keep its rotation going, which cannot be done without weapon buffs. End result is that character will just stand until hes dead, while routine will just write "Casting Unleashed Elements, target."
Generally routine behaves outstanding in single target fights, but as soon as i enter combat where there is more than 5 targets, routines goes bonkers.

EDIT: You might also implement Elemental Blast in rotation, i see that its implemented in routine, but not in rotation. It will be, most probably favored t6 talent since it has now chance to increase Enhance Shamans Agility for 8 sec.