[Released] YBMoP-BT-Rogue

i updated the svn. lost loads of dps. from like 60k+ on dummy down to 33ish? did fresh install try as well. seems to not be envenoming at 5 cp and at all for me and if so very infrequently, also energy capping a lot

also seems that the opening sequence of the vanish prep vanish still is bugged for me after the update. it seemed to have worked fine for me before.
im i doing just a scrub mistake i dont see? ive never had a problem like this.



*found an old version of the cc so using that. for now. seems to work fine*

 

Raided a while with this yesterday, I do have 1 thing thats bothering me!

The use of cooldowns, we where doing Elegon, and cooldowns where being popped before I got into melee range, so wasting a fiew seconds.
Is it possible to wait and pop cooldowns untill you are actually hitting it? Like add the condition that if for example Deadly Poison is on the boss it will pop CDs, otherwise wait.

Doesnt have to be Deadly Poison, but some of the debuffs that you basicly applie from the start. This way we get to fight the boss for about a second before the cooldowns are being used and no CD-time is wasted!

 

Sounds interesting.. Because i have Me.CurrentTarget != null && Me.CurrentTarget.IsWithinMeleeRange on all cooldowns, so it shouldn't do that..

But I've got good news for you, I've added Me.CurrentTarget.HasAura(2818) (Deadly Poison check) on all cooldowns now, rest of the cooldowns are waiting on Vendetta

 

Should be fixed now, I had a typo in the Envenom checks.

 

Good stuff mate!

Ill keep using this Routine and report if there is anything else I can find to improve it!

EDIT: Just tested it, Blood Fury is still not being used!

 

Weird. I'll look into it.

Try the latest one now

 

i'll give it a go threw LFR when i ding 90 on my rogue ;D

 

Sorry, still not using it. I did only try it on a dummy though, but that shouldnt matter, right?

Also, just noticed, when it uses Vanish it should instantly use Mutilate, but right now it just goes back to the "pre-pull" stage.


EDIT: I see you have added Blood Fury to the code, perhaps try to use the spell ID instead? Its id=20572

 

It only triggers with Deadly Poison & Vendetta + Setting made in GUI. The code looks fine, as its close to the same as in our warrior routine. It works there.

 

Well, I have it set to Boss/Dummy, just like vendetta and Shadow blades. Ran all of ToES now, havent casted blood fury even once :/


EDIT:
I dont completely understand the code, but i found this:
Me.HasAura("Vendetta")

Isnt this supposed to be "Me.CurrentTarget.HasAura"? Vendetta is a debuff to the boss, not a buff to me!

Or perhaps it is Buff.TargetHasDebuff, I dont know the difference


EDIT2:
Dont know if it will make any difference, but the warrior code also have a part saying ", ret => Me.Race == WoWRace.Orc && ("

 

The AoE rotation should basicly be the same as the single target rotation btw, just change Mutilate/Dispatch with FoK, and change Rupture with Crimson tempest. This info is from the assassination topic from Elitistjerks btw!

 

I'm waiting on numbers from 5.2 patch, obviously Crimson Tempest got a huge buff in 5.2. So until then I'm just waiting!

 

Changed Me.HasAura("Vendetta") to Me.CurrentTarget.HasAura("Vendetta"), and now Blood Fury is working! You might wanna change that on the SVN Since Vendetta is not a buff to me, its a debuff to the target!

Alright, sounds fair enough

 

Ah lol, I forgot to change that.. thought I did.. I don't think I'll update any code in half-asleep next time

Updated

 

Thumbs up!

Is there any possibility to get a Allways/onboss/onBL/Never for Vanish? I prefer to do this one manually!

 

I'll add an Disable / Enable option in the GUI soon.

 

Great!

Ill keep using this one, give you pointers and stuff when I can

 

There we go added! + changed so it only refreshes rupture on 2 or less seconds (5 combo points does have higher priority than 1 or more combo points)

 

Is it possible to change the rotation to skip rupture on specific mobs? Like sparks on Elegon, adds in the spirit realm on the spitirbinder. They die of 3 mutilate and an envenom, using the standard rupture rotation slows this down ALOT!

If it is possible to do this I can compile a list of mobIDs for all the current raids that needs to have a shorter burst rotation. Like 1p SnD, 3-4+ envenom spam and thats it!

 

Sorry, totally forgot about that! Ill try to squeeze you in between work and raid tonight