TuanHA Death Knight- The Ultimate Experience

I've test CR a lot last few day and almost every error have been fixed... well except the [299]

The [299] bug happen ration is the same as before (a little more than paladin/monk) and it totally acceptable for me.

I may revert back to reduce it but it will hurt performance so it a good trade imo

 

is it a individual or general error? anyone can play without error??

 

i play with the routine exactly as zeldrak suggested to setup hb, i do that with al my toons, seperate hb install, remove everything i do not need and i never have issues

 

So... this cc is preeeeetty beast in frost for pve and pvp. I recently tried out blood and had a question.
When farming dungeons or scenarios or such (anything where I do not have a handy healer with me) I seem to have a problem getting my dk to use Conversion twice in one fight. It is set at default 60% (which is a logical point imo) when hp hits 60% it uses Conversion just fine until runic power runs out. However, if in that same fight my hp reaches 60% again, it doesn't use Conversion again, no matter where my runic power is. Is that intentional or can I tweek it somehow to do my bidding?

 

what have you deleted, after the fresh install?

 

It not intended and I need a log to confirm

 

Hey Maxfx under the survive part it says blood presence HP below(in the middle of the all of the choices) unmark that.

 

Finally, after pvp tests, sometimes it stops working (for me after 1-2 BG) and randomly slow rotation

 

i have the same issue, it sees like the rotation will pause its self, the only way i can fix it is to exit HB and open a new one..

 

Gah, I can't seem to locate my dungeon log when I discovered the issue, so I made it quest for awhile to test it out again. Its long and most of it is useless, but after a few deaths you kinda get the jist of it. It will cast Conversion maybe half the time. It seems to like to cast it AFTER combat a lot (which isn't really a negetive I suppose). If it's just a simple settings issue and I'm just an idiot, feel free to tell me so and I will adjust it. Alternately, if I need to run a dungeon again to be sure, I can do that too. Just got a bit lazy tonight D:

View attachment 8656 2013-02-22 19.39.txt

 

This is the code for conversion:

Code:

private Composite Conversion()
        {
            return new Decorator(
                ret =>
                THSettings.Instance.HealAttack &&
                //!Me.Mounted &&
                !Me.HasAura("Conversion") &&
                Me.CurrentRunicPower >= 10 &&
                !HoldSpendingRunicPower() &&
                !Casting() &&
                SpellManager.HasSpell("Conversion") &&
                (Me.HealthPercent <= THSettings.Instance.HealAttackHP ||
                 !Me.Combat &&
                 Me.HealthPercent <= 85) &&
                SpellManager.CanCast("Conversion"),
                new Action(delegate
                    {
                        //Logging.Write(LogLevel.Diagnostic, "Conversion");
                        //SafelyFacingTarget(Me.CurrentTarget);
                        CastSpell("Conversion", Me);
                    }));
        }

As I see in your log, it use conversion if you are below your setting percent. (that intended)

But you will see it still use conversion if your hp above this percent (seem like not intended) is because of this part "(!Me.Combat && Me.HealthPercent <= 85)"

It mean when you out of combat, your HP is above your setting percent and you have Runic Power, instead of wasting it, Combat Routine will Convert the remaining Runic Power to top you up.

I think the logic of using conversion on the soon to be drained Runic Power is better than just wait Runic Power go off without use.

 

Doesnt work at all for me now, tried even a seperate folder only with LR and the routine but stops casting directly after i press start in the log its the same error over and over again:

(Log file was way to big so just took a part of it)

[08:43:09.517 D] Styx.InvalidObjectPointerException: Cannot read a descriptor on an invalid object.
at Styx.WoWInternals.WoWObjects.WoWObject.
[
](UInt32 )
at Styx.WoWInternals.WoWObjects.WoWUnit.
[
]( )
at Styx.WoWInternals.WoWObjects.WoWUnit.GetMaxPower(WoWPowerType type)
at Styx.WoWInternals.WoWObjects.WoWUnit.get_MaxHealth()
at TuanHA_DK.Classname.<GetUnitControlUndead>b__97(WoWUnit unit) in c:\Users\NAME\Desktop\Honorbuddy DK\Routines\TuanHADKSpecialEdition\THCommon.cs:line 768
at System.Linq.EnumerableSorter`2.ComputeKeys(TElement[] elements, Int32 count)
at System.Linq.EnumerableSorter`1.Sort(TElement[] elements, Int32 count)
at System.Linq.OrderedEnumerable`1.<GetEnumerator>d__0.MoveNext()
at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
at System.Linq.OrderedEnumerable`1.<GetEnumerator>d__0.MoveNext()
at System.Linq.Enumerable.WhereEnumerableIterator`1.MoveNext()
at System.Linq.Enumerable.FirstOrDefault[TSource](IEnumerable`1 source)
at TuanHA_DK.Classname.GetUnitControlUndead() in c:\Users\Brinka\Desktop\Honorbuddy DK\Routines\TuanHADKSpecialEdition\THCommon.cs:line 767
at TuanHA_DK.Classname.<ControlUndead>b__a7(Object ret) in c:\Users\Brinka\Desktop\Honorbuddy DK\Routines\TuanHADKSpecialEdition\THCommon.cs:line 806
at Styx.TreeSharp.Decorator.CanRun(Object context)
at Styx.TreeSharp.Decorator.
.
()
at Styx.TreeSharp.Composite.Tick(Object context)
at Styx.TreeSharp.PrioritySelector.
.
()
at Styx.TreeSharp.Composite.Tick(Object context)
at Styx.TreeSharp.Decorator.
.
()
at Styx.TreeSharp.Composite.Tick(Object context)
at Styx.TreeSharp.PrioritySelector.
.
()
at Styx.TreeSharp.Composite.Tick(Object context)
at Styx.TreeSharp.Decorator.
.
()
at Styx.TreeSharp.Composite.Tick(Object context)
at Styx.TreeSharp.PrioritySelector.
.
()
at Styx.TreeSharp.Composite.Tick(Object context)
at Styx.TreeSharp.PrioritySelector.
.
()
at Styx.TreeSharp.Composite.Tick(Object context)
at Styx.TreeSharp.PrioritySelector.
.
()
at Styx.TreeSharp.Composite.Tick(Object context)
at Styx.TreeSharp.Decorator.
.
()
at Styx.TreeSharp.Composite.Tick(Object context)
at Styx.TreeSharp.PrioritySelector.
.
()
at Styx.TreeSharp.Composite.Tick(Object context)
at Styx.CommonBot.TreeRoot.()
[08:43:09.518 D] Cleared POI - Reason Exception in Root.Tick()
[08:43:09.518 D] Cleared POI
[08:43:09.570 D] Styx.InvalidObjectPointerException: Cannot read a descriptor on an invalid object.

 

I just commit new revision trying to fix it, pls update svn and let me know.

 

and some 299 errors:

 

Yea that got it to work for me again, thx alot

 

Hello TuanHA,

Can you tell me are you planning to add another payment method for donations? something like google wallet (since there is not fees at all) or Moneybookers? I would like to donate for all available routines and upcoming updates, but im unable to do so via paypal since its not yet supported in my country.

 

I love to have some US iTunes Gift Card or US WoW Game Time ^.^ that free me up from worry about wow subscription expire and focus on making more CC that you guy enjoy WoW more

 

hI tuanha

Can you make a warrior cc PLEASSSSSSSSSSSSSSSSSSSSSSSSSSSE! all of your cc's kick ass.
Most others want you to pay and it was never like that years ago.
I'd be up for donating for a warrior CC when I get my disability check @ the end of the month, "I'm permanently disabled" I have alot of time to play wow & my warrior is my favorite character ever since ever!!!"
I don't like any of the other warrior cc's I'd rather play it manually, but if you made a warrior cc, I know I'd love it!
YOUR THE MAN BRO!

Ps
Peeeeeeeeeeeeeeeeease!!!!!!!!!! please. please. please.. please...

Thank you
Gino ~

 

Thank you for your kind words, you just got donated
Confirmation number: 2WX90066X1619154D

PS: I don't have plan for Warrior CC now, I'm trying to get Hunter CC up and running on 5.2. BTW, in 5.2 Warrior is so OP and I'll open for anything after finishing Hunter

 

the Rev.68 fixed my 299er Error!!! i can play DK now ^^ thnx!