• Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • Charnames in Logfiles

    Discussion in 'Honorbuddy Forum' started by dominic.e, Jun 22, 2013.

    1. dominic.e

      dominic.e New Member

      Joined:
      May 18, 2013
      Messages:
      208
      Likes Received:
      0
      Trophy Points:
      0
      Hey guys,
      There is a little problem in some plugins/profiles i think. Maybe all developer should look into their code.
      I am a worg druid and some minutes ago i had an error, so i looked into logfile.
      And there i found a row where the name of my char is written, where it casts Mark of wild
      Like "Mark of Wild on ****"

      I think its too dangerous to let write the charnames into logfiles.

      Maybe other classes have similar lines of logs where there name is in.

      Pls look into logfile, and erase your names before you upload them ;)
       
    2. buzzerbeater

      buzzerbeater Well-Known Member

      Joined:
      Mar 21, 2011
      Messages:
      5,419
      Likes Received:
      28
      Trophy Points:
      48
      Which Routine?
       
    3. tumbum

      tumbum Active Member

      Joined:
      Mar 17, 2011
      Messages:
      3,341
      Likes Received:
      13
      Trophy Points:
      38
      checked my druid running with questing and singular. there is no charname in the logfile.
       
    4. randomstraw

      randomstraw Community Developer

      Joined:
      Jul 17, 2012
      Messages:
      1,611
      Likes Received:
      10
      Trophy Points:
      38
      I've also seen this before, and it is a problem.

      In my Plugins/Routines I am (since aware) always using something like

      Logging.Write("[Targetting: {0}.{1}]", unit.Class, unit.Guid.ToString().Substring(8,4));

      which includes some info, but never enough to clearly identify anyone.

      regards,
      straw
       
    5. dominic.e

      dominic.e New Member

      Joined:
      May 18, 2013
      Messages:
      208
      Likes Received:
      0
      Trophy Points:
      0
      Omg, i think it was HazzDruid. Or PR2, but i think it was while using HazzDruid.
       
    6. chinajade

      chinajade Well-Known Member Moderator Buddy Core Dev

      Joined:
      Jul 20, 2010
      Messages:
      17,540
      Likes Received:
      172
      Trophy Points:
      63
      Hi, Dominic.e,

      Indeed, BosslandGmbH considers leaked toon names or realms to be a bug. If you look at Singular, it uses the word "Self" or "Pet" for your toon name and pet respectively. For friendly players, Singular identifies by role/spec: "lead", "tank", "healer", "dps". For enemies, it merely uses "Enemy" to represent another player. Similar techniques are used for the BosslandGmbH-provided quest behaviors.

      Alas, there are a number of third-party offerings available in the forums. And leaking such information is most likely an oversight in the offering.

      Please try to isolate the source of the leak, and report the issue to the appropriate thread.

      cheers,
      chinajade
       
      Last edited: Jun 23, 2013
    7. dominic.e

      dominic.e New Member

      Joined:
      May 18, 2013
      Messages:
      208
      Likes Received:
      0
      Trophy Points:
      0
      Okay, thanks for this information ;) will look into log and will look from which CR/Plugin it comes
       
    8. marskingsize

      marskingsize New Member

      Joined:
      Nov 1, 2012
      Messages:
      192
      Likes Received:
      2
      Trophy Points:
      0
      I looked into my LOGs, and it?s from HazzDruid 4.3.1

      Code:
      [20:37:56.095 D] Cleared POI - Reason Exception in Root.Tick()
      [20:37:56.095 D] Cleared POI
      [20:38:42.415 D] [CGSpellBook::CastSpell] Override ID: 1822, KnownIndex: 39
      [20:38:42.446 N] Rake Sp?her von Darnassus
      [20:38:44.641 D] [CGSpellBook::CastSpell] Override ID: 33917, KnownIndex: 56
      [20:38:44.669 N] Mangle Sp?her von Darnassus
      [20:38:46.960 D] [CGSpellBook::CastSpell] Override ID: 33917, KnownIndex: 56
      [20:38:46.987 N] Mangle Sp?her von Darnassus
      [20:38:49.111 D] [CGSpellBook::CastSpell] Override ID: 33917, KnownIndex: 56
      [20:38:49.142 N] Mangle Sp?her von Darnassus
      [20:38:50.731 D] [CGSpellBook::CastSpell] Override ID: 774, KnownIndex: 49
      [20:38:50.758 N] Rejuvenation [COLOR="#FF0000"]xxxxxxx[/COLOR]
      [20:38:53.200 D] [CGSpellBook::CastSpell] Override ID: 768, KnownIndex: 37
      [20:38:53.231 N] Cat Form [COLOR="#FF0000"]xxxxxx[/COLOR]
      [20:38:55.088 D] [CGSpellBook::CastSpell] Override ID: 1822, KnownIndex: 39
      [20:38:55.115 N] Rake Sp?her von Darnassus
      [20:38:57.129 D] [CGSpellBook::CastSpell] Override ID: 1079, KnownIndex: 55
      [20:38:57.157 N] Rip Sp?her von Darnassus
      The xxxxxx ist the name of my char.


      Not so good :(
       
    9. dominic.e

      dominic.e New Member

      Joined:
      May 18, 2013
      Messages:
      208
      Likes Received:
      0
      Trophy Points:
      0
      Thanks mate ;) its not really good, youre right :D
       
    10. randomstraw

      randomstraw Community Developer

      Joined:
      Jul 17, 2012
      Messages:
      1,611
      Likes Received:
      10
      Trophy Points:
      38
      go ahead and report it in hazz' thread
       
    11. Stormchasing

      Stormchasing Community Developer

      Joined:
      Jan 15, 2011
      Messages:
      4,029
      Likes Received:
      48
      Trophy Points:
      48
      PureRotation Team will take this as a suggestion and we will change related code to something similar like Role + Class and/or maybe GUID
      normally we need it only for debugging to make sure that healing is working ... and not only for self healing :) but yes of course we can do some changes here and there to remove the toon names and still have all necessary informations for us


      ---- edit -----
      we checked the code in pure
      Result: small bug in log output fixed where a players name could be logged (this case shouldn't ever kick in since it was part of EncounterSpecific stuff, but ... to be sure, we replaced it now with SafeName)

      So with PureRotation there shouldn't be any Player Names in the log, we already used the methods to log only Class (instead of roles or something else)
       
      Last edited: Jun 23, 2013
    12. Cocaine

      Cocaine Banned

      Joined:
      Aug 21, 2012
      Messages:
      709
      Likes Received:
      2
      Trophy Points:
      0
      Honorbuddy itself and Singular don't log character names anymore, it did at one point. I'd just ctrl+F <character name> before posting a log.
       
    13. dominic.e

      dominic.e New Member

      Joined:
      May 18, 2013
      Messages:
      208
      Likes Received:
      0
      Trophy Points:
      0
      @Stormchasing, thank you and you're 'Team' for looking into your code ;)

      Yep, it's always better to look into logs, before upload them. There are many Freeware editors, which have a replace function, so you can press ctrl+F, and then you can set a string, which should be replaced and you can set a string, to what it should be replaced, so you can write
      Search for: xyCharNameyx
      Replace with: xxxxxx

      I recommend you Notepad++ ;) its a powerful editor and much better than Notepad from Windows ^^
       
    14. Inrego

      Inrego New Member Buddy Store Developer

      Joined:
      Feb 7, 2010
      Messages:
      2,765
      Likes Received:
      71
      Trophy Points:
      0
      The notepad that ships with Windows has this functionality aswell.

      In most editors, the shortcut key is Ctrl + H
       
    15. dominic.e

      dominic.e New Member

      Joined:
      May 18, 2013
      Messages:
      208
      Likes Received:
      0
      Trophy Points:
      0
      Ok thanks, didnt know it before ^^ I dont use Notepad :D
       

    Share This Page