Magitek - All In One - Still going strong!

Tested and Dragoon still does the same thing although not everytime. It's more like every other time.

 

Now Magitek isn't working for me at all. I don't know why. I'll post a log.

It's just running to the fate and stops.I'll post a log. View attachment 3912 2014-09-28 00.20.txt

 

The above is what is causing your problem.

Code:

public static Composite Cast(Selection<string> spell, Selection<bool> reqs = null, Selection<GameObject> onTarget = null, Selection<int> nonspam = null, Selection<bool> doublecast = null)
        {
            return new Decorator(ret =>
            {
              [B]if (!Actionmanager.HasSpell(spell(ret)))[/B]
                    return false;

The bolded line above is exactly where it is dieing at. This tells me that at some point, null is being passed in for "spell". Need to check the Dragoon.cs file in the Rotations to see if there's a typo or something.

 

Not really sure what could have caused this besides setting the pull range way longer than that is actually possible, and I wasn't able to reproduce it actually running fates, but I've made a change that should make it not happen anymore. Note that the pull range box in the dragoon job settings actually does something now, so don't go setting it any higher than like 14 since piercing talon maxes out at 15.

 

Updated: Should fix an issue where no acceptable skill could be used while fate botting.

 

Odd, piercing talon has always been 40 by default for me.

 

Testing now, and I adjusted Piercing Talon. Seems to be working well but I just started.

I have a suggestion if it's possible. The ability to change your Chocobo Companion stance say from Healer to DPS based on HP%. I'm not sure if this is a request for Magitek or better for a plugin. I apologize in advance.

 

Just had an issue with me arriving at a FATE and it just sitting there on the Chocobo not engaging anything. May be a FATEbot issue after update though.

 

Interrupt error again
pls fix it.

 

That's because that pull range box wasn't actually being used but it is now. If you set it further than any ability can reach, that will happen with every class.

 

If this is something I can fix, it should be fixed now with the update I'm making.

 

Update : Fixed null reference error when trying to interrupt.

 

Hi Ichiba! Thanks for the fix. Can I request that you put the current Revision in your first post, for players using your SVN update, so we can stay up to date and revise.

 

Thank you!

++
i tested. still not work.

 

What specific ability are you trying to silence? I've tried this a bunch of times on a bunch of different abilities in a lot of different instances I never get this. Try making a new folder with a fresh install of RB and Magitek and see if it still happens.

 

helloes and thanks for everything you do!

i purchased RB yesterday and was a long time HB/DB user.

i'm leveling side jobs and am having issues with BLM. Specificaly not using Transpose or crossclass skills such as Raging Strikes. It's not using my High Quality food either...thats all i got for now

 

I tested this some more today and it looks like it can't really be fixed right now. Certain abilities don't correctly return their name when queried. Maybe abilities added since 2.3 or maybe earlier haven't been indexed. The only real option right now is disabling interrupt.

 

I'm going to reply in the Community Developer Forum as well....but this is the code I have in MoreDots for Bard's BluntArrow:

Code:

private async Task<bool> BluntArrow()
        {
            var partyManager = new HealManager.HealingManager();
            var _totalParty = partyManager.TotalParty.Select(r => r.ObjectId).ToList();
            var spells = new List<string> { ConjurerSpells.CureII.Name, ConjurerSpells.Medica.Name, ConjurerSpells.MedicaII.Name, ArcanistSpells.Physick.Name, ScholarSpells.Adloquium.Name };

            var unit = (from a in GameObjectManager.GetObjectsOfType<BattleCharacter>()
                        where a.CanAttack
                        where !_totalParty.Contains(a.ObjectId)
                        where a.Distance(Core.Player) < 25
                        where a.IsCasting && spells.Contains(a.SpellCastInfo.SpellData.Name)
                        select a).FirstOrDefault();


            if (unit != null)
            {
                await BardSpells.BluntArrow.Cast(unit);
                Logging.Write(Colors.OrangeRed, "[MoreDots] Interrupting " + unit.Name);
            }
            {
                return false;
            }
        }

This doesn't exactly translate over to the Treesharp that Magitek is written in....but try using SpellCastInfo.SpellData.Name instead of just SpellCastInfo.Name. I think doing that will fix your issue.

 

Often times, using the Fate Hunter, it would target a monster who's not part of the fate, and while my DRG will run up to the fate mobs, it won't target the fate mobs, leaving the target stuck on the non-fate mob.

Have tried targeting style : Fate Mob as well as Closest enemy.

 

Mastahg seems to suggest that my code is fine and that there is actually a problem with SpellCastInfo.Name.


If anyone else notices abilities that cause magitek to stop acting while the enemy is casting or abilities that it won't interrupt, please note the ability name and run this in your console and report what it returns.

Code:

Log(((BattleCharacter)Core.Player.CurrentTarget).SpellCastInfo.ActionId);
Log(((BattleCharacter)Core.Player.CurrentTarget).SpellCastInfo.ActionType);

I will be doing this myself as well, but it will help a lot to get this done faster and to get info on abilities I might not encounter. Thanks.

EDIT: Nevermind for now I guess. Mastahg says he found what the issue is and it will probably be fixed in tomorrow's patch.