BotBase Targeting

I've noticed that sometimes when moving to a POI (in both Fatebot and Orderbot) that sometimes the bot will reach the POI and then stand there with no target. I think when it happens it's trying to target something that isn't in LoS as if I manually move the character around it will eventually target a mob and proceed as usual.

Is there any way we could improve the logic so that if the player is just standing @ a POI and hasn't had a target in a while it moves to a random point near that POI (to try to get LoS on the intended target) or tries a new POI or something? I noticed it quite a few times personally and now I've noticed reports of others experiencing it as well.

Let me know if you need any data/testing and I'll do my best to oblige.

 

I think this might be because it's trying to target but can't yet
I added this to my pull method

Code:

o = o ?? Core.Me.CurrentTarget;
if (o == null && Core.Target != null && !MovementManager.IsMoving && !(Movement.IsInSafeRange(Core.Target)&& Core.Target.InLineOfSight()))
    {
     Logging.Write(Colors.SkyBlue, "[RebornCo] Searching for Core.Target");
     await Coroutine.ExternalTask(Task.Run(() => Movement.MoveTo(Core.Target)));
     return true; 
     }

 

If that's true then it might just be that the Botbase is releasing movement control too early. It needs to keep moving towards the first PoI (Core.Target?) until we have a Core.Player.CurrentTarget, then release control to the CR.

Does that sound right mastahg?