• Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • Recalculating after each move?

    Discussion in 'Hearthbuddy Support' started by Gorm, Mar 25, 2015.

    1. Gorm

      Gorm Member

      Joined:
      Jun 11, 2012
      Messages:
      234
      Likes Received:
      2
      Trophy Points:
      18
      It looks like Silverfish is recalculating after every individual move even when there was no secret/draw/random action. I looked at the code and it confirms my findings.

      Will this be fixed?
       
    2. Tony

      Tony "The Bee" Staff Member Moderator

      Joined:
      Jan 15, 2010
      Messages:
      128,834
      Likes Received:
      571
      Trophy Points:
      113
      is that a problem?
       
    3. Gorm

      Gorm Member

      Joined:
      Jun 11, 2012
      Messages:
      234
      Likes Received:
      2
      Trophy Points:
      18
      Yes it is inefficient and makes the bot look more like a bot and this is probably one of the main reasons why people say it is easy to tell Hearthbuddy is a bot.

      The way it should work is that the board state is sent to UAI once and a list of moves is returned for the bot to do.

      Unless there is something that can't be predicted like a secret or a random effect like knife juggler, there should be no need to recalculate more than once every turn.

      There's no reason for UAI to do this as it is capable of running without recalculating every single move.
       
    4. Tony

      Tony "The Bee" Staff Member Moderator

      Joined:
      Jan 15, 2010
      Messages:
      128,834
      Likes Received:
      571
      Trophy Points:
      113
      whats your pc specs?
       
    5. Gorm

      Gorm Member

      Joined:
      Jun 11, 2012
      Messages:
      234
      Likes Received:
      2
      Trophy Points:
      18
      It is an i5-4440. This is not a problem with my computer being too slow.

      Most of the times it may not be noticeable, but when there are 10 units on the board, even the fastest computers will take several seconds to recalculate from scratch.

      None of the other bots are like this, even when they also use UAI.
       
    6. Tony

      Tony "The Bee" Staff Member Moderator

      Joined:
      Jan 15, 2010
      Messages:
      128,834
      Likes Received:
      571
      Trophy Points:
      113
      upload your log file about the issue in description plz
       
    7. Gorm

      Gorm Member

      Joined:
      Jun 11, 2012
      Messages:
      234
      Likes Received:
      2
      Trophy Points:
      18
      Ok but it isn't going to help because I looked at other people's logs and they have the same issue. And I have pinpointed the problem in the code.

      As you can see here, the bot tells UAI to recalculate after every single move. Even though it only takes a few milliseconds to calculate the move according to the logger, there's like a 4 second delay between the move and the next action. This should be shortened to 1-2 seconds.

      2015-03-24 06:26:21,259 [23] DEBUG Logger (null) - [GameplayScene_MAIN_ACTION_Friendly] Waiting to be in this state longer.
      2015-03-24 06:26:24,672 [23] INFO Logger (null) - calculating stuff... 23:26:24.6721
      2015-03-24 06:26:25,092 [23] INFO Logger (null) - calculating ended! 23:26:25.0923
      2015-03-24 06:26:25,093 [23] INFO Logger (null) - play action
      2015-03-24 06:26:25,126 [23] INFO Logger (null) - use ablitiy: Steady Shot target Thrall
      2015-03-24 06:26:29,781 [23] INFO Logger (null) - calculating stuff... 23:26:29.7816
      2015-03-24 06:26:29,941 [23] INFO Logger (null) - calculating ended! 23:26:29.9416
      2015-03-24 06:26:29,942 [23] INFO Logger (null) - play action
      2015-03-24 06:26:29,983 [23] INFO Logger (null) - minion attack: Timber Wolf target: Thrall
      2015-03-24 06:26:33,526 [23] INFO Logger (null) - calculating stuff... 23:26:33.5269
      2015-03-24 06:26:33,691 [23] INFO Logger (null) - calculating ended! 23:26:33.6919
      2015-03-24 06:26:33,692 [23] INFO Logger (null) - end turn
       

      Attached Files:

    8. Tony

      Tony "The Bee" Staff Member Moderator

      Joined:
      Jan 15, 2010
      Messages:
      128,834
      Likes Received:
      571
      Trophy Points:
      113
      i will try to reproduce this,i see no delay atm here tho
       
    9. Gorm

      Gorm Member

      Joined:
      Jun 11, 2012
      Messages:
      234
      Likes Received:
      2
      Trophy Points:
      18
      Tony, it says right in the logs how long the delay is.

      2015-03-24 06:26:24,672 [23] INFO Logger (null) - calculating stuff... 23:26:24.6721
      ....
      2015-03-24 06:26:29,781 [23] INFO Logger (null) - calculating stuff... 23:26:29.7816

      That's a 5 second delay between 2 actions on the same turn.

      Everyone is getting this issue.

      https://www.thebuddyforum.com/hearthbuddy-forum/hearthbuddy-support/209072-calculating-move-empty-boards-causing-wasted-time-lag.html
      https://www.thebuddyforum.com/hearthbuddy-forum/hearthbuddy-support/208993-lags-botting.html

      Even people that do not report lag have the same delay in their logs. The cause is not a mystery. I looked at the silverfish/UAI code and confirmed it is a problem with the way it interfaces with hearthbuddy.

      https://www.thebuddyforum.com/hearthbuddy-forum/hearthbuddy-support/207182-bot-crashing.html

      I have also used the other 2 major bots and none of them have this issue and one of them also uses UAI.
       
      Last edited: Mar 26, 2015
    10. Tony

      Tony "The Bee" Staff Member Moderator

      Joined:
      Jan 15, 2010
      Messages:
      128,834
      Likes Received:
      571
      Trophy Points:
      113
      set MsBetweenTicks to 5
       
    11. Gorm

      Gorm Member

      Joined:
      Jun 11, 2012
      Messages:
      234
      Likes Received:
      2
      Trophy Points:
      18
      I already tried setting them to 1, 5, 10, 500, it doesn't make a noticeable difference.
       
    12. Ange

      Ange New Member

      Joined:
      Sep 8, 2014
      Messages:
      17
      Likes Received:
      0
      Trophy Points:
      0
      Hello tony how you can change set MsBetweenTicks to 5
       
    13. Tony

      Tony "The Bee" Staff Member Moderator

      Joined:
      Jan 15, 2010
      Messages:
      128,834
      Likes Received:
      571
      Trophy Points:
      113
      its under settings




      @Gorm

      can you post a fresh log file plz?
       
    14. Gorm

      Gorm Member

      Joined:
      Jun 11, 2012
      Messages:
      234
      Likes Received:
      2
      Trophy Points:
      18
      No I can't because my key expired.

      Tony, I understand you deal with many technically inept people and that's why you always ask for logs, but I am not one of them. You should have been able to tell from my posting history.

      If you cannot see the delay on your own computer even though everyone's logs are showing the delay, then you are used to it. I have tried all the major bots for hearthstone and none of them have this issue.
       
    15. Tony

      Tony "The Bee" Staff Member Moderator

      Joined:
      Jan 15, 2010
      Messages:
      128,834
      Likes Received:
      571
      Trophy Points:
      113
      well it works as it should on my machine and on 99% of our users

      what it prints in log file (time stamps) its what it does as well


      if possible i would like to see the delay you are talking about on a video or via teamviewer
       
    16. Gorm

      Gorm Member

      Joined:
      Jun 11, 2012
      Messages:
      234
      Likes Received:
      2
      Trophy Points:
      18
      I'm sorry but as I said my license already expired and I don't plan to renew it just so I can prove this to you when anyone can see it exists by running the bot for a few seconds.

      I don't know why you refuse to believe it when I've showed you multiple people complaining about it, and even the people that aren't complaining about it show the same timings in their logs. Maybe you can post your logs? You could try counting the seconds the bot takes between moves, and then compare this to how long it takes you to make a move without the bot.

      I would also suggest that you and pushedx try the other 2 major bots and see how smoothly they run.

      As I already said, other people are reporting this issue, it isn't just me.

      https://www.thebuddyforum.com/hearthbuddy-forum/hearthbuddy-support/208993-lags-botting.html
      https://www.thebuddyforum.com/heart...ove-empty-boards-causing-wasted-time-lag.html

      Any random log file in the support section I open also has a 4-5 second delay between moves on the same turn. Here is another one I randomly picked out.

      https://www.thebuddyforum.com/hearthbuddy-forum/hearthbuddy-support/207725-missplay.html

      2015-03-14 06:08:45,150 [17] INFO Logger (null) - calculating stuff... 11:08:45.1506
      2015-03-14 06:08:45,159 [17] INFO Logger (null) - calculating ended! 11:08:45.1596
      2015-03-14 06:08:45,160 [17] INFO Logger (null) - play action
      2015-03-14 06:08:45,179 [17] INFO Logger (null) - play: Ùèòîíîñåö Ñåí'äæèí target nothing
      2015-03-14 06:08:46,635 [17] INFO Logger (null) - [UseAt] 1
      2015-03-14 06:08:50,506 [17] INFO Logger (null) - calculating stuff... 11:08:50.5069

      As you can see here that's a 5 second delay inbetween moves on the same turn, proven by the log files.


      In this thread, multiple users are complaining about the speed of the bot.

      https://www.thebuddyforum.com/hearthbuddy-forum/206108-current-bot-2.html
       
      Last edited: Mar 28, 2015
    17. Tony

      Tony "The Bee" Staff Member Moderator

      Joined:
      Jan 15, 2010
      Messages:
      128,834
      Likes Received:
      571
      Trophy Points:
      113
      your key is not a problem we can extend it

      pm me your Skype and we will teamviewer


      dont link me other's people threads and stuff,we are here to solve your issue
       
    18. MaxMuster

      MaxMuster Well-Known Member Buddy Store Developer

      Joined:
      Jan 30, 2012
      Messages:
      1,735
      Likes Received:
      30
      Trophy Points:
      48
    19. Tony

      Tony "The Bee" Staff Member Moderator

      Joined:
      Jan 15, 2010
      Messages:
      128,834
      Likes Received:
      571
      Trophy Points:
      113
      Max is right,its Kaspersky
       
    20. Gorm

      Gorm Member

      Joined:
      Jun 11, 2012
      Messages:
      234
      Likes Received:
      2
      Trophy Points:
      18
      No I don't have Kaspersky. I have not had any lag problems like this in the other buddy bots.
       

    Share This Page