• Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • [PAID] Ultimate Interrupter - The Intelligent Interrupter

    Discussion in 'Combat' started by Phelon, Dec 11, 2014.

    1. Phelon

      Phelon Well-Known Member Buddy Store Developer

      Joined:
      Jan 15, 2010
      Messages:
      2,591
      Likes Received:
      140
      Trophy Points:
      63
      1. The thing is though.. you don't need to switch targets due to how honorbuddy works. Switching targets is, in my opinion, a waste of time. You never need to target anyone to cast a spell on them.

      2. If you go negative you could potentially miss a spell cast. You already have a variation of max 500ms + your set ms + your lag. This should prevent it from looking bottish.

      You target a "WoWUnit". Target switching just targets the character before casting. I don't actually use the name or the guid. I use the WoWUnit Class.
       
    2. shm0

      shm0 New Member

      Joined:
      Nov 6, 2012
      Messages:
      104
      Likes Received:
      0
      Trophy Points:
      0
      1. I get it. but if you are in a raid. Having people having you on focus. They see you never switch the target but suddenly an interrupt goes off.. looks quite.. strange
      2. I mentioned to add some checks, so it doesnt miss or instant interrupt.

      Sorry im not that deep in developing.
      But could it be that there is a problem when there two or more targets around with the same name and casting?

      I looked at the wowunit class. You can either use the name property or the guid property.
      If you use the name property it maybe doesnt work as expected?
       
    3. Phelon

      Phelon Well-Known Member Buddy Store Developer

      Joined:
      Jan 15, 2010
      Messages:
      2,591
      Likes Received:
      140
      Trophy Points:
      63
      1. If someone says something, then tell them their ui is screwed up =)

      2. The only other option would be to let you set the randomization. I could put in the ability to let you select the randomization, but I don't see a net gain worth the development time. If you can give me a case where it would make sense, I do not mind considering it.

      The Unit is a WoWUnit Object. Every WoWUnit Object is Unique when it is created as it is a derivative of the Class. So you do not actually need to run it by GUID or Name since it is its own entity. We also do it by spell Entry so anything casting said spell entry will get interrupted.
       
      Last edited: Apr 5, 2015
    4. shm0

      shm0 New Member

      Joined:
      Nov 6, 2012
      Messages:
      104
      Likes Received:
      0
      Trophy Points:
      0
      Thanks for your explanation.
      I have found another excuse. Mouse over interrupt macro ;)

      I just want to figure out why it isn't interrupting other targets and sometimes missing interrupts.

      I saw in the in the changelog you removed the gcd check. Was it possible if my routine is too fast it could prevent the kick go off even if my interrupt spell is off gcd?

      So back to the hit box thing?
       
      Last edited: Apr 5, 2015
    5. Phelon

      Phelon Well-Known Member Buddy Store Developer

      Joined:
      Jan 15, 2010
      Messages:
      2,591
      Likes Received:
      140
      Trophy Points:
      63
      You hit the nail on the head and hitbox is coming tomorrow.

      *Added - Hitbox to Interrupt Range. It will now use what ever is larger as a range.
       
      Last edited: Apr 5, 2015
    6. shm0

      shm0 New Member

      Joined:
      Nov 6, 2012
      Messages:
      104
      Likes Received:
      0
      Trophy Points:
      0
      thanks for another update :D

      so it does work like this now?

      ActualRange - Hitboxsize = TrueRange

      If(TrueRange <= RangeSetForInterrupt)
      {
      Do some interrupting;
      }
       
    7. Phelon

      Phelon Well-Known Member Buddy Store Developer

      Joined:
      Jan 15, 2010
      Messages:
      2,591
      Likes Received:
      140
      Trophy Points:
      63
      Code:
              private static int GetBestRange(int range)
              {
                  var hitBox = Convert.ToInt32(Math.Max(5f, StyxWoW.Me.CombatReach + StyxWoW.Me.CurrentTarget.CombatReach) - 1);
                  return range > hitBox ? range : hitBox;
              }
      
       
      Last edited: Apr 6, 2015
    8. shm0

      shm0 New Member

      Joined:
      Nov 6, 2012
      Messages:
      104
      Likes Received:
      0
      Trophy Points:
      0
      Thanks for posting.

      I dont want to steal your time but it dont get this.
      This function will either return the range of the spell or the hitbox size ?

      If the hitbox is 10y and the range is 5. The range is 15 or?

      And the function returns 10.

      How can this work?

      //Edit
      Also tested the new version with gcd check removed. Missing interrupt issue is gone now it seems.
      I have the debug option checked. Should it print to log if an off target is detected casting?
      If Yes it doesnt. Maybe it simple doesnt detect it right?

      //Edit2
      There is bug in the gui.
      If UseInCombatOnly is true. The gui doesnt reflect that. The Checkbox keeps unmarking itself.
       
      Last edited: Apr 6, 2015
    9. Phelon

      Phelon Well-Known Member Buddy Store Developer

      Joined:
      Jan 15, 2010
      Messages:
      2,591
      Likes Received:
      140
      Trophy Points:
      63
      Thanks for the bug report! I have now fixed that.

      So what the function does is it will return which ever is higher between the hitbox check and your distance..

      So 5f (typical melee range) or your combat reach + what ever your fighting combat reach. It then checks to see which is bigger YOUR distance or the hitbox that was returned and returns that. So it will always check to see if the hitbox is bigger than your distance and will use that instead.
       
    10. shm0

      shm0 New Member

      Joined:
      Nov 6, 2012
      Messages:
      104
      Likes Received:
      0
      Trophy Points:
      0
      But then you still havent the real distance?

      I thought about something like that dunno if this works.

      //edit
      tested with some simple plugin.

      I used Heroic Throw (just for testing here) which has 30y range.
      I move close enough to have the mob in range for the throw.
      That is the output of the plugin:

      Target Hitbox Size 9
      My Hitbox Size 1.5
      Distance 40.1715431213379
      True Distance 29.6715431213379

      Seems somewhat right to me.

      //edit 2
      But in meele range i get this:
      Target Hitbox Size 1.5
      My Hitbox Size 1.5
      Distance 5.02197170257568
      True Distance 2.02197170257568

      //edit 3
      Here is an output with your code added.

      Im just standing close enough to let pummel work. Which should be 5y.
      The Mob has quite a big hitbox.

      Target Hitbox Size 9
      My Hitbox Size 1.5
      Distance 11.3758525848389
      True Distance 0.875852584838867
      Best Range 11

      As you can see your code reports 11y. If i had set pummel to 5 yards in the plugin settings. It wouldnt interrupt.
      But im standing close enough to let pummel work.

      But you can see my code is also off. But only for melee range. on larger range it works.


      Did you read the part with debug option checked and dont printing detected off casting mobs in log?
       
      Last edited: Apr 6, 2015
    11. MrLamp

      MrLamp New Member

      Joined:
      Mar 5, 2014
      Messages:
      142
      Likes Received:
      0
      Trophy Points:
      0
      Hi, would be nice if you could make a setting for interrupt order, like on the Oregorger fight there's usually 3 dps that need to interrupt in different orders, so if I'm one of those dps'es I should only interrupt the 2nd spell for example and skip the others. I haven't bought this yet but when this is supported(or might already be) I'm gonna, I'm sooo lazy :D I don't think it's that hard to implement, like one variable to count casts and then the ui only, depending on how all the other logic is implemented.
       
      Last edited: Apr 10, 2015
    12. Phelon

      Phelon Well-Known Member Buddy Store Developer

      Joined:
      Jan 15, 2010
      Messages:
      2,591
      Likes Received:
      140
      Trophy Points:
      63
      That would require reading the combat log etc. I don't think that will ever be supported to be completely honest. You would have to right in conditions specific to the mob and that is just a lot more work than I want to invest for such a small market.
       
    13. shm0

      shm0 New Member

      Joined:
      Nov 6, 2012
      Messages:
      104
      Likes Received:
      0
      Trophy Points:
      0
      Off target interrupting still not working for me.
       
    14. Phelon

      Phelon Well-Known Member Buddy Store Developer

      Joined:
      Jan 15, 2010
      Messages:
      2,591
      Likes Received:
      140
      Trophy Points:
      63
      Best way to test it is to duel some one, have them cast but do bot target them and see if it interrupts. Let me know what happens.
       
    15. shm0

      shm0 New Member

      Joined:
      Nov 6, 2012
      Messages:
      104
      Likes Received:
      0
      Trophy Points:
      0
      I will do this later.

      I test it usually in bf lfr. The First Trash Group. (2 Casters)
      They casted this two Spells. (Can also be 3. if they are standing long enough)
      Lavaburst ID: 175621
      Cauterize ID: 175620

      I have the feeling it isnt scanning the targets right.
      I tried not to target the casters and im clearly standing in interrupt range. (I can kick them with mouseover)
      Lavaburst is spammed by these mobs.
      However the log only shows these two lines.

      [Ultimate Interrupt - Debug] Adding Casted Spell: Lavaburst with ID: 175621 to Casting Players List!
      [Ultimate Interrupt - Debug] Adding Casted Spell: Lavaburst with ID: 175621 to Casting Players List!

      Cauterize doesnt even show up.
      But when i switch to the target the log gets spammed.


      [15:47:54.532 N] [Ultimate Interrupt - Info] Current Target is Casting: Lavaburst with ID: 175621 at Distance: 2.81924772262573 with Time Left 1936:
      [15:47:54.612 N] [Ultimate Interrupt - Info] Current Target is Casting: Lavaburst with ID: 175621 at Distance: 2.81924772262573 with Time Left 1857:
      [15:47:54.666 N] [Ultimate Interrupt - Info] Current Target is Casting: Lavaburst with ID: 175621 at Distance: 2.81924772262573 with Time Left 1802:
      [15:47:54.728 N] [Ultimate Interrupt - Info] Current Target is Casting: Lavaburst with ID: 175621 at Distance: 2.81924772262573 with Time Left 1741:
      [15:47:54.809 N] [Ultimate Interrupt - Info] Current Target is Casting: Lavaburst with ID: 175621 at Distance: 2.81924772262573 with Time Left 1660:
      [15:47:54.885 N] [Ultimate Interrupt - Info] Current Target is Casting: Lavaburst with ID: 175621 at Distance: 2.81924772262573 with Time Left 1584:
      [15:47:54.956 N] [Ultimate Interrupt - Info] Current Target is Casting: Lavaburst with ID: 175621 at Distance: 2.81924772262573 with Time Left 1513:
      [15:47:55.010 N] [Ultimate Interrupt - Info] Current Target is Casting: Lavaburst with ID: 175621 at Distance: 2.81924772262573 with Time Left 1459:
      [15:47:55.056 N] [Ultimate Interrupt - Info] Current Target is Casting: Lavaburst with ID: 175621 at Distance: 2.81924772262573 with Time Left 1413:
      [15:47:55.120 N] [Ultimate Interrupt - Info] Current Target is Casting: Lavaburst with ID: 175621 at Distance: 2.81924772262573 with Time Left 1348:
      [15:47:55.191 N] [Ultimate Interrupt - Info] Current Target is Casting: Lavaburst with ID: 175621 at Distance: 2.81924772262573 with Time Left 1277:
      [15:47:55.266 N] [Ultimate Interrupt - Info] Current Target is Casting: Lavaburst with ID: 175621 at Distance: 2.81924772262573 with Time Left 1203:
      [15:47:55.324 N] [Ultimate Interrupt - Info] Current Target is Casting: Lavaburst with ID: 175621 at Distance: 2.81924772262573 with Time Left 1145:
      [15:47:54.885 N] [Ultimate Interrupt - Info] Current Target is Casting: Lavaburst with ID: 175621 at Distance: 2.81924772262573 with Time Left 1584:

      And there is still a range issue.

      In the same room there a large mob with large hitbox. (I dont want to interrupt this just to show here the range check if off)
      Im as a normal user would enter my melee range interrupt spells in the gui as 5y.
      Im standing in Meele Range to this large mob. Now let see what the log says:

      [Ultimate Interrupt - Info] Current Target is Casting: Slag Breath with ID: 175752 at Distance: 7.34392595291138 with Time Left 1007:
      [15:49:05.116 N] [Ultimate Interrupt - Info] Current Target is Casting: Slag Breath with ID: 175752 at Distance: 7.34392595291138 with Time Left 924:
      [15:49:05.177 N] [Ultimate Interrupt - Info] Current Target is Casting: Slag Breath with ID: 175752 at Distance: 7.34392595291138 with Time Left 863:
      [15:49:05.252 N] [FUP] Casting Rache on Ogronschlepper (Spell ID: 6572)
      [15:49:05.252 N] [Ultimate Interrupt - Info] Current Target is Casting: Slag Breath with ID: 175752 at Distance: 7.34392595291138 with Time Left 788:
      ...
      ...
      [15:49:05.950 N] [Ultimate Interrupt - Info] Current Target is Casting: Slag Breath with ID: 175752 at Distance: 7.34392595291138 with Time Left 90:
      [15:49:06.005 N] [Ultimate Interrupt - Info] Current Target is Casting: Slag Breath with ID: 175752 at Distance: 7.34392595291138 with Time Left 35:
      [15:49:06.667 N] [FUP] Casting Verwüsten on Ogronschlepper (Spell ID: 20243)
      [15:49:07.680 N] [Ultimate Interrupt - Info] Current Target is Casting: Ground Stomp with ID: 175762 at Distance: 7.34392595291138 with Time Left 950:
      [15:49:07.768 N] [Ultimate Interrupt - Info] Current Target is Casting: Ground Stomp with ID: 175762 at Distance: 7.34392595291138 with Time Left 862:
      ...
      ..
      [15:49:07.894 N] [Ultimate Interrupt - Info] Current Target is Casting: Ground Stomp with ID: 175762 at Distance: 7.34392595291138 with Time Left 736:
      [15:49:07.963 N] [Ultimate Interrupt - Info] Current Target is Casting: Ground Stomp with ID: 175762 at Distance: 7.34392595291138 with Time Left 667:
      [15:49:08.045 N] [FUP] Casting Schildschlag on Ogronschlepper (Spell ID: 23922)
      [15:49:08.046 N] [Ultimate Interrupt - Info] Current Target is Casting: Ground Stomp with ID: 175762 at Distance: 7.34392595291138 with Time Left 584:
      [15:49:08.129 N] [Ultimate Interrupt - Info] Current Target is Casting: Ground Stomp with ID: 175762 at Distance: 7.34392595291138 with Time Left 501:
      [15:49:08.195 N] [Ultimate Interrupt - Info] Current Target is Casting: Ground Stomp with ID: 175762 at Distance: 7.34392595291138 with Time Left 435:

      As you can see here my combat routine is using melee range spells on the mob.
      Your Plugin Reports > 7y distance.
      If i wanted to interrupt this mob. The interrupt wouldnt work if i enter 5y as range for my interrupt spell.
       
    16. Phelon

      Phelon Well-Known Member Buddy Store Developer

      Joined:
      Jan 15, 2010
      Messages:
      2,591
      Likes Received:
      140
      Trophy Points:
      63
      I will take a look at it later tonight and see what I can come up with. I guess I will queue for LFR also. Can you give me your spells for PvE so i can test it?
       
    17. shm0

      shm0 New Member

      Joined:
      Nov 6, 2012
      Messages:
      104
      Likes Received:
      0
      Trophy Points:
      0
      Here is my current spell list:
      Spammy spells are not included or are commented out.

       
    18. katoshyloh

      katoshyloh New Member

      Joined:
      Dec 19, 2013
      Messages:
      24
      Likes Received:
      0
      Trophy Points:
      1
      Off interrupting in PvP is not working. It will only kick if you are targeting them. I bought this a month or so ago and it worked fine. Ever since the updated version it hasn't been kicking anything it's not targeting. I have all the correct settings checked. Anyone else have this problem have a fix?
       
    19. Phelon

      Phelon Well-Known Member Buddy Store Developer

      Joined:
      Jan 15, 2010
      Messages:
      2,591
      Likes Received:
      140
      Trophy Points:
      63
      It might have to do with Range Checks. I am going to look into it tonight or tomorrow and fix it. It was working til I put in a hitbox check. I am also going to test it in Looking For Retards (LFR) /shudder. Expect it what ever might be broken to be fixed by monday.
       
    20. katoshyloh

      katoshyloh New Member

      Joined:
      Dec 19, 2013
      Messages:
      24
      Likes Received:
      0
      Trophy Points:
      1
      Now that you mention it did interrupt an off target a couple times when i was right next to them. I'm on a hunter btw.
       

    Share This Page