[Order Bot] Fishing (Leveling 1-60)

Hello, I was wondering if it would be possible to abuse the Numpad keys to also sell to vendor. Currently it takes a numpad6 to go through the items and a numpad0 to actually sell it. (numpad 7 and 9 should cycle through the bags).

 

It's an interesting question, but someone like ExMatt (who made the Fish tag) could better answer that question. Feel free to PM him!

 

Luckily it was solved by the new added CommonTasks.SellItem, so I am now using this:

Code:

		foreach(ff14bot.Managers.BagSlot slot in ff14bot.Managers.InventoryManager.FilledSlots)
		{
			await CommonTasks.SellItem(slot,1000);
			await Buddy.Coroutines.Coroutine.Sleep(1000);
		}

But perhaps a small request. Everytime I start the profile it goes to the vendor and buys a fixed amount of bait regardless of the ones I already have. Could you add a check something like this?

Code:

<If Condition="not HasAtLeast(12705,198)">
  <LogMessage Message="You need more Purse Web Spiders!" />
   (...)
   <NoCombatMoveTo Name="Peddler of Wonders" XYZ="-650.1717, -123.7525, 524.3762" />
   <While Condition="not HasAtLeast(12705,190))">
	<BuyItem ItemId="12705" ItemCount="10" DialogOption="1" InteractDistance="3.0" NpcId="1011947" XYZ="-650.1717, -123.7525, 524.3762" />
    </while>
</If>

 

this is what I normally use

Code:

		<!-- PURCHASE Sand Leech (2600) -->
			<If Condition="not HasAtLeast(2600,297)">
				<If Condition="not IsOnMap(146)">
					<TeleportTo Name="Forgotten Springs" AetheryteId="20" />
				</If>
				<MoveTo NpcId="1004430" XYZ="-278.8812, 8.125506, 381.6631" />
				<While Condition="not HasAtLeast(2600,495)">
					<BuyItem ItemIds="2600" ItemCounts="99" DialogOption="1" InteractDistance="1.0" NpcId="1004430" XYZ="-278.8812, 8.125506, 381.6631" />
				</While>
			</If>

about the selling...

try adding

Code:

InventoryManager.FilledSlots.Where(i => i.Item.RepairClass == 15) // 15 is culinarian.... IDK why they can repair fish...but its probably used for desynth purposes.

EDIT: That may or may not sell Crowned pies too.... but Its better than just auto selling everything in your inventory (in case you forget to empty it).

 

Thanks Exmatt for this hint. But the sell issue was more concerning my BTN/MIN Leveling Profile and those gathered items are not important, the bagspace is. But if you may have a code that skips HQ items, I would be very thankful.

 

Here.

Code:

InventoryManager.FilledSlots.Where(bs => !bs.IsHighQuality)

 

Thanks a million!

 

nvm fixed the problem

 

Did Pipira profile stop working for someone else?

[11:35:16.865 D] System.Exception: Element Fish is not supported. Please check your XML and try again. (<Fish Mooch="0" ConfirmKey="Numpad0" MoveCursorRightKey="Numpad6" Bait="Goblin Jig" MinFish="15" MaxFish="25" ShuffleFishSpots="True" Condition="IsTimeBetween(0,8)">
<FishSpots>
<FishSpot XYZ="501.1315, -46.66195, -94.61865" Heading="4.758571" Sit="True" />
<FishSpot XYZ="500.7798, -47.33237, -122.4505" Heading="3.925002" Sit="True" />
<FishSpot XYZ="508.6219, -44.2114, -150.5673" Heading="5.462289" Sit="True" />
<FishSpot XYZ="480.5136, -45.42776, -184.97" Heading="2.695596" Sit="True" />
</FishSpots>
</Fish>) Line 107
en Clio.XmlEngine.PropertyProcessor.
(PropertyInfo , XElement , Object )
en Clio.XmlEngine.XmlEngine.Load(Object obj, XElement element)
en Clio.XmlEngine.PropertyProcessor.
(PropertyInfo , XElement , Object )
en Clio.XmlEngine.XmlEngine.Load(Object obj, XElement element)
en Clio.XmlEngine.PropertyProcessor.
(PropertyInfo , XElement , Object )
en Clio.XmlEngine.XmlEngine.Load(Object obj, XElement element)
en Clio.XmlEngine.PropertyProcessor.
(PropertyInfo , XElement , Object )
en Clio.XmlEngine.XmlEngine.Load(Object obj, XElement element)
en Clio.XmlEngine.PropertyProcessor.
(XElement , Type )
en Clio.XmlEngine.PropertyProcessor.
.
(XElement )
en System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()
en System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
en System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
en Clio.XmlEngine.PropertyProcessor.
(XElement , PropertyInfo )
en Clio.XmlEngine.PropertyProcessor.
(PropertyInfo , XElement , Object )
en Clio.XmlEngine.XmlEngine.Load(Object obj, XElement element)
en ff14bot.NeoProfiles.NeoProfile.Load(XElement element, String path)
en ff14bot.NeoProfiles.NeoProfile.Load(String path)
en ff14bot.NeoProfiles.NeoProfileManager.Load(String profilePath, Boolean rememberPath)

 

Although this profile isn't found in this topic, what I can say is that if you haven't touched the Fish folder in a while, I would snag the entire ExBuddy folder from ExMatt's SVN and remove the old Fish folder. He's been doing tons of changes lately and it may have caused only having the Fish folder to not be enough. While I can't confirm/deny this is in fact what's happening in your case, that would be my suggestion.

Full SVN folder: [noparse]https://github.com/MGramolini/ExBuddy/trunk/OrderBotTags/[/noparse] (use this in the SVN Checkout... pop-up)

I'll update the first post tonight with this suggested change as well.

 

Use https://github.com/MGramolini/ExBuddy/trunk/ExBuddy .

 

^ This. I replied from work and couldn't access the SVN to post the exact commit URL. Thanks, ExMatt!

 

Is there a way to enable the use of the Commercial Survival Manual?

 

It can be done, but it would likely need to be done with a plugin as I don't have the time to hard-code it into the profile atm.

 

I'm also having a minor issue with the profile. My character will buy two stacks of bait, but only use one stack, then go back and buy another two stacks.

 

I have it set to a minimum of two stacks and will buy two stacks if you're under two stacks. From my experience a while back, it would use between 1 and 2 during a 24-hour Eorzean Time period, so you would end up with an additional stack at times; better than having none or an extra 400, no?

 

Hey y2krazy, thanks for all the hard work, but I am having a huge issue with the profile.

Once I load up any of the fishing profiles, and my character teleports to the correct area, the bot goes into an infinite loops and keeps spamming this:
[18:07:03.846 N] cloud not Find a valid Path
[18:07:03.846 D] Exception during scheduling Pulse: System.NullReferenceException: Object reference not set to an instance of an object.
at ff14bot.NeoProfiles.pathing.GetPath() in e:\Downloads\RB\Profiles\Y2krazy\Quest Behaviors\Travel.cs:line 581
at ff14bot.NeoProfiles.TravelTag.OnStart() in e:\Downloads\RB\Profiles\Y2krazy\Quest Behaviors\Travel.cs:line 230
at ff14bot.NeoProfiles.ProfileBehavior.Start()
at ..
()
at ff14bot.NeoProfiles.NeoProfileManager.UpdateCurrentProfileBehavior()
at ff14bot.BotBases.OrderBot.(Object , EventArgs )
at ff14bot.Behavior.BrainBehavior.
()

Any suggestions on how I can fix it?

 

You are likely going to have to be more specfiic... what profile, and include more of the log to show the line the profile was at before the error occurred.

 

Travel.cs is being worked on by dark wolf every now and then, so if you have the latest version from SVN, please let me know if that's the one not working for you atm.

 

Here's a full log. The profile being used is "[O] [FSH] Pipira Pira & Three-Lip Carp - The Dravanian Forelands.xml", but it also happens in "[O] [FSH] Leveling 50-60.xml". Also, I have no plugins enabled.
The problem occurs when the profile teleports into a new zone. I do have your latest code and profiles y2krazy, as of 1 minute ago. The problem still persists. Basically, it appears that object "wayhome" is null at line 232 for Travel.cs. Even me putting a null checker on there doesn't help.

View attachment 5780 2015-09-27 14.14.txt