Default Combat Test Edition

Tiniq, some of your log denotes debuff errors. Do you get the same from the regular default combat?

Please note to all, if you post logs please edit out tank selection. We don't want to ever identify any player etc so it can be identified back to you.

so
at DefaultCombat.Helpers.Extensions.NeedsCleanse(TorCharacter p) in c:\Users\bobtser\Desktop\BW\Routines\Default\Helpers\Extensions.cs:line 191
is debuff errors. if (d.Stacks == 0 && p.HasDebuff(d.Name))


same with
at DefaultCombat.Core.Targeting.<get_ScanTargets>b__0(Object param0) in c:\Users\bobtser\Desktop\BW\Routines\Default\Core\Targeting.cs:line 152

possibly a debuff issue, not sure if it is from rewrite or not. Debuff on my build is still somewhat questionable. Could you run stock defaultcombat through a similar test and post a log?

 

Testing now and will post result on this post

View attachment BuddyWing 3104 2016-04-03-07.26.45.txt

The same problem, I picked myself as tank and it wont stop casting healing on me. Even if others are low. Maybe I should have tested longer for beter log file
ill test again

 

Did a tactical with 3 dps. Didnt set any of them as tank, the bot rotate between 3 targets ignoring the first of the list and overhealing another even out of combat

edit: i had to pause the bot sometimes to mannually heal so that the fp could go on

 

So with your class, tank should have a non stop static barrier, and in combat non stop resurgence from the combat routine, Was this different than the routine?

 

yes that's correct and the routines comes like that standard

And what cass said is what happens to me too.

Revision 14 is what worked on healing except the buffs spells to tank and aoe heal (never got to try the the later revision) only rev 22.

 

Ok according to logs you had quite a few debuff issues as well as buffs. I would be interested to know if you get similar errors with stock DefaultCombat or only with my rewrite. Pretty sure mu debuff may be borked but could you check with regular default combat before I burn a lot of hours on the wrong direction?

 

The real question though is do we get the same error/etc with standard defaultcombat? I need to identify what's different functionality in my version vs default in order to make sure we fix it in total vs one location.

 

Doing a test now on defaultcombat

 

Here a normal standard defaultcombat log. 3 dps and 1 healer and I didn't choose a tank.

View attachment BuddyWing 6724 2016-04-03-07.50.00.txt


I had to pause a few times too cause it kept healing just 1 target even out of combat.

 

What spell was cast over and over even out of combat? I want to see what the routine has for that.

 

With it locking on one person it tells me the health checks in the bot may be off again. Please try with buddywing 898 and don't let it update but use this current DefaultCombat.

 

wired, there was a revision that did the heals on background? like mouseover? i remember testing and the bot send heals to the companion whitout selecting him, so i kept my current target, something like self or focus modifier

 

Cass, Try commenting out the tank selection. Pretty sure it comes from there but not sure how to change it. Also try the older buddywing, I think changes fixed the break to rest may have re-broke some of the healing.

 

this is working quite well its even casting the buffs and spells on the tank

I used buddywing 898 with the latest revision of test edition and it worked. The only thing I didn't see is the aoe heal

 

Yeah that's what I thought, I'll let Aevitas know. See if you can get Aoe heals/dispels tested if possible. Those are the last 2 parts I am trying to iron out before we should be able to ship the changes.

 

Ill do a whole dungeon to see if aoe heals goes off and a dispell. I just don't know the condition for aoe heal, Is it 2 targets below a certain % or is it 3? is it only certain spells that's listed in the dispel condition? Cuase the dungeon I do might not even need a dispel.

 

Aoe heal count is 2 below a set percentage, which is 85% I haven't changed anything there. Dispel is from the debuff list under extensions.cs which only has.

Code:

        public static Debuff[] DebuffList =
		{
			new Debuff("Crushing Affliction (Force)", 0),
			new Debuff("Crushing Affliction (All)", 0),
			new Debuff("Corrosive Slime", 0),
			new Debuff("Laser", 4)
		};

routine itself may not be right and debuff would need to be in that list. Name thens tacks. Not sure what Force and All are for though.

 

Yeah so the dispel probably does work but havnt come across those spells to dispel yet. Iam gonna add one to that dispel list and see if that works.
As far as aoe heal where can I change that 85%? As far as my testing im sure 2 or more people was below 85% but I want to make sure so I w ant to put that value higher.

 

Global.cs health high, this is the same setting for both Aoe and single target when using Health.High as the health percentage needed to cast. Also check if the Aoe section of the routine has the spell at a lower threshold as well.

They also have to be fairly close as well, aoe checks distance between etc.

 

Cass I did re-arrange the tank selection code and put it all together. So a hard set f12 tank is highest check and will be priority.