• Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • [Plugin] CombatHelper - Targeting, pulling, RaF and stability fixes

    Discussion in 'Archives' started by lofi, Dec 30, 2010.

    1. panYama

      panYama Community Developer

      Joined:
      Jan 15, 2010
      Messages:
      2,629
      Likes Received:
      49
      Trophy Points:
      0
      does it attack when it's in the air? like 4 yards above ground and it's getting attacked?
       
    2. lofi

      lofi New Member

      Joined:
      Jul 12, 2010
      Messages:
      203
      Likes Received:
      15
      Trophy Points:
      0
      No, it will not do anything while flying, although I could add a check for that if it's a problem.

      Code:
      if (!Me.IsAlive || Me.IsFlying || Me.IsCasting
          || (Me.Mounted && !Battlegrounds.IsInsideBattleground))
      {
          return; // don't interrupt bot in these conditions
      }
       
      rrrix likes this.
    3. Stiopare

      Stiopare New Member

      Joined:
      Nov 20, 2010
      Messages:
      58
      Likes Received:
      0
      Trophy Points:
      0
      You are one of the people that make the bot even worth.

      Thanks!
       
    4. panYama

      panYama Community Developer

      Joined:
      Jan 15, 2010
      Messages:
      2,629
      Likes Received:
      49
      Trophy Points:
      0
      can you input this to the bot?

      basically sometimes AB is doing nothing because of the character being attacked. if its just 4 yards down why not jump down kill it and continue what it needs to do;)
       
    5. lofi

      lofi New Member

      Joined:
      Jul 12, 2010
      Messages:
      203
      Likes Received:
      15
      Trophy Points:
      0
      Not exactly, the code was just showing where it disabled plugin for flying.

      I moved the flight / mount check to after the assist check. The assist check picks up NPCs targeting you, your pet, or party/raid members. This should hopefully fix the issue you are having. See main post for latest version.
       
    6. Xanathos

      Xanathos Active Member

      Joined:
      Jul 25, 2010
      Messages:
      1,030
      Likes Received:
      6
      Trophy Points:
      38
      That's a great way to handle that. Thank you. =)
       
    7. awqawq

      awqawq Member

      Joined:
      Jun 9, 2010
      Messages:
      138
      Likes Received:
      0
      Trophy Points:
      16
      Would it be hard to make it roll on loot based on who autoequip needs the item the most in the group.
      Or just support to automatically press greed.

      This ia very annoying issue with RAF atm. Both characters just stand there and wait out the roll timer.
       
    8. tjwow2011

      tjwow2011 Member

      Joined:
      Jan 25, 2011
      Messages:
      222
      Likes Received:
      0
      Trophy Points:
      16
      Set to not pull targets that are greater than 3 levels below current char level, but CS is still pulling anything and everything in range. Disabled CS to check to see if it was the CC and nothing was targeted more than 3 levels below current char level.
       
    9. zeldrak

      zeldrak Well-Known Member

      Joined:
      Oct 25, 2010
      Messages:
      3,516
      Likes Received:
      25
      Trophy Points:
      48
      After re-reading the first post, I gather that this doesn't work with MrAutoFight? I'm only asking because I tried it with that plug-in and it seemed to keep targeting, then clearning target, then targeting again causing the bot to just stand there as if I were tabbing through targets.

      I'm sorry to ask this because it sounds really stupid, but can you tell me exactly how to use this and get it set up? I'll list my other plug-ins so you can tell me what to disable.

      Plug-ins: (The ones with an X beside them I have loaded/enabled, the others are just in the directory and showing as disabled/unloaded in HB)
      Allrounder
      X Apoc Refreshment
      BuddyCenter
      X Combat Helper
      CritterKiller
      X Cutpurse
      X Equip Shit
      FNav
      GB to HB Converter
      GBProfileLoader
      X HB Toggle
      X Loost Master
      X MountDetect
      X MrAutoFight
      X Ringo Profession Trainer
      X Killakaz's Profile Updater
      Set The Leader
      SimpleFollow
      Talented
      X TidyBags 3
      ZNFK
       
    10. lofi

      lofi New Member

      Joined:
      Jul 12, 2010
      Messages:
      203
      Likes Received:
      15
      Trophy Points:
      0
      You can use an addon called PassLoot.

      With the bot stopped, target nearby units and click "Unit Check" button with CombatHelper selected. It should either say "Target is OK" or give a reason why it is a good/bad target. Also, make sure to save and recompile plugins after making changes.

      I haven't tested with MrAutoFight. You can comment out the part of the code that clears target (search for "ClearTarget"). Also, could try with the FilterOnly option set to true.
       
    11. awqawq

      awqawq Member

      Joined:
      Jun 9, 2010
      Messages:
      138
      Likes Received:
      0
      Trophy Points:
      16
      Thanks.

      Is there any way to force the rafed one to always follow the leader? Currently it sometimes, when you die for example the healers just moves to the leader when he pulls and not when the leader is running towards the mobs.

      It's rather annoying since the healer is barely there in time to heal up the leader
       
      Last edited: Jan 30, 2011
    12. lofi

      lofi New Member

      Joined:
      Jul 12, 2010
      Messages:
      203
      Likes Received:
      15
      Trophy Points:
      0
      Latest version includes major update for RaF (follows leader as well as assist), and option to re-start the bot every x minutes to fix some stability issues, as well as several new configurations.
       
    13. Xanathos

      Xanathos Active Member

      Joined:
      Jul 25, 2010
      Messages:
      1,030
      Likes Received:
      6
      Trophy Points:
      38
      This is quickly turning into a "must have" plug-in for me. Especially with some of the later options that you've enabled in it.

      I do have a question, can you explain what this variable structure means/does:

      Code:
      FollowDistance = UseAutoAttack() ? 15 : 25; // Distance before moving to leader (RaF only)
      That's the only one that I can't quite figure out off the top of my head.

      I can't wait to use this in a dungeon with the combat bot (with the movement disabled, of course).
       
    14. tjwow2011

      tjwow2011 Member

      Joined:
      Jan 25, 2011
      Messages:
      222
      Likes Received:
      0
      Trophy Points:
      16
      Downloaded latest update to CS, set the options in the config, enabled, started bot, testing now, seems to be working alot better than before, thanks for the update, will let ya know if there are any problems.
       
    15. lofi

      lofi New Member

      Joined:
      Jul 12, 2010
      Messages:
      203
      Likes Received:
      15
      Trophy Points:
      0
      That is called the conditional operator. In the example, the follow distance is set to 15 for melee and 25 for ranged.
       
    16. Xanathos

      Xanathos Active Member

      Joined:
      Jul 25, 2010
      Messages:
      1,030
      Likes Received:
      6
      Trophy Points:
      38
      Awesome. Thank you for the explanation.
       
    17. MrWizard516

      MrWizard516 Member

      Joined:
      Jan 18, 2011
      Messages:
      586
      Likes Received:
      5
      Trophy Points:
      18
      Thanks for the plugin seems to work very well the only issue i have come across is that sometimes it will target trapped mob on my hunter. Not sure if this is plugin related or CC related.
       
    18. lofi

      lofi New Member

      Joined:
      Jul 12, 2010
      Messages:
      203
      Likes Received:
      15
      Trophy Points:
      0
      If it says "[CombatHelper] Engaging ..." it is the plug-in pulling. You can disable "PullTargets" in the settings, but then it will no longer fix the stuck in combat bug (which may not be an issue depending on your profile). I will try include trap checking in the next release, for now it seems 3.2.1 is working well for most people.

      On another note, disable the bot re-start in configurations when running in Questing mode, as it will resume from the beginning :(.
       
    19. gylli251

      gylli251 New Member

      Joined:
      Jan 30, 2010
      Messages:
      262
      Likes Received:
      0
      Trophy Points:
      0
      Hey wow crashes everytime it restarts hb for some reason i just set the time to 10000min so its no np i guess for me
       
    20. LiquidAtoR

      LiquidAtoR Community Developer

      Joined:
      Jan 15, 2010
      Messages:
      1,430
      Likes Received:
      52
      Trophy Points:
      48
      Ok, I tried this and I have a few issues...

      1) This plugin does nothing for PvP (It still ignores other faction players, so I still get my ass kicked because HB ignores. They are still NOT in the targetlist (repFixed in the next release of HB)).
      2) This plugin overrides restlogic of the CC (and keeps pulling mobs in range which are NOT aggroed but are in combat with eachother) which results in death due to mana or hp issues.
      3) This plugin overrides lootlogic, and keeps pulling and not looting (which causes killed mobs to despawn, and I'm there for the loot in the first place, lol).
      4) This plugin is pulling mobs that are not mentioned in the profile, nor is their faction ID in the profile, and they are neutral (so they don't attack unless attacked).

      This is what I noticed so far in 30 minutes of use. I can live with the not PvPing part since the next release of HB should solve this, but the rest and looting logic override is a no no for me.
      I'm grinding in heavily populated regions with a high mob concentration and quick respawns. It might tick your plugin off a bit.

      Nice work on the plugin itself, and I'm sure it's usefull for many people.

      Regards, Liquid.
       
      Last edited: Feb 4, 2011

    Share This Page