• Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • HB ARCHIVES: Singular--DO NOT DELETE

    Discussion in 'Archives' started by bobby53, Nov 19, 2012.

    1. elpargo

      elpargo Member

      Joined:
      Oct 10, 2012
      Messages:
      164
      Likes Received:
      4
      Trophy Points:
      18
      Most were just fixes to things that were already there and not working properly... Like the range checks that were missing or spells/talents with old/wrong names, etc.
      Also added support for some talents that were missing from the routine.

      The only changes I made that could alter DPS came just from testing and common sense:

      Reduces Rage requirement for Dragon Roar>Battle Cry>Rampage combo from 100 to 85 (70 if Carnage is talented).
      Simply no sense in waiting for 100 rage to cast Rampage, the only thing we can spend rage on outside execute range, when we can cast it much earlier.
      And was also delaying Dragon's Roar and Battle Cry.

      Enables Bloodthirst and Raging Blow on targets below 20% health if Rage is low.
      I noticed the bot just auto-attacked during execute range waiting for rage to cast Execute... and that was it... we can increase DPS by casting rage generators if rage is low instead of just waiting.

      The only spec I actually focused on increasing DPS was Retri Paladin. And again that was just testing + common sense + some feedback. I usually use Icy Veins if I need to check something I'm not sure about.
      I honestly don't know how to write a routine from scratch but I'm having a blast investigating Singular and improving/fixing whatever I can. And learning in the process :D

      Noticed you are looking for testers for a DK routine. Thats why you ask?
       
      Last edited: Sep 27, 2016
    2. Dmpk

      Dmpk Member Legendary

      Joined:
      Jul 11, 2016
      Messages:
      280
      Likes Received:
      1
      Trophy Points:
      18
      What on earth happened to the resto druid... he is absolutely horrible... Doesn't heal at all unless you click to target then he heals a few times and stops again. Did a test and he did not even heal once from 100%-0%, not up to par with usual singular anything... and seriously bad lol. Wasted 130k gold on boe epics to gear a char and now it doesnt even work! Please fix <3
       

      Attached Files:

    3. moosegumps

      moosegumps New Member

      Joined:
      May 6, 2014
      Messages:
      27
      Likes Received:
      0
      Trophy Points:
      0
      What's the deal with Pull More being 'always disabled' for vengeance DH?

      I main VDH for farming and it's quite frustrating/confusing that I am only able to pull 1 mob at a time. What is the purpose of disallowing the Pull More feature for VDHs and how do I override it? These are my settings.

      It may also be worth noting that even with a different class, the Pull More feature doesn't work correctly when attacking neutral (yellow) mobs. Distinguishing between 'hostile' and 'all' targets under the 'Pull More Target Type' option makes no difference.
       
    4. Phenotype

      Phenotype Member

      Joined:
      Dec 19, 2010
      Messages:
      264
      Likes Received:
      3
      Trophy Points:
      18
      Dude, thanks for the updates!

      Should have your own thread to fix Singular problems so the devs can add it to the official Singular.
      They should have hired you :D
       
    5. Taylor123123

      Taylor123123 New Member

      Joined:
      Jan 17, 2010
      Messages:
      204
      Likes Received:
      0
      Trophy Points:
      0
      Combat rogue could really use the addition of Riposte/Cannonball Barrage/Blade Flurry vs 3+ targets
       
    6. darksavior

      darksavior New Member

      Joined:
      Aug 25, 2014
      Messages:
      21
      Likes Received:
      0
      Trophy Points:
      1
      Shaman - Restoration

      Can somebody help me with Chain Heal on restoration shamans?
      Toon is not casting it at all ( in logs it appears as (Singular) GetBestChainHealTarget: CanCastHack says NO to Chain Heal )
      View attachment Restoration.cs

      Where i should look to fix it? its something about buffs of Riptide or target behaivor?
      Target
      Code:
      public static WoWUnit GetBestChainHealTarget()
              {
                  if (!Me.IsInGroup())
                      return null;
      
                  if (!Spell.CanCastHack("Chain Heal", Me, skipWowCheck: true))
                  {
                      Logger.WriteDebug("GetBestChainHealTarget: CanCastHack says NO to Chain Heal");
                      return null;
                  }
      
                  // search players with Riptide first
                  var targetInfo = ChainHealRiptidePlayers
                      .Select(p => new { Unit = p, Count = Clusters.GetClusterCount(p, ChainHealPlayers, ClusterType.Chained, ChainHealHopDistance) })
                      .OrderByDescending(v => v.Count)
                      .ThenByDescending(v => Group.Tanks.Any(t => t.Guid == v.Unit.Guid))
                      .DefaultIfEmpty(null)
                      .FirstOrDefault();
      
                  WoWUnit target = targetInfo == null ? null : targetInfo.Unit;
                  int count = targetInfo == null ? 0 : targetInfo.Count;
      
                  // too few hops? then search any group member
                  if (count < ShamanSettings.RestoHealSettings.MinChainHealCount)
                  {
                      target = Clusters.GetBestUnitForCluster(ChainHealPlayers, ClusterType.Chained, ChainHealHopDistance);
                      if (target != null)
                      {
                          count = Clusters.GetClusterCount(target, ChainHealPlayers, ClusterType.Chained, ChainHealHopDistance);
                          if (count < ShamanSettings.RestoHealSettings.MinChainHealCount)
                              target = null;
                      }
                  }
      
                  if (target != null)
                      Logger.WriteDebug("Chain Heal Target:  found {0} with {1} nearby under {2}%", target.SafeName(), count, ShamanSettings.RestoHealSettings.ChainHeal);
      
                  return target;
              }
      Or just cast fails because of Riptide buff or something about cast wrong?
      Code:
      behavs.AddBehavior(HealerManager.HealthToPriority(ShamanSettings.RestoHealSettings.ChainHeal) + 100, "Chain Heal", "Chain Heal",
                      new Decorator(
                          ret => Me.Combat  && (StyxWoW.Me.GroupInfo.IsInParty || StyxWoW.Me.GroupInfo.IsInRaid),
                          new PrioritySelector(
                              ctx => GetBestChainHealTarget(),
                              new Decorator(
                                  ret => ret != null,
                                  new Sequence(
                                      new DecoratorContinue(
                                          req => ((WoWUnit)req).HasAuraExpired("Riptide", TimeSpan.FromMilliseconds(ChainHealCastTime), true),
                                          new Sequence(
                                              Spell.Cast("Riptide", on => (WoWUnit)on, req => true, cancel => false),
                                              new Wait(TimeSpan.FromMilliseconds(1500), until => !Spell.IsGlobalCooldown(LagTolerance.No), new ActionAlwaysSucceed()),
                                              new Action(r => TidalWaveRefresh())
                                              )
                                          ),
                                      new WaitContinue(TimeSpan.FromMilliseconds(1500), until => !Spell.IsGlobalCooldown(LagTolerance.No), new ActionAlwaysSucceed()),
                                      Spell.Cast("Chain Heal", on => (WoWUnit)on),
                                      new Action(r => TidalWaveRefresh())
                                      )
                                  )
                              )
                          )
                      );
       
    7. frantax

      frantax New Member

      Joined:
      Jul 29, 2016
      Messages:
      6
      Likes Received:
      0
      Trophy Points:
      1
      Thanks for fix:) Now it is working as I want and my death knights have death only in name and not in combat log:p
       
    8. Xegony42

      Xegony42 Member Legendary

      Joined:
      Dec 1, 2014
      Messages:
      41
      Likes Received:
      1
      Trophy Points:
      8
      Enhancement Shaman currently not using bloodlust when set to True. What are the conditions that need to be met to activate? Should do it just on cooldown?
       
    9. elpargo

      elpargo Member

      Joined:
      Oct 10, 2012
      Messages:
      164
      Likes Received:
      4
      Trophy Points:
      18
      Looks like Demon Hunter is not yet added to the PullMore list.
      This file should enable it for Vengeance if set to Always.
      View attachment SingularRoutine.Behaviors.cs

      Also adds Honorable Medallion usage in PvP for all classes.
       
    10. elpargo

      elpargo Member

      Joined:
      Oct 10, 2012
      Messages:
      164
      Likes Received:
      4
      Trophy Points:
      18
      Echo is really busy with the quest pack right now it seems but I put them in this thread for exactly that reason... He will check it sooner or later.
      Glad I could help, thanks for the rep ;)
       
    11. darksavior

      darksavior New Member

      Joined:
      Aug 25, 2014
      Messages:
      21
      Likes Received:
      0
      Trophy Points:
      1
      Pls can you help me with resto sham calibration?
      I wanna to fix chain heal and opportunity to do some dps in raids.
       
    12. Igorishere

      Igorishere New Member

      Joined:
      Sep 22, 2016
      Messages:
      1
      Likes Received:
      0
      Trophy Points:
      0
      BM Hunter doesn't cast Bestial Wrath on cooldown and use Multi-shot(for enabling pets AOE)
       
    13. fightcancer

      fightcancer New Member

      Joined:
      Jul 19, 2013
      Messages:
      334
      Likes Received:
      2
      Trophy Points:
      0
      Feral.cs still doesn't use AOE. I'm hoping that will be fixed soon. Until then, I have to use EchoTiger's version.
       
    14. descendbot

      descendbot New Member

      Joined:
      Jan 23, 2014
      Messages:
      1
      Likes Received:
      0
      Trophy Points:
      0
      Can anyone tell me how to edit the rogue Outlaw routine so it doesn't keep re-rolling Roll the Bones? Looks like the bot rerolls if there's only one buff active. I know that's the optimal dps rotation but it makes farming slower.
       
    15. skaidi

      skaidi New Member

      Joined:
      Apr 9, 2012
      Messages:
      8
      Likes Received:
      0
      Trophy Points:
      0
    16. elpargo

      elpargo Member

      Joined:
      Oct 10, 2012
      Messages:
      164
      Likes Received:
      4
      Trophy Points:
      18
      Adding this before the dps rotation starts seems to fix the problem:
      Movement.CreateFaceTargetBehavior(),

      If you don't know how to edit the files tell me wich class you want this for and I can add it and upload it here for you.
       
    17. elpargo

      elpargo Member

      Joined:
      Oct 10, 2012
      Messages:
      164
      Likes Received:
      4
      Trophy Points:
      18
      Lines 135 and 136.

      Spell.Cast("Roll the Bones", req => !Spell.CanCastHack("Adrenaline Rush") && RollTheBonesBuffs.Count(a => Me.HasActiveAura(a)) < 2),
      Spell.Cast("Roll the Bones", req => Spell.CanCastHack("Adrenaline Rush") && RollTheBonesBuffs.Count(a => Me.HasActiveAura(a)) < 3)

      "< 2" and "< 3" tells you when the bot will reroll. change this to < 1 if you want to reroll only if you have no buff.
       
    18. skaidi

      skaidi New Member

      Joined:
      Apr 9, 2012
      Messages:
      8
      Likes Received:
      0
      Trophy Points:
      0
      I dont know where to add myself, ARMS Warrior! Thanks
       
    19. Ikyata

      Ikyata New Member

      Joined:
      Jul 25, 2016
      Messages:
      42
      Likes Received:
      1
      Trophy Points:
      0
      I think there is an issue with Balance Druids. They just moonfire EVERYTHING and get murdered cus they can't handle more than 3 mobs or so at a time and pull everything in range.
       
    20. elpargo

      elpargo Member

      Joined:
      Oct 10, 2012
      Messages:
      164
      Likes Received:
      4
      Trophy Points:
      18
      Here you go, the 3 specs just in case.
      Put them in Honorbuddy\Routines\Singular\ClassSpecific\Warrior
       

      Attached Files:

    Share This Page