Singular - A community driven All-In-One CC - It Just Plain Works - (Pt. 2)

I just uploaded the fix for casting slam on bloodsurge procs only. I have spent some time looking into how to detect if the char has certain talents or not and have been unsuccessful. If anyone knows how to do that or can point me in the right direction I'd be happy to get that put in.

 

Its all in the CC. pulled the following from the Talentmanager. You maybe able to have a good look inside and see if you can do anything with that. Am so out of touch with the current CCs. (WTB single file CS again >.>)

Code:

if (myClass == WoWClass.Druid && tab == 2 && index == 11 && rank != 0)
                        {
                            isExtraSpec = true;
                        }

                        // Renewed Hope
                        if (myClass == WoWClass.Priest && tab == 1 && index == 8 && rank != 0)
                        {
                            isExtraSpec = true;
                        }

 

I was looking at that, It looks like what the cc uses to tell if your a tank or kitty and a dps disc or heal disc priest. The issue I come into is with the code above that in the talent manager (I'm petty code illiterate). I might be able to make the cc separate fury warriors with that talent into using a diff cc file like the feral tanks and kitty dps does, but that seems like a dirty way to get it done as the only thing different in the two cc's would be how it executes.

I am not the best when it comes to stuff like this though. Ideally I would be able to do something like

Code:

Spell.Cast("Execute", ret => TalentManager.HasTalent("Executioner")),

Directly in the fury cc, but I don't believe I am skilled enough to do it.

I'll keep trying different things, but for me its trial and error.

 

The code I pasted seems to create an extra spec if set talent is found, then calls into play another CC (IE in the combat you'll see a kitty CC and Bear CC) might be possible to add to that check to see if the talent is found in the fury tree, then call a Fury2 CC, which could just be a copy and pasted version of your current fury revision with the Execute code commented out (Currently what I do if am running PvP or using my PvP Spec to grind.

 

I could do that, but I'd probably get a slap on the wrist from Apoc or Raphus for committing unnecessary code. It doesn't seem like that is the best way to handle it and I'd imagine they would be able to implement something like this properly.

 

Not sure if it has been mentioned (I did read damn near the entire thread); does anyone know how to make a ret pali STOP using consecrate at all times, also, to allow the 'drink when mana reaches this level' function to... well, function?

 

The best thing about this cc is that you can get it to do almost anything you want with very little coding experience. Open up the ret pally .cs file and comment out ( // before the line with consecration on it) You can even Ctrl + F to find it. If you mess anything up, just delete that file and re update via SVN.

I haven't played with ret pally much but haven't noticed any issues with mana with ret.

 

Apoc,

Any easy way to edit the rotations in this cc since no one seems to be updating it. Shadow priest is pretty bad for starters. Doesn't seem to use Mind Blast correctly , yes I checked the settings, Archangel never triggers even with it set to 75% mana and Archangel on 5 set to true. I do 12k in my gear on a dummy manually and 8k with this. Just needs some tweaking.

 

Ele Shaman Doesn't work at all? I start attack using lazy raider bot.... Buff's Lighting shield and that is it?

fixed it on my end comment out this line

Code:

//Item.UseEquippedItem((uint)WoWInventorySlot.Hands),

I corrected the misspelling in Helpers and in the cc itself but this code still will not buff weapon.

Code:

Spell.Cast("Flametongue Weapon", ret => !Item.HasWeaponImbue(WoWInventorySlot.MainHand, "Flametongue"))

Any help

 

nvm

 

Not sure if this is even needed but here goes....

What Class are you?: Paladin
What Spec are you?: Protection
What 'context' is the bot in? (Instance, BG, Normal): Questing
What level are you?: 82
What revision of Singular are you using?: The one that came with the newest HB
Have you made any modifications to Singular?: No
What version of Honorbuddy are you using?: The newest one don't know if its been updated past 2.0.0.5198 (Thats supposed to auto-update iirc)

I changed the Eat/Drink to 0 so the bot will stop standing around doing nothing waiting for it to get mana back. However it doesn't seem to care what numbers I put in it won't do anything. I changed it to 0 at first and it still gives me the message - [Singular] We have no food/drink. Waiting to recover our health/mana back.

 

dunno what happened but singular v2 is such a fail.

[Singular] Target is invalid. Switching to Icewing Marshal!
[Singular] Casting Silencing Shot on Icewing Marshal
[Singular] Casting Hunter's Mark on Icewing Marshal
[Singular] Casting Serpent Sting on Icewing Marshal
[Singular] [Pet] Casting Attack
[Singular] Casting Hunter's Mark on Vanndar Stormpike
[Singular] [Pet] Casting Attack
[Singular] Casting Chimera Shot on Vanndar Stormpike
[Singular] Casting Hunter's Mark on Vanndar Stormpike​

 

Noticed that Druid (Balance) doesn't use MotW once learned (I've restarted the bot as well besides rebooting the whole system).
Singular rev. 360 (SVN)
There's no setting for MotW in the config screen, so I assume it's supposed to be detected automatically.

 

Please fix these problems.

 

MotW has not worked in Singular for a long time now, I use FPS's CC on my druids.

 

Hmm, then I will have a look myself into the code ^^
I'll let you know if it works (and what changes are needed).

Edit:
If I look at it really simple this should give you (and only you) the buff. (Druid > Common.cs)
This is not for group or raidbuffing. That would need a bit more.

Code:

using System.Linq;
using Singular.Dynamics;
using Singular.Helpers;
using Singular.Managers;
using Styx;
using Styx.Combat.CombatRoutine;
using Styx.WoWInternals.WoWObjects;
using TreeSharp;
namespace Singular.ClassSpecific.Druid
{
    public class Common
    {
        public static ShapeshiftForm WantedDruidForm { get; set; }
        [Class(WoWClass.Druid)]
        [Behavior(BehaviorType.PreCombatBuffs)]
        [Spec(TalentSpec.BalanceDruid)]
        [Spec(TalentSpec.FeralDruid)]
        [Spec(TalentSpec.FeralTankDruid)]
        [Spec(TalentSpec.RestorationDruid)]
        [Spec(TalentSpec.Lowbie)]
        [Context(WoWContext.All)]
 
        public static Composite CreateDruidBuffComposite()
        {
   return new PrioritySelector(
     Spell.BuffSelf("Mark of the Wild",
    ret => (!StyxWoW.Me.HasAura("Mark of the Wild") && !StyxWoW.Me.HasAura("Blessing of Kings")))
   );
        }
    }
}

I will try it myself as well to test it (didn't test, just changed code).

Edit2: Yups, works fine for me. This puts MotW on yourself if you don't have Blessing of Kings already (which overwrites eachother).

 

How hard would it be to add aquatic form to the Druid CC? There are a lot of water quests where it would be useful for the speed and water breathing, but currently it just remains in non-shifted form. Thanks.

 

I've tried adding getting my Demo Warlock to do Rain of Fire when there's more than one add at the target. However I can't seem to get it working as it's ignoring the spell. Any ideas what Im doing wrong?

new Decorator(
ret => SpellManager.CanCast("Rain of Fire") && Unit.NearbyUnfriendlyUnits.Count(a => a.Distance < 25) > 1,
new Action(
ret =>
{
SpellManager.Cast("Rain of Fire");
LegacySpellManager.ClickRemoteLocation(StyxWoW.Me.CurrentTarget.Location);
})),

 

Try this for size...

Code:

 
                new Decorator(
                    ret => Unit.NearbyUnfriendlyUnits.Count(a => a.Distance <= 25) > 1,
                    Spell.CastOnGround("Rain of Fire", ret => StyxWoW.Me.CurrentTarget.Location)
                    ),

And if this works we can apply it for Hurricane as well in the Balancedruid part ^^

 

Already tried that and it doesnt seem to work. It doesnt yell out any error, but it seems to just ignore the Rain of Fire cast..

Private Paste - Pastie - Log from pastie showing the decorator position