Shaddar, First of all i want to thank you for this awesome CC and all the work done by you. I'm a bit of a novice playing warrior so i'm gonna ask you a few questions, is it normal that when the boss is at less than 20% the bot spams execute ? Shouldn't the rotation be execute till 5 charges of executioner then on open gcd (normally used for slam) or when buff is nearly expiring ? Maybe i wasn't paying attention and the boss didn't last that much longer while at < 20% and i freaked out. Other thing, the conditional on Pummel isn't working. Since the bot tried to pummel a physical cast or something like that (a boss cast, like murazond's, you know what i mean ) Good work Shaddar P.S: Please don't think bad of me i'm just trying to help improving the CC.
Why would I think bad of you when you're providing me with great feedback and constructive criticism? I'm quite sure there are improvements to be made with the Execute Phase, well observed! I'll take a look at it when i get home. And yes, i agree the pummel code isnt quite successful, i need to rewrite the code. Thanks alot for the feedback!
Something I was going to start looking into for interrupts Shaddar is how I could make a DB that listed all the spells that matter for interrupts and have it only pummel on those spells. As for execute phase, yes. To theoretically min max your rotation you would Execute to 5 stacks then continue your normal rotation only using execute to keep stacks up or as a filler (in place of slam). I have been looking for a way to detect debuff stacks to use with Sunder Armor on Titan Shields and this could also be applied to Executioner.
Yeah, the stack issue is a small problem and shouldnt be a problem to implement. However listing spells for interrupts is preferably done for PVP, however its better to search for some other code for PvE as you cannot list every single interruptable spell to the list.
Right, I wouldn't want to list every spell that's possible to interrupt, only the ones that matter in raids and heroics.
Hmm, not sure. Every CC I have used so far seems to just try to interrupt anything that's being cast even if its not able to be interrupted, then when you need to be able to interrupt, its on CD. Seems like there would be some way to separate various spells easily.
One solution could be removing pummel completely from the rotation, since this is going to be used with LazyRaider i guess people can press the key to interrupt. I'm guessing if people had like a window where they could configure what Spell ID the CC would pummel or not, and some nifty stuff like that... i don't know if the time/reward of doing that is worth it. By the way Shaddar, is the CC waiting for 3 stacks of Lambs to the Slaughter to pop CDs? And is it using Bladestorm as a single-target DPS ability? Also... The ability to configure an hotkey to swap between single-target rotation and aoe rotation would be so badass... more control to the user over the CC. Not trying to diss your amazing AOE target detection.
As stated before i will not add a GUI option to the CC. But yes there is of course improvements to be made. I'm most likely not going to add anything regarding hotkeys either. Bladestorm is not in the Single Target rotation. Some people like to use Bladestorm, others dont. So thats a cooldown youll have to use on your own. And thanks to guys like you Jfvibe, something always comes up. So again i appreciate the feedback, and ill sort out an update tonight after ive updated Bowman/Pyromancer. Ill be trying to add execute stacks 5 -> normal rotation with slam replaced as execute for the filler. Ill also see what i can do about the CD's and Lambs to the Slaughter.
As I said before in the PM, I will do some excessive testing with V2.1 and suggest some changes later on. Unfortunately I'm quite busy today so it'll probaly be tomorrow late in the evening. Overall its an awesome job so far Shaddar, and this will be the best amrs cc out there for a long while! Ps; I assume you're still working on stancedancing?
Stance Dancing havent been my number one focus lately as i have to update all of my profiles to the new add detection code + debuff code. I've got alot of work ahead of me as ive promised to update and fix Pyromancer and Bowman. And silly me even said i could update this one today aswell! But yes, ill do my best to find time for stance dancing
Alrighty, focus on your primary's first. Maybe I can check stancedance using the macro. Will let you know.
I don't think stance dancing is worth it at the moment. And in a programmer's standpoint i think it's easy to program that. I'm gonna try to figure out how the CC is coded and make some suggestions code-wise. Like i said before it's an awesome CC and Shaddar did a great job.
Update is to be expected 11.01.2012 between 05am - 08am; 1+ GMT. Plans: Use cooldowns at bosses only New and improved execute phase Pummel change/removal Stance Dance if possible(dont get your hopes up to soon! not releasing a version with Stance Dance unless it works properly) Will also be looking for other solutions to improve the DPS. - Shaddar
Update It now uses cooldowns at bosses instead of at X.HP. Only exception is Deadly Calm. Improved execute phase. (new rotation). No pummel/Charge/leap change as of yet. Other small changes has been done aswell. Stance dance has been tested out, it works decent but because of the constant Overpower proc it becomes unstable and forgets to cast mortal strike. I will most likely not be looking into stance dancing again, unless some magic code appears. I would like everyone to say whether they want Pummel/Charge/Leap in the next update or not. As this is a lazyraider CC i understand if you want it removed, although its up to you guys. - Shaddar
if i may ask, dancing only requires you to be in zerker stance for slams and mortal strikes so how were you implementing it in your tests?
How you going love the work. I've been raiding with your CC a few times but just over the last few updates i've been noticing i'm getting a lot of "Ability not ready" and the like, which i don't remember getting before, so I've been running a few test (just on the dummies atm) and i've been noticing from the logs that mortal strike seam to be getting left behind and not getting cast when the log says it trying to, and the strange thing about this is that it seam to that the MS from the Execute Phase is trying to get cast aswell (I noticed this simply as the normal MS has no ! but the one in the Execute Phase does). I think this is accruing from a lack of opening and closing your IF statements, from my understanding, atm your cc is just pritty much trying to cast everything it can all at the same time, with out regard to all the work your've put in telling it when to cast what. so i've gone through the code here and added a few { and } to your code (i hope you don't mind) but i've already seen a huge leap in dps. As to your question about charge and leap I tbh have removed both from your CC simply as there are to many boss fight that an unwanted charge can leave you dead and looking kinda silly. That being said i really enjoyed that fact that your cc had charge and leap included while i was lvling and doing H's. so maybe there's a way to only use them on trash and the like not on boss fights, no idea if that's even possible or not just an idea. might just be safer to remove them. Thank you again for your amazing work and i hope this has been helpful. P.S sorry if i've made this hard to read just being big slab of text like it is, writings not my strong point.
I was making it berserker stance for all spells except overpower and rend actually and that never turned out well.
Yeah i was have a play around with that a stance dance like that, came up with the code below, gave me an increase in dps on some tests but did horrible on others, not sure why its unstable, but thought it might help. Code: if (PlayerHasBuff("Taste for Blood") && !Me.HasAura("Battle Stance")) { if (CastSpell("Battle Stance") == true) { Logging.Write(Color.Aqua, "## Battle Stance ##"); } } if (!PlayerHasBuff("Taste for Blood") && TargetHasDebuff("Rend") && !Me.HasAura("Berserker Stance")) { if (CastSpell("Berserker Stance") == true) { Logging.Write(Color.Aqua, "## Berserker Stance ##"); } }
