Singular - A community driven All-In-One CC - It Just Plain Works - (Pt. 2)

We're mainly just making sure we don't have the aura Prowl before we decide to MotW. If we are prowling, it won't buff at all. If we aren't prowling, it will buff according to the normal rules. Would probably be a good idea to add this to the default Singular file, as if we're stealthed in any way it is a terrible idea to pop out to buff. Should probably add a Shadowmeld check too.

It will still cast it in any form as long as you aren't in combat, but as soon as you're in combat or prowling it will refuse to MotW.

 

Can anyone please get some support in on this? Currently un useable in DS...

 

I did some work for the Destruction Warlocks and Singular
The changes are tested by me and it does well so far.
I'm still on improving some minor things, that does not fit my thoughts, but atm it is usable, and follows EJ Priority

 

I doubt you'll get too much help with the Shaman CC, unfortunately. ShamWoW is the go-to for Shamans. I would recommend trying it out (the latest, not the one included with HB) and posting any bugs to his thread.

 

I did, and it has a LOT of work to do as far as enhancement goes compared to this one. and the required material for him to even entertain your bug report is rediculous.

Its only a few slight changes to fix this, i just simply don't know how to do it...

 

does anyone work on Priest Holy atm?
Since my work at Destruction Warlock is already done within the next few hours (if i get some dungeon groups to test)

 

So, the CC works fine on the dummy but doesn't work on ONLY the last 4 bosses of DS?

I'll take a look at it. PM me so I can start looking over it and see what's going on. Unfortunately I don't have an Enhance set to test it out. I'm more concerned with it only doing it on the last 4 of DS, because they have been causing me headaches with every CC that uses positioning.

 

yea Blizz was so kind to not give the last 4 bosses no mapping of a game world which is how HB renders distance to the target I think. anyways GL to ya on the fix. I have no idea how to squash it.

 

I did some further work on the Frost DK CustomClass, has no AoE yet but I am going to work on that once I get the RuneCooldown time.

Code:

using System.Linq;
using Singular.Dynamics;
using Singular.Helpers;
using Singular.Managers;
using Singular.Settings;
using Styx;
using Styx.Combat.CombatRoutine;
using Styx.Logic.Combat;
using TreeSharp;
using Action = TreeSharp.Action;

namespace Singular.ClassSpecific.DeathKnight
{
    public class Frost
    {
        [Class(WoWClass.DeathKnight)]
        [Spec(TalentSpec.FrostDeathKnight)]
        [Behavior(BehaviorType.Combat)]
        [Context(WoWContext.All)]
        public static Composite CreateFrostDeathKnightCombat()
        {
            return new PrioritySelector(
                Safers.EnsureTarget(),
                Movement.CreateMoveToLosBehavior(),
                Movement.CreateFaceTargetBehavior(),
                Helpers.Common.CreateAutoAttack(true),
                Helpers.Common.CreateInterruptSpellCast(ret => StyxWoW.Me.CurrentTarget),

                Movement.CreateMoveBehindTargetBehavior(),

                Spell.BuffSelf("Pillar of Frost", ret => SingularSettings.Instance.DeathKnight.UsePillarOfFrost),
                Spell.Cast("Outbreak", ret => !StyxWoW.Me.CurrentTarget.ActiveAuras.ContainsKey("Frost Fever") || !StyxWoW.Me.CurrentTarget.ActiveAuras.ContainsKey("Blood Plague")),
                Spell.Cast("Howling Blast", ret => !StyxWoW.Me.CurrentTarget.ActiveAuras.ContainsKey("Frost Fever") && TalentManager.HasGlyph("Howling Blast")),
                Spell.Cast("Icy Touch", ret => !StyxWoW.Me.CurrentTarget.ActiveAuras.ContainsKey("Frost Fever") && (!TalentManager.HasGlyph("Howling Blast") || !SpellManager.HasSpell("Howling Blast"))),
                Spell.Cast("Plague Strike", ret => !StyxWoW.Me.CurrentTarget.ActiveAuras.ContainsKey("Blood Plague")),
                Spell.Cast("Obliterate", ret => StyxWoW.Me.DeathRuneCount >= 1 && StyxWoW.Me.FrostRuneCount >= 1 && StyxWoW.Me.UnholyRuneCount >= 1),
                Spell.Cast("Obliterate", ret => StyxWoW.Me.ActiveAuras.ContainsKey("Killing Machine")),
                Spell.Cast("Obliterate", ret => (StyxWoW.Me.DeathRuneCount == 2 && StyxWoW.Me.FrostRuneCount == 2) || 
                    (StyxWoW.Me.DeathRuneCount == 2 && StyxWoW.Me.UnholyRuneCount == 2) ||
                    (StyxWoW.Me.UnholyRuneCount == 2 && StyxWoW.Me.FrostRuneCount == 2)),
                Spell.Cast("Frost Strike", ret => StyxWoW.Me.CurrentRunicPower >= 110),
                Spell.Cast("Obliterate", ret => StyxWoW.Me.DeathRuneCount == 2 || StyxWoW.Me.UnholyRuneCount == 2 || StyxWoW.Me.FrostRuneCount == 2),
                Spell.Cast("Frost Strike", ret => StyxWoW.Me.CurrentRunicPower >= 100),
                Spell.Cast("Obliterate"),
                Spell.Cast("Frost Strike"),
                Spell.Cast("Howling Blast"),

                //TODO: Complete
                //Spell.Cast("Empower Rune Weapon", ret => StyxWoW.Me.DeathRuneCooldown + StyxWoW.Me.FrostRuneCooldown + StyxWoW.Me.UnholyRuneCooldown > 8)

                //We generate runic power with this so it should be on CD if nothing else to do
                Spell.Cast("Horn of Winter"),

                //Goblins
                Spell.Cast("Rocket Barrage"),
                
                Movement.CreateMoveToMeleeBehavior(true)
            );
        }
    }
}

 

I get this error using Obliv's holy.cs:

Code:

Could not compile CC from D:\Games\HB\CustomClasses\Singular!
File: Holy.cs Line: 226 Error: Singular.Settings.PaladinSettings bevat geen definitie voor PaladinCleanse en er is geen extensiemethode PaladinCleanse gevonden waarmee het eerste argument van het type Singular.Settings.PaladinSettings wordt geaccepteerd (mogelijk ontbreekt er een gebruiksinstructie of een assembly-verwijzing)

Any idea how i could fix this? Seems an error with PaladinCleanse

 

Fixed. Got rid of the option to cleanse and just made it very low priority.

 

Anyone else notice that on the Ultraxion Fight the DK singular doesn't cast Howling Blast? Maybe range problem or something?

 

Ultraxion is a stupid fight for his hit box =[ If you stand more than 1 of the squares back your tentacle doesn't attack =\

 

on Ultraxion and Madness for classes like DKs, ret paladins and Enhancement shaman this is a current issue, it will no cast key abilities such as howling blast, Judgement, Lightning bolt, Shocks or re-drop expired totems.. I have brought it to someones attention but the more eyes we can get on this the better..There is no fix other than editing code :/

 

I'm out of ideas on a fix for this. Until the devs figure out a fix, I'd use Ovale and DPS like normal on those bosses.

 

I added selective healing options.

-extra tab added to gui.
-A list of raid/party members in 1 datagridview and a list of blacklisted players in the other
-double click on player name in roster to move to blacklist
-double click on player name in blacklist to remove
-lists are maintained in gui
-DefaultRemoveTargetsFilter in HealerManager filters blacklisted players

ConfigurationForm.cs
ConfigurationForm.Designer.cs
HealerManager.cs
SelectiveHealName.cs

 

maybe one of the more advanced singular devs can help, i've a little issues atm
this is working

PHP:

                        Spell.CastOnGround("Shadowfury", ret => StyxWoW.Me.CurrentTarget.Location),
                        Spell.CastOnGround("Rain of Fire", ret => StyxWoW.Me.CurrentTarget.Location)


PHP:

                new Decorator(
                    ret => StyxWoW.Me.CurrentTarget.IsBoss(),
                    new PrioritySelector(
                        Spell.BuffSelf("Demon Soul"),
                        Spell.Buff("Curse of Elements", ret => !StyxWoW.Me.CurrentTarget.HasAura("Curse of Elements")),
                        new Decorator(
                            ret => SpellManager.CanCast("Summon Infernal"),
                            new Action(
                                ret =>
                                {
                                    SpellManager.Cast("Summon Infernal");
                                    LegacySpellManager.ClickRemoteLocation(StyxWoW.Me.CurrentTarget.Location);
                                }))

                        )


this is not working

PHP:

                new Decorator(
                    ret => StyxWoW.Me.CurrentTarget.IsBoss(),
                    new PrioritySelector(
                        Spell.BuffSelf("Demon Soul"),
                        Spell.Buff("Curse of Elements", ret => !StyxWoW.Me.CurrentTarget.HasAura("Curse of Elements")),
                        Spell.CastOnGround("Summon Infernal", ret => StyxWoW.Me.CurrentTarget.Location)
                        )


and i don't know why, because Spell.CastOnGround does the same like SpellManager.Cast + LegacySpellManager.ClickRemoteLocation
i know i can use solution one, but i want to use the singular api everywhere, and in two or three weeks, if someone looks at the code, noone knows why it is done with solution one instead of solution two because both do the same.

 

Did more work on the Frost DK:

Code:

using System.Linq;
using Singular.Dynamics;
using Singular.Helpers;
using Singular.Managers;
using Singular.Settings;
using Styx;
using Styx.Combat.CombatRoutine;
using Styx.Logic.Combat;
using TreeSharp;
using Action = TreeSharp.Action;
using Styx.WoWInternals;
using System;

namespace Singular.ClassSpecific.DeathKnight
{
    public class Frost
    {
        [Class(WoWClass.DeathKnight)]
        [Spec(TalentSpec.FrostDeathKnight)]
        [Behavior(BehaviorType.Combat)]
        [Context(WoWContext.All)]
        public static Composite CreateFrostDeathKnightCombat()
        {
            return new PrioritySelector(
                Safers.EnsureTarget(),
                Movement.CreateMoveToLosBehavior(),
                Movement.CreateFaceTargetBehavior(),
                Helpers.Common.CreateAutoAttack(true),
                Helpers.Common.CreateInterruptSpellCast(ret => StyxWoW.Me.CurrentTarget),

                Movement.CreateMoveBehindTargetBehavior(),

                new Decorator(ret => SingularSettings.Instance.DeathKnight.UseMasterFrostRotation,
                    new PrioritySelector(
                        Spell.BuffSelf("Pillar of Frost", ret => SingularSettings.Instance.DeathKnight.UsePillarOfFrost),
                        Spell.Cast("Blood Tap", ret => GetAllRuneCooldowns(1, 2) > 2), 
                        Spell.Cast("Outbreak", ret => !StyxWoW.Me.CurrentTarget.ActiveAuras.ContainsKey("Frost Fever") || !StyxWoW.Me.CurrentTarget.ActiveAuras.ContainsKey("Blood Plague")),
                        Spell.Cast("Howling Blast", ret => !StyxWoW.Me.CurrentTarget.ActiveAuras.ContainsKey("Frost Fever") && TalentManager.HasGlyph("Howling Blast")),
                        Spell.Cast("Icy Touch", ret => !StyxWoW.Me.CurrentTarget.ActiveAuras.ContainsKey("Frost Fever") && (!TalentManager.HasGlyph("Howling Blast") || !SpellManager.HasSpell("Howling Blast"))),
                        Spell.Cast("Plague Strike", ret => !StyxWoW.Me.CurrentTarget.ActiveAuras.ContainsKey("Blood Plague")),
                        Spell.Cast("Obliterate", ret => StyxWoW.Me.DeathRuneCount >= 1 && StyxWoW.Me.FrostRuneCount >= 1 && StyxWoW.Me.UnholyRuneCount >= 1),
                        Spell.Cast("Obliterate", ret => (StyxWoW.Me.DeathRuneCount == 2 && StyxWoW.Me.FrostRuneCount == 2) || 
                            (StyxWoW.Me.DeathRuneCount == 2 && StyxWoW.Me.UnholyRuneCount == 2) ||
                            (StyxWoW.Me.UnholyRuneCount == 2 && StyxWoW.Me.FrostRuneCount == 2)),
                        Spell.Cast("Obliterate", ret => StyxWoW.Me.DeathRuneCount == 2 || StyxWoW.Me.UnholyRuneCount == 2 || StyxWoW.Me.FrostRuneCount == 2),
                        Spell.Cast("Frost Strike", ret => StyxWoW.Me.CurrentRunicPower >= 110),
                        Spell.Cast("Howling Blast", ret => StyxWoW.Me.ActiveAuras.ContainsKey("Freezing Fog")),
                        Spell.Cast("Obliterate", ret => StyxWoW.Me.UnholyRuneCount == 2 || GetAllRuneCooldowns(5, 6) < 2),
                        Spell.Cast("Howling Blast", ret => StyxWoW.Me.CurrentRunicPower < 90),
                        Spell.Cast("Frost Strike", ret => StyxWoW.Me.CurrentRunicPower > 90),
                        Spell.Cast("Howling Blast", ret => StyxWoW.Me.CurrentRunicPower < 60),
                        Spell.Cast("Frost Strike"),

                        Spell.Cast("Empower Rune Weapon", ret => GetAllRuneCooldowns(1, 2) + GetAllRuneCooldowns(3, 4) + GetAllRuneCooldowns(5, 6) > 8),

                        Spell.Cast("Horn of Winter"),

                        //Goblins
                        Spell.Cast("Rocket Barrage")
                    )
                ),

                new Decorator(ret => !SingularSettings.Instance.DeathKnight.UseMasterFrostRotation,
                    new PrioritySelector(
                        Spell.BuffSelf("Pillar of Frost", ret => SingularSettings.Instance.DeathKnight.UsePillarOfFrost),
                        Spell.Cast("Blood Tap", ret => GetAllRuneCooldowns(1, 2) > 2), 
                        Spell.Cast("Outbreak", ret => !StyxWoW.Me.CurrentTarget.ActiveAuras.ContainsKey("Frost Fever") || !StyxWoW.Me.CurrentTarget.ActiveAuras.ContainsKey("Blood Plague")),
                        Spell.Cast("Howling Blast", ret => !StyxWoW.Me.CurrentTarget.ActiveAuras.ContainsKey("Frost Fever") && TalentManager.HasGlyph("Howling Blast")),
                        Spell.Cast("Icy Touch", ret => !StyxWoW.Me.CurrentTarget.ActiveAuras.ContainsKey("Frost Fever") && (!TalentManager.HasGlyph("Howling Blast") || !SpellManager.HasSpell("Howling Blast"))),
                        Spell.Cast("Plague Strike", ret => !StyxWoW.Me.CurrentTarget.ActiveAuras.ContainsKey("Blood Plague")),
                        Spell.Cast("Obliterate", ret => StyxWoW.Me.DeathRuneCount >= 1 && StyxWoW.Me.FrostRuneCount >= 1 && StyxWoW.Me.UnholyRuneCount >= 1),
                        Spell.Cast("Obliterate", ret => StyxWoW.Me.ActiveAuras.ContainsKey("Killing Machine")),
                        Spell.Cast("Obliterate", ret => (StyxWoW.Me.DeathRuneCount == 2 && StyxWoW.Me.FrostRuneCount == 2) || 
                            (StyxWoW.Me.DeathRuneCount == 2 && StyxWoW.Me.UnholyRuneCount == 2) ||
                            (StyxWoW.Me.UnholyRuneCount == 2 && StyxWoW.Me.FrostRuneCount == 2)),
                        Spell.Cast("Frost Strike", ret => StyxWoW.Me.CurrentRunicPower >= 110),
                        Spell.Cast("Obliterate", ret => StyxWoW.Me.DeathRuneCount == 2 || StyxWoW.Me.UnholyRuneCount == 2 || StyxWoW.Me.FrostRuneCount == 2),
                        Spell.Cast("Frost Strike", ret => StyxWoW.Me.CurrentRunicPower >= 100),
                        Spell.Cast("Howling Blast", ret => StyxWoW.Me.ActiveAuras.ContainsKey("Freezing Fog")),
                        Spell.Cast("Obliterate"),
                        Spell.Cast("Frost Strike"),
                        Spell.Cast("Howling Blast"),

                        Spell.Cast("Empower Rune Weapon", ret => GetAllRuneCooldowns(1, 2) + GetAllRuneCooldowns(3, 4) + GetAllRuneCooldowns(5, 6) > 8),

                        Spell.Cast("Horn of Winter"),

                        //Goblins
                        Spell.Cast("Rocket Barrage")
                    )
                ),
                
                Movement.CreateMoveToMeleeBehavior(true)
            );
        }

        public static int GetAllRuneCooldowns(params int[] runes)
        {
            int cooldown = 0;
            foreach (int rune in runes)
            {
                cooldown += GetRuneCooldown(rune);
            }
            return cooldown;
        }

        public static int GetRuneCooldown(int rune)
        {
            float finish = Lua.GetReturnVal<float>(string.Format("local start, dur, ready = GetRuneCooldown({0}); local finish = start + dur; return finish", rune), 0);
            float time_now = Lua.GetReturnVal<float>("return GetTime()", 0);
            return (int) Math.Round(finish - time_now);
        }
    }
}

Code:

#region Revision Info

// This file is part of Singular - A community driven Honorbuddy CC
// $Author: raphus $
// $Date: 2011-12-13 11:01:46 +0200 (Sal, 13 Ara 2011) $
// $HeadURL: http://svn.apocdev.com/singular/trunk/Singular/Settings/DeathKnightSettings.cs $
// $LastChangedBy: raphus $
// $LastChangedDate: 2011-12-13 11:01:46 +0200 (Sal, 13 Ara 2011) $
// $LastChangedRevision: 458 $
// $Revision: 458 $

#endregion

using System.ComponentModel;

using Styx.Helpers;
using Styx.WoWInternals.WoWObjects;

using DefaultValue = Styx.Helpers.DefaultValueAttribute;

namespace Singular.Settings
{
    internal class DeathKnightSettings : Styx.Helpers.Settings
    {
        public DeathKnightSettings()
            : base(SingularSettings.SettingsPath + "_DeathKnight.xml")
        {
        }

        #region Common

        [Setting]
        [DefaultValue(true)]
        [Category("Common")]
        [DisplayName("Use Death and Decay")]
        public bool UseDeathAndDecay { get; set; }

        [Setting]
        [DefaultValue(2)]
        [Category("Common")]
        [DisplayName("Will use Death and Decay when agro mob count is equal to or higher then this value")]
        public int DeathAndDecayCount { get; set; }

        #endregion

        #region Category: Blood
        [Setting]
        [DefaultValue(true)]
        [Category("Blood")]
        [DisplayName("Anti-Magic Shell")]
        public bool UseAntiMagicShell { get; set; }

        [Setting]
        [DefaultValue(false)]
        [Category("Blood")]
        [DisplayName("Army of the Dead")]
        public bool UseArmyOfTheDead { get; set; }

        [Setting]
        [DefaultValue(20)]
        [Category("Blood")]
        [DisplayName("Army of the Dead Percent")]
        public int ArmyOfTheDeadPercent { get; set; }

        [Setting]
        [DefaultValue(true)]
        [Category("Blood")]
        [DisplayName("Bone Shield")]
        public bool UseBoneShield { get; set; }

        [Setting]
        [DefaultValue(true)]
        [Category("Blood")]
        [DisplayName("Bone Shield Exclusive")]
        public bool BoneShieldExclusive { get; set; }

        [Setting]
        [DefaultValue(true)]
        [Category("Blood")]
        [DisplayName("Dancing Rune Weapon")]
        public bool UseDancingRuneWeapon { get; set; }

        [Setting]
        [DefaultValue(true)]
        [Category("Blood")]
        [DisplayName("Dancing Rune Weapon Exclusive")]
        public bool DancingRuneWeaponExclusive { get; set; }

        [Setting]
        [DefaultValue(80)]
        [Category("Blood")]
        [DisplayName("Dancing Rune Weapon Percent")]
        public int DancingRuneWeaponPercent { get; set; }

        [Setting]
        [DefaultValue(40)]
        [Category("Blood")]
        [DisplayName("Death Strike Emergency Percent")]
        public int DeathStrikeEmergencyPercent { get; set; }

        [Setting]
        [DefaultValue(30)]
        [Category("Blood")]
        [DisplayName("Empower Rune Weapon Percent")]
        public int EmpowerRuneWeaponPercent { get; set; }

        [Setting]
        [DefaultValue(true)]
        [Category("Blood")]
        [DisplayName("Icebound Fortitude")]
        public bool UseIceboundFortitude { get; set; }

        [Setting]
        [DefaultValue(true)]
        [Category("Blood")]
        [DisplayName("Icebound Fortitude Exclusive")]
        public bool IceboundFortitudeExclusive { get; set; }

        [Setting]
        [DefaultValue(60)]
        [Category("Blood")]
        [DisplayName("Icebound Fortitude Percent")]
        public int IceboundFortitudePercent { get; set; }

        [Setting]
        [DefaultValue(true)]
        [Category("Blood")]
        [DisplayName("Lichborne")]
        public bool UseLichborne { get; set; }

        [Setting]
        [DefaultValue(true)]
        [Category("Blood")]
        [DisplayName("Lichborne Exclusive")]
        public bool LichborneExclusive { get; set; }

        [Setting]
        [DefaultValue(60)]
        [Category("Blood")]
        [DisplayName("Lichborne Percent")]
        public int LichbornePercent { get; set; }

        [Setting]
        [DefaultValue(true)]
        [Category("Blood")]
        [DisplayName("Pet Sacrifice")]
        public bool UsePetSacrifice { get; set; }

        [Setting]
        [DefaultValue(true)]
        [Category("Blood")]
        [DisplayName("Pet Sacrifice Exclusive")]
        public bool PetSacrificeExclusive { get; set; }

        [Setting]
        [DefaultValue(60)]
        [Category("Blood")]
        [DisplayName("Pet Sacrifice Summon Percent")]
        public int PetSacrificeSummonPercent { get; set; }

        [Setting]
        [DefaultValue(60)]
        [Category("Blood")]
        [DisplayName("Pet Sacrifice Percent")]
        public int PetSacrificePercent { get; set; }

        [Setting]
        [DefaultValue(true)]
        [Category("Blood")]
        [DisplayName("Rune Tap")]
        public bool UseRuneTap { get; set; }

        [Setting]
        [DefaultValue(true)]
        [Category("Blood")]
        [DisplayName("Vampiric Blood")]
        public bool UseVampiricBlood { get; set; }

        [Setting]
        [DefaultValue(true)]
        [Category("Blood")]
        [DisplayName("Vampiric Blood Exclusive")]
        public bool VampiricBloodExclusive { get; set; }

        [Setting]
        [DefaultValue(60)]
        [Category("Blood")]
        [DisplayName("Vampiric Blood Percent")]
        public int VampiricBloodPercent { get; set; }
        #endregion

        #region Category: Frost
        [Setting]
        [DefaultValue(true)]
        [Category("Frost")]
        [DisplayName("Pillar of Frost")]
        public bool UsePillarOfFrost { get; set; }

        [Setting]
        [DefaultValue(true)]
        [Category("Frost")]
        [DisplayName("Raise Dead")]
        public bool UseRaiseDead { get; set; }

        [Setting]
        [DefaultValue(true)]
        [Category("Frost")]
        [DisplayName("Empower Rune Weapon")]
        public bool UseEmpowerRuneWeapon { get; set; }

        [Setting]
        [DefaultValue(true)]
        [Category("Frost")]
        [DisplayName("MasterFrost")]
        [Description("Will use the Master Frost Rotation.")]
        public bool UseMasterFrostRotation { get; set; }

        #endregion
    }
}

I added a Master Frost rotation and Rune Cooldown checks, can anyone test it? I'm not going to be able to for a further 2 hours.

 

It appears to of double posted sorry.

 

Open spell.cs in melee range and safe min change it too interact ranges;

I'm running feral cat with no issues with range

I'm going to sleep now but ill post what I have tomorrow I have to retract some other stuff I'm playing with first