[PB - A] Cooking+Fishing 1-150

Sorry guys, I've had one of my main bot accounts banned, appealing it at the moment, and another one hacked (wtf?) and Google is being a prick about giving me it's email account back to retrieve the account. In addition I am back at work.

I have not abandoned this project, I'm just a little busy.

If Cicro can work out some facing code for us (Has it been an issue on the horde at all Tumbum, or just the Alli toons?) that will make great progress towards our afk goals.

Also Cicro, I don't understand why you use the logic (Raw Fish) + (Cooked Fish), IMO we don't care how many coked fish are in our bags, and it causes issues when having to recook a fish. We might have 100 cooked fish in our bags, and no raw fish, and it tries to go cook them again because it didn't reach it's next bracket. I was talking to Inrego about it on his Engineering profile, and it seems unnecessary for the cooking profile.

 

I wish you luck.

 

Ive put it there so the bot wouldnt go fish the raw fish again if the bot was stopped midway thru the "while". But i can try think it thru one more time and see what i get if you still disagrees Atm its the logic in my head But ill put the facing issue as nr 1 prio. I believe its a problem for both sides. Unlike when AA is pool fishing, the bot dont have an object to face towards. I dont think the water counts as an object Would be ace if there was something for the bot to check if it was facing water, and then just write it into the DoFishing subroutine, but im affraid we have to put a facing for each fishing spot.

Ill fool around abit Seems like pi = 180?

As for the recipes, how do you like the idea of using "while" for !Has.Recipe? Worst case scenario is a bot spamming a vendor tho. Alternative is to add a if or two more (like the temp fix ive made). The 2nd if worked before, but seems like it was removed ?

And no problem for going afk... Its a freeware project... We dont charge ppl money so we can go AFK for long periods of time Added a rep link for you in post #0.

 

Atticus thats awful, I hope you get the ban lifted and things work out good for you!

Anyhow, I just started testing this and my toon (tauren) flies to thunder bluff, buys some stuff then goes to mulgore water shed and starts fishing. The only thing is that he doesnt pick up any fish, he just casts out the bait and waits through the channel and repeats it again. No errors in the debug either. Any idea what it can be?

Hmm, it worked when I ran your profile with Autoangler selected as botbase. Now Im confused, wasnt this supposed to be run with Professionbuddy?

 

In HB you need to select ProfessionBuddy as Botbase. In Professionbuddy Configuration you need to select AutoAngler and Configure it as shown on the First Page.

 

The horde part actually doesnt use AA. It has its own fishing code:

Code:

    <If Condition="Me.IsHorde" IgnoreCanRun="True">
      <While Condition="(Fishing.Level &lt;= Fishing.MaxLevel - 25 &amp;&amp; Fishing.Level &lt;= Fishing.MaxLevel) || Fishing.MaxLevel == 525" IgnoreCanRun="True">
        <CallSubRoutine SubRoutineName="EquipFishingPole" />
        <CustomAction Code="var1 = ObjectManager.GetObjectsOfType&lt;WoWGameObject&gt;().FirstOrDefault(u =&gt; u.SubType == WoWGameObjectType.FishingBobber &amp;&amp; u.CreatedByGuid == Me.Guid);" />
        <If Condition="var1 != null &amp;&amp; ((WoWGameObject)var1).IsValid &amp;&amp; ((WoWFishingBobber)((WoWGameObject)var1).SubObj).IsBobbing" IgnoreCanRun="True">
          <CustomAction Code="((WoWGameObject)var1).Interact();" />
        </If>
        <If Condition="var1 == null &amp;&amp; !Me.IsCasting" IgnoreCanRun="True">
          <CustomAction Code="SpellManager.Cast(&quot;Fishing&quot;);" />
          <WaitAction Condition="false" Timeout="1000" />
        </If>

The Alliance part is using AA:

Code:

    <If Condition="Me.IsAlliance" IgnoreCanRun="True">
      <CallSubRoutine SubRoutineName="EquipFishingPole" />
      <ChangeBotAction BotName="AutoAngler" />
    </If>

But you have to wait for Atti to answer. He is the pro regarding the horde part

EDIT: Gimme 30min. Working on an update that will get rid of AA for good.
EDIT2: No more AA! Started on fixing the facing issue. Will make a reply with what i need to know from the horde side. Just testing some changes i did to the DoFishing Routine

 

N1

Let me know so i can start my A+H Toon from the point where i got some issues. If they are complete with Skill, i run the Profile from beginning on some other toons.

 

Uploaded a new version. AA is no longer needed. Think ive fixed the horde issue aswell with the fishing

- Added facing for alliance
- Added a distance check before buying mats for cooking 1-40, so the bot doesnt run out and back into the house... Looked stupid

For the horde side:
Goto the spot where the bot wants to fish, look at the minimap and compare the direction with the picture attached here. Yes, the numbers are offcentered from East, West, South. Between the numbers there are .1 to .99. Think Atti will fix this himself, but if a kind soul wanna help out, feel free. Post what fish you are catching in that position (bot will tell you in the log) and a number for the facing. South = 3,14 (sounds like a number you know ?)

For the alliance side:
If the facing doesnt align up with the water, post what fish you should be catching at the position, and I will look into it. If you have an idea how the picture should be understood, feel free to post a new facing aswell

Im off to bed. 18h without sleep. So if Atti have time tonight (CET), he will prob look into any further problems Thanks for testing

 

Ok this Problem is still there on Horde Site. You can place the Toon anywhere, doesnt move or fly or anything.

 

Yeah I've set it up right its just that when I use it with professionbuddy it just throws the bait out and doesnt do anything when it bobs. Correctly set up autoangler and all.
Thanks Cicro I will check the update out after my gf is done raiding

 

ok got the same Problem now. Used it on Alliance. Toon goes to the Bay faced the right way, but after the catchbobs it doesnt pick the loot, so it fishs without picking the loot

 

It works though if you use Autoangler as botbase with the profile loaded. At least the fishing-stuff

Sent from my GT-I9100 using Tapatalk

 

Ok i tryed now without Autoangler and it doesnt pick the loot.

 

Guys, try removing AA2 from your install for me and testing it again. I've had this issue myself, others have reported this issue with the Dal 1 -525 profile too.

 

doesnt work.

1.
if i set AA in PB as Botbase it gets changed to CombatBot always. Doesnt pick up the Fishing loot

2.
deleted AA out of the bot folder and start the Profile. toon goes to the place, start to fish but doesnt loot.

Code:

[23:07:11:834] Spell_C::CastSpell(88868, 0, 0x0, 0) [10]
[23:07:12:855] PB 1.427:Wait Until false Completed

Did a fresh install of HB with a fresh copy of the Profile. Same issue.

 

Thanks Tumbum, will look into it asap, definately strange that it has stopped working.

 

Hmm, just wondering if ppl are using the latest version of PB? And are you running any WoW Addons?

EDIT: Just uploaded a new version. The bot will now check if its within range of the fishing spot (or else it will move/fly to there) and if it is facing the waters at all time. Try force it in another direction (Alliance and Neutral parts only)

Running the profile on a fresh toon atm, so lets see how it goes.

 

Just saw this and wow sure would like to try it. Thanks for posting. I ran into some issues installing/setting it up though. Did send you a PM. I set up a SVN folder, downloading your files but now I am not sure which files need to go where. It looks like things changed some since your first post instructions. I am a noob in regards to profession buddy so prob just me being dumb here but some help would be appreciated! Thanks!

 

All the files and folders in the SVN have to fo into this folder: Bots/ProfessionBuddy/Profiles (Note that my alch+herb also is in there, just ignore that for now ). Open HB, Choose PB, Go to bot config, Load the profile (the non-test version) (inside the botconfig), click start in HB Remember to check for updates. Im currently testing the profile on a fresh toon, and im correcting minor issues as they pop up

Also, remember to update professionbuddy to the latest version, or you migt get some issues with the bot not fishing

 

Thanks for the speedy reply!
I have updated PB and also your SVN folder.
I think I am messing something up still because if I move all files and folders in your SVN to the folder: Bots/ProfessionBuddy/Profiles folder, when I try to get it started, after setting it to PB, HB crashes. If I take out the files and folders HB works fine. So, I am not putting the right files in the right place and or not configuring HB and PB correctly. Sorry to be such a pain with this! Could you post screenshots of the folders and files and the HB and PB setup the way it should be? That would help a lot. Also, after setting HB to use PB, what do you set the HB profile to? (Or do you leave that one blank?) (I know that if I get the files in the right place that I would load your cooking-fishing profile within PB.)
Thanks again!