ah this is an interesting idea, do we think that we should implement this for all CDs? or specifically any cd longer than 2 mins? i think not using pillar of frost is a little silly, but gargoyle i can see, also unholy frenzy. I'll do it, see what you think.
i got no idea how to do that what so evAH!! i'd love assistance with it if anyone can modify what there is already it would be very welcome
Aaah, I actually hadn't noticed that Gargoyle is already prioritised after Unholy Frenzy....so that's awesome! This gives me time to manually pop my potion and off I go....good work! And you are absolutely right to prioritise DC's for the ghoul (for DT) As for pestilence - would there be an option to add something like "if more than 3 adds are present - /use pestilence" - (as you can see, I dont know anything about writing a CC) but I did see that as an option somewhere on a Paladin CC (I think!). Please keep on keeping on ossirian, you're doing an awesome job! Oh...and I'm testing this out on 10man HC tonight - results later (I'll try to SS recount if I remember!)
indeed the "use if there are adds" part is the easy bit, but it would spam it when there are adds as i dont know how to code it to check if the adds already have the debuffs. i tinkered with having it only pestilence when there was over a certain time on the diseases, and when outbreak was on cd by so much but ultimately they are just broad rules and not very effective. i figured for the anount of times you actually need to spread the diseases it wasnt worth coding it in, plus i dont know how, if someone could suggest a solution i'd be very happy to add it. i looked into; Public bool (?) pestcheck if TargetNextTarget(), TargetHasDebuff("blood plague"), return, else TargetLastTarget ::::::::::::::::this is the part i'm really unsure of. and then... public Composite CastPest(string name, CanRunDecoratorDelegate cond, string label) return new Decorator( delegate(object a) { return SpellManager.HasSpell(name) && SpellManager.CanCast(name, Me) && HowManyMobsNearby(StyxWoW.Me, 12) > 1 && PestCheck == true; }, new Sequence( new TreeSharp.Action(a => Me.TargetNextTarget()), new TreeSharp.Action(a => Log(label)), new TreeSharp.Action(a => CastSpell(Pestilence)), new TreeSharp.Action(a => Me.TargetLastTarget()) ) ); } anyone wanna neaten this up or just tell me if its bollocks?
lol...I'd tell you if it was bollocks if I actually knew wtf it said! Hahah!!! just out of curiosity - where did you learn to write this CC.....and could you point me in that direction please? I think I'd like to give it a bash, and who knows, maybe collaborate with you one day
SC.CastSpell("Pestilence", a => SC.CountEnnemiesInRange(Me.Location, 15) >= 2 && (from enemy in EnemyUnits where !enemy.HasAura("Blood Plague") && !enemy.HasAura("Frost Fever") select enemy).Count() > 0,"Pestilence") private List<WoWUnit> EnemyUnits { get { return ObjectManager.GetObjectsOfType<WoWUnit>(true, false) .Where(unit => !unit.IsFriendly && (unit.IsTargetingMeOrPet || unit.IsTargetingMyPartyMember || unit.IsTargetingMyRaidMember || unit.IsPlayer || unit.MaxHealth == 1) && !unit.IsNonCombatPet && !unit.IsCritter && unit.Distance2D <= 15).ToList(); } } This code is not mine it is Wulf's and Cowdude all credit to them and jasf10. private int PestCheck() { int count = 0; foreach (WoWPlayer Unit in ObjectManager.GetObjectsOfType<WoWPlayer>(true, true)) { if ( !unit.IsFriendly && (unit.IsTargetingMeOrPet || unit.IsTargetingMyPartyMember || unit.IsTargetingMyRaidMember || unit.IsPlayer || unit.MaxHealth == 1) && !unit.IsNonCombatPet && !unit.IsCritter && (!unit.HasAura("Blood Plague") || !unit.HasAura("Frost Fever")) && unit.Distance2D <= 15) { count++; } } return count; } public Composite CastPest(string name, CanRunDecoratorDelegate cond, string label) return new Decorator( delegate(object a) { return SpellManager.HasSpell(name) && SpellManager.CanCast(name, Me) && PestCheck() > 2; }, new Sequence( new TreeSharp.Action(a => Log(label)), new TreeSharp.Action(a => CastSpell(Pestilence)), ) ); }
quick answer is everywhere, i started by looking into one of cowdudes lazyraider scripts, and playing around with it until i understood it. then i look into other ppls cc's and try to follow them, look for useful functions etc. i wouldnt say i've learnt it as such, but alot of it is common sense and simple rules.
Pestilence now working for Blood and Unholy!!!! thanks to jamjar for the prod in the right direction i made a simple adjustment and the bot now spreads diseases like a 50 year old cocaine addicted hooker! download is updated and the link too.
1. It wont hold Blood Shield up 2. It cast only Heart Strike Edit#: Okay sorry its cause it was on a Test Dummy without Threat but Wont seen better for my Blood Shield and why it waste a Raid CD like Vampiric Blood? Please make a Fix for it and turn a 4pT13 Check in
it is a raid cd but its also a tanking cd. the raid healing is an excellent bonus but you want to save a 1 min cd? its not worth it. it doesnt keep up your blood shield because 1 third of the mitigation is the self heal and simply spamming DS to keep up the shield is ineffective tanking, you will take large spike damage which is how tanks die. it DS when you go below 90% hp, effective self heal and and absorb to prevent chain hit, which causes the problems.
1 word "WOW" for tanking as a DK this is amazing, personally I have never tanked before but just did a heroic doing deadmines and wow this is amazing I did put blood boil on my action bar and did press that a few times but that was just in case I lost agro but it worked so good this is now my DK blood tanking CC
Don't know whether anyone notice. Even at below 90% health it doesn't actually keep blood shield up.. I tried that by being gung ho .. grab a lot of adds and I mean a "lot"..
death strike is higher on the priority list than any threat based ability, if it doesnt use blood shield then it is because it is using something it assumes to be more valuable such as a cd, rune tap, or it cannot use it as its on cd. the priority based system doesnt allow the CC to skip DS if you are below 90% if it is available. the coding is very clear. i believe it does however prioritise spreading diseases etc as aoe aggro is difficult for a cc to grab. might i suggest that if you are pulling that many mobs which can do enough damage to you to kill you through cds etc then you are possibly pulling more than you can handle, as i have said, the cc is based around boss tanking, which is all about smoothing out the inevitable spike damage that you take as a tank, not preventing all damage.
Ah.. good to know.. anyway the test in pulling many adds than i could handle is just to try out instance farming with this CC..