[Warlock CC] skiWarlock 3.0 for HB2 - ALL TREES -

Attached is the previous version that's working with Questing Beta 2 for me. See if this works.

 

thank you. Is there not at Skiwarlock3.0 that works with questing beta, or no?

sorry for the ignorance, btw :/

 

The version he attached is this newest version, I just named it wrong. I didn't realize that the changes from questing beta to the newest build were enough to break it.

For users who are just joining us, the one in the first post is for the latest and greatest betas (the newest stable, and the new beta that will be out soon). The one labeled skiWarlock2.0.cs above contains all the new updates, but will work for the last few builds.

 

Please use the files located in the first post, these have had their names update to reflect the new version.

There is also a "pre1921" version for those still using the older stable version.

 

IMO it is useful if you are not lvl 70 and farming grey's for wool cloth

 

Is there any way to detect if a mob is immune to drain life? (old world mechanical unit, like the Harvester near westfall)
Now if the bot healt go below the drain life percentage it try just to spam life tap burning out all his own mana and looking very dump and eventualy get killed

 

This post is more for thedrunk and my own notes.

I'm not sure if all mechanicals can't be drain lifed, but if that's the case we can add a check using WoWUnit.CreatureType (9 is mechanical).

 

nvm delete please

 

Hey! Nice job on the CC! I just got one suggestion.

Proper single target rotation should be: Shadow Bolt -> Haunt -> Corruption -> Unstable Affliction -> Curse of Agony -> Shadowbolt, use Haunt on CD and reapply DoTs.

Just trying to optimize, sorry for being a wiseass!

 

Is there a CC out there that supports HB 1.923 Stable edition? I haven't found one and quite frankly the default one really sucks ^.-

Anybody else seeing how bad the rotation and spells are during pvp with the default settings as destro 'lock?

Again, I'm using 1.923 since it seems to be the best for pvp. If I'm wrong please correct me so I can go ahead and switch up to HB2 and get this newer, greater CC.

 

That's the raid rotation, but for regular leveling or grinding its not as efficient as Haunt->Corr->UA->CoA->SB.

 

This one should (I've used it on every version so far, including quest beta 3), if you're having errors post them.

 

Thank you, CC works fine, but is there any chance on LoS detection to be added, because in buildings and caves it just target mobs that are out of LoS and tries to cast until it get's blacklisted by bot (wastes time and looks suspicious)
Or is it a common limitation for custom classes?

P.S. I'm new here, so don't blame me if ask stupid questions ;-)

 

New version up, changelog and buglist below. As always, special thanks goes out to thedrunk for making it all happen.

Code:

16:  * 1.9.2.1 Update *

- Soulstone support only in PVE (not PVP)
- Basic colour support, skiwarlock logs = purple now :P will add colours depending on action 

Code:

17:  - Combat(): Added PetAttack() to target finding code, if current target IsAlive
- Combat(): Added IsAlive check to Mass Pull code
- Config: Removed 'useSoulstone' from spec config, made it global
- Combat(): Find Target: Now validates the target
- getMobs() + getAdds(): Ignore logic updated 

Code:

18:  * STABLE *

- Combat(): Mass Pull: Better logic to determine in and out of combat
- Combat(): Mass Pull: Depending on settings, the bot can now pull extra targets while in combat for AOE
- Combat(): Mass Pull: Changed aggro check loop back to a while{}, works better with new code
- Combat(): Mass Pull: Changed aggro check to use internal mob variable instead of CurrentTarget, less random targetting
- Combat(): Mass Pull: Fixed Intercept check for Pet's target - this will speed up pulling when the Felguard charges
- Combat(): Mass Pull: Added timeout (2.5 seconds) for pet to get aggro, may need to tweak this
- Combat(): Mass Pull: Fixed move to Pet code, caster will stay closer to pet for SoC
- Combat(): Added Dismount if mounted
- Added Variables: massPullMinInCombatHealth, massPullMinInCombatMana
- getAdds(): Fixed issues from r17
- Changed mob target check logic to use IsTargetingMe and IsTargetingPet
- added _debug, plus some debug logging to help tune Mass Pull 

Code:

19:  * STABLE *

- Combat(): Mass Pull: Increased timeout timer to 3.5 seconds...
- Combat(): Mass Pull: Disabled for PVP
- Combat(): Mass Pull: Blacklists timed out targets, blacklist checking added to getMobs()
- Added Distance sorting logic, both getMobs() and getAdds() now return their lists sorted by Distance
- getMobs(): Checks for Tagged and Elite mobs
- combatAdds(): Updates
- combatAdds(): Will AOE all adds instead of just the first one, after this normal spell decides are ran based on spec - this will spam a lot more AOE
- combatAdds(): Will target and AOE if no CurrentTarget
- Updated log wordings
- Added more colours to logs

Need:
- Better targeting code in getMobs() - would be nice to have access to HB's internal targeting
- AvoidMobs check in getMobs() targeting 

Code:

20:  * STABLE *

- waitWhileCasting() put into each Spell cast function, removed waitWhileCasting() after function call
- Changed any spell casts to use their functions instead
- Combat(): Mass Pull: Changed timeout to be variable with distance
- Combat(): Mass Pull: Timeout Distance: Changed this to use distance between pet and mob instead of Pulling Distance - this has greatly sped up Mass Pulling
- Combat(): Mass Pull: Added Distance between pet->mob check
- decideSpecSpell(): Added 'Seed of Corruption' check to 'Corruption' casting
- Added: waitWhileMoving()
- Removed Sleep's after MoveTo()'s, replaced with waitWhileMoving()
- getMobs(): Distance check changes
- getMobs(): When in combat, distance check (PullDistance yards) is made between Pet and Mob - this will prevent the bot from attacking mobs behind the caster
- getMobs(): Increased Distance check from caster to PullDistance * 2 (was 1.5)
- More log colour updates
- getMobs(): Disabled Facing as, new pet->mob makes this redundent
- Added CreatureType != Mechanical check to Drain Life
- getMobs(): AvoidMobs checking now works - any mobs in the CurrentProfiles.AvoidMobs will not be targeted by Mass Pull 

 

Firstly thanks for the great cc

My only problem is that at my current level (31) it seems to be very mana inefficent. I cannot work out how to configure the wanding part either. I'd like it to wand when the target is at 20% hp regardless of my own mana pool.

It seems to also get in this bug where it has full hp and lowish mana, it will life tap to gain some mana but end up having to drink and eat. When it could have just drunk and gone on it's way.

But overall it's going well. I'm getting around 15k exp per hour at 31 using this and the dwarf 1-60 profile.

 

This reminded me to fix a bug with wanding. As for your request of always wanding, you can change the following line (its dependent on which spec you are, do a ctrl+f for "Shoot" until you see the line that matches your spec):

Code:

            if (combatChecks && Me.HealthPercent < wandHealth && Me.ManaPercent < wandMana && SpellManager.CanCastSpell("Shoot") && Me.HealthPercent > 1 && Me.ManaPercent > 1)

            {
                drlog("Affliction: Wanding");
                return "Shoot";
            }

to

Code:

            if (combatChecks && Me.CurrentTarget.HealthPercent < 20 && SpellManager.CanCastSpell("Shoot") && !Me.IsAutoAttacking && Me.HealthPercent > 1 && Me.ManaPercent > 1)

            {
                drlog("Affliction: Wanding");
                return "Shoot";
            }

and then move that whole section to the top of the spelldecide of that spec (so its first in priority).

 

first of all id like to say that i really love your cc.
I found this problem while i was leveling my Warlock, whenever there are two ads, it will just spam corruption and curse of agony, im affliction btw
once again i dont have permissions to upload my log so im just gonna post a little part of the log

Code:

[11:18:23:329] Took 1498 ms to cast:Life Tap
[11:18:23:666] [skiWarlock] Utilities: Warning - there are 2 attackers.
[11:18:23:722] [skiWarlock] Targetting: Gordunni Brute
[11:18:23:728] [skiWarlock] Affliction: Cast Corruption
[11:18:23:730] CastSpellById: 11671
[11:18:25:215] Took 1498 ms to cast:Corruption
[11:18:25:668] [skiWarlock] Utilities: Warning - there are 2 attackers.
[11:18:25:736] [skiWarlock] Targetting: Gordunni Brute
[11:18:25:867] [skiWarlock] Affliction: Cast Drain Life
[11:18:25:912] CastSpellById: 11699
[11:18:27:415] Took 1544 ms to cast:Drain Life
[11:18:27:759] [skiWarlock] Utilities: Warning - there are 2 attackers.
[11:18:27:846] [skiWarlock] Targetting: Gordunni Brute
[11:18:27:852] [skiWarlock] Affliction: Lifetap
[11:18:27:883] CastSpellById: 11688
[11:18:29:375] Took 1497 ms to cast:Life Tap
[11:18:29:681] [skiWarlock] Healing: Use Healthstone
[11:18:29:713] [skiWarlock] Utilities: Warning - there are 2 attackers.
[11:18:29:821] [skiWarlock] Targetting: Gordunni Brute
[11:18:29:880] [skiWarlock] Affliction: Cast Drain Life
[11:18:29:881] CastSpellById: 11699
[11:18:31:375] Took 1482 ms to cast:Drain Life
[11:18:34:85] [skiWarlock] Utilities: Warning - there are 2 attackers.
[11:18:34:134] [skiWarlock] Targetting: Gordunni Brute
[11:18:34:208] [skiWarlock] Affliction: Cast Corruption
[11:18:34:210] CastSpellById: 11671
[11:18:35:705] Took 1498 ms to cast:Corruption
[11:18:36:83] [skiWarlock] Utilities: Warning - there are 2 attackers.
[11:18:41:677] [skiWarlock] Combat: Finding target...
[11:18:41:813] Activity: Selecting Gordunni Brute at 7 yards as target.
[11:18:41:862] Target setting took 47ms.
[11:18:41:875] Activity: Combat
[11:18:41:941] [skiWarlock] Affliction: Cast Corruption
[11:18:42:34] CastSpellById: 11671
[11:18:43:560] Took 1606 ms to cast:Corruption
[11:18:43:750] [skiWarlock] Affliction: Lifetap
[11:18:43:751] CastSpellById: 11688
[11:18:45:241] Took 1482 ms to cast:Life Tap
[11:18:45:782] [skiWarlock] Affliction: Cast Curse of Agony
[11:18:45:806] CastSpellById: 11711
[11:18:46:819] Took 1014 ms to cast:Curse of Agony

 

What level are you and have you changed any settings?

 

1. im level 48 atm
2. and no i havent changed anything

 

Does affli have any other spells besides Corr/CoA/Drain Life/SBolt at 48? I forget, but I think UA is at 50 (51?).