[Plugin] Giles Trinity

Yeah this plugin is almost perfect... except for the rend issue. Many of us barbs use rend as a huge source of DPS, and also healing. ive watched the bot being surrounded by a pack, and rend never triggers... im standing in plagued/molten/desecrator and would heal through it if rend was up but then i die...

 

lol i went back to 1.3


msg to giles:

I feel you are over doing this plugin fixing to much and causing to many bugs errors your best work was 1.3. Ver 1.4 was decent too I think your over working this plugin and cause to much headache for yourself.

 

I just wanted to say Giles you are the mother fucking MAN. I've been sitting here watching my bot stomp act 3 with no LoH whatsoever. I'm having more fun letting DB play than I ever did... love it.

 

There is no way to check for debuffs on targets. Atm rend is set to;
- not use if you have <75 fury and wrath/berserker/earthquake is ready for cast and wants to cast, so it doesn't keep spamming rend and prevent a power-ability.
- Spam 4 seconds by default...
- OR Reduced to 1.1 seconds *IF* more enemies are in range than when last rend-used (eg if last rend only hit 1 enemy, and there are now 2+ enemies within 9 foot)
- OR you are at 65% max fury spam every 3 seconds instead of 4... reduced to 1.8 seconds if your current, primary target has changed (eg you are actively targetting a different mob to when last rending).

While I personally can see no reason to spam any faster than any of these situations, you can change this to experiment yourself. Find the rend code by searching for the phrase "Rend spam" within the code. Below this you could try lowering those various timers. You could also simply try reducing the main timer of Rend by replacing this line (which is found elsewhere);
{SNOPower.Barbarian_Rend, 4000},
With something like;
{SNOPower.Barbarian_Rend, 1200},
To justs pam at 1.2 second default instead of 1.4

Did you follow the "Updating" instructions on post #1. And be honest. If you did, did you try going through the "common problems" section of post #1? Be honest again. I don't mean to sound patronizing/rude, but I have found many people simply *SAY* they did a fresh install of DB, or *SAY* they followed instructions, when they didn't - because in their heads they don't believe following those instructions will actually do anything, and so they hope that by saying "yeah I did that, didn't work, what next?" they will get a magic solution.

If you *DID* those things, and you still have problems - let me know what type of mobs they are, and what routine/profile you were on (and in what part). Some routines/profiles set a very low kill-radius in particular parts of the map, to help avoid stucks, and my plugin will max at whatever kill radius the routine sets.

I could just go back to not doing any plugins at all and have no "headaches"? This plugin does a lot. It's a complicated piece of work. Most people have no issues. Those that do - many of them didn't really try the common fixes (deleting commonassemblies folder, deleting settings file, or a truly fresh install of Db without ANY copies files from the old folder). Those that still have problems - I can't help you if you don't explain the problem fully. Simply posting and saying "nah, don't like, going back to older version" is about as useful to me as a chocolate teapot is to somebody who has a phobia of chocolate. And teapots.

Stop DB. Enable the status bar for debugging (in the advanced tab). Run the routine. Now when you stuck, explain the stucks in detail to me. Are you stuck trying to reach a monster you can't reach? Are you stuck trying to avoid things? Are you stuck standing behind every chest you try to open? Or are you stuck in a certain part of the map after fighting a monster because of the routine/profile you are using (which now that 1.4.1 has fixed the issue of incorrectly using a lower kill radius than was set by the routine, may be an indication that 1.4.1 has highlighted problems in the routine you are running that earlier versions were simply covering up). Try changing the timers for revenge to those above.

As for Revenge and Rend in general, one other thing to try would be this. In both the Rend and Revenge checks, change this small piece of code;
"targetCurrent.fThisDistance <= 9f"
To;
"targetCurrent.fThisDistance <= 12f" (or 11f or 13f - will need experimenting with).

That exact text is found in both the revenge, and the rend use - and might be the fix we need. I do need users helping me by experimenting and making code tweaks themselves, and then letting me know if it works or not - because frankly I can't test every single skill on every class in every situation myself *AND* keep working on other stuff.

The bot doesn't aim for trash over elites - but melee characters do have some preference for closer stuff - elites do get a hefty bonus, but the range of mobs might mean that it goes for the closer-things first, which as greys outnumber elites when you first meet packs, can mean greys get targeted. It will also add extra priority to mobs on low health - and given that greys frequently hit low-health within a hit or two from your follower, can mean the bot will go and "finish them off" with a quick hit since it detects a near-dead target.

 

Something is still wrong with priorities. Sometimes my barb just stands and does nothing and let small grunts kill him.

 

Hello Giles,

Trinity 1.4.1 does not miss elites anymore but it combat is rather slow now compared to 1.4.0 and sometimes I notice a white mob blocking the bot the bot try to move around it instead of simply killing it which is wired.

 

confirm that rend is broken in 1.4.1 (worked very nice in 1.3.1, back to it for now)

 

I'm happy with 1.3.1 and gonna stick with it until elite skipping is confirmed or fixed.

Haven't tried 1.4 so don't know about improvement to the attack-pause-attack issue. From what I read, it sounds improved.

With scoring, I think GF and MF are important. They are useless on gloves, bracer, boots and maybe chest, but everything else can sell for good price, easily ranging from 300k to millions with good combination. I think the priority now is to improve combat and stability. Options with scoring could be another cool feature to be added in the future

Again, thanx heaps to Giles. I am farming Act 2 with little profit. Once I break-even I will surely donate!

 

oh boy something new to play with...thanks Giles

I just have fun. If I didn't I would delete the damn game and go get a good one LOL

 

Hi Giles I have to say you did a fantastic job with your plugin If i wouldnt see it myself i wouldnt believe that a bot can play as nice and effective as it in fact does. I noticed a thing when going from 1.3.1 to 1.4.1... Is it possible that wrath of the berserker isn't trigered sometimes when fighting elite packs... even if its off cd and there is enuff fury to on hand ? In 1.3.1 wrath was used as soon as an elite pack was triggered or if it was on cd at that point it was used as soon as it came off cd ( if still fighting an elite pack)

Also is it possible for the bot to check inventory space everytime it goes to town to cheange the zone ? And if lets say 4 or less space is free sell, salvage and stash the stuff once its already there ? It would apear more human compared to porting to new zone with sometimes 2 slots free and then coming back after one blue.

Happend to me to.


Thanks

 

Giles,
As far as rend goes, I notice when I set the bReCheck flag to ture in GilesUseTimer: GilesUseTimer(SNOPower.Barbarian_Revenge, true), it spams rend like crazy! And that's actually better for me, because my only fury spender/primary dps. I'm trying to figure out what exactly the bReCheck flag is for, and (correct me if I'm wrong) I think it is to guard against situations where you activate the skill, but it doesn't actually trigger (maybe because you were just hit or something). I think if the time limit for bReCheck were less than the animation time of rend (about 1/3s), it would not rend twice in a row, and would spam it much more reliably.

Also, I would like to make it rend even when avoidance is activated, in order to heal while avoiding. If I just remove !bAvoidanceEmergency from the rend conditions would it cause any ill side effects?

Thanks

Oh and one more thing, can you disable using earthquake on goblins? 90% of the time is just runs out right away anyways.

 

Hello Giles,

I am playing a WD on Inferno A3 and just upgraded from 1.3.1 to 1.4.1.

The 1.3.1 version was close to perfect. Only thing that bugged was that Acid Cloud was sometimes used too much on the same spot/mob and sometimes not on exactly on the mobs (and you know that, and fixed it according to releasenotes). Now, with 1.4.1 we do not cast Acid Cloud as often, and I know that was a requests from some players some posts back (regarding out of mana) so maybe that is on purpose.

I would, personally, like if it was possible to spam Acid Cloud a lot more then in the latest version. More like its was in 1.3.1. I have found that using the passive skill Vision Quest (that procs on toads) is extremely effective and I am almost never out of mana. It makes the farming so very much faster then toads.

If one use the Acid Cloud rune "Slow Burn" the AOE DOT is 6 seconds. Would it be possible to change the plugin so it casts the spell at least every 5:th second in combat? Or just change the priority on the spell in general?

I realize that not everyone wants it to act like this so maybe you could point me to where one would change these settings in GilesTrinity.cs? I have tried to change the obvious settings with no apparent effect (like lowering SNOPower.Witchdoctor_AcidCloud, 250).

Oh, and thank you so much for all your time and effort.

 

Lot of idiots in here not reading installation instructions. How many times does it have to be repeated to clean install or deletes the appropriate directories/files when installing a new version?

As for someone who DID follow the instructions: The rend priority is still not correct, and it's very hard following your if statement ("rend spam") concerning its logic.

My Barb engaged an elite pack with full fury. It was 3-4 elites + random trash mobs. He simply just sat there spamming Frenzy. I had to intervene and press Rend to save him.

Other times, he does it perfectly on trash AND elite packs. I can't seem to nail down why there is this large gap in ability logic.

Other times, he will engage a single higher health trash mob at full fury, and not Rend a single time.

It's very, very random. Even as a programmer, I'm having a difficult time following the if statement. There's probably some logic failure in there and under certain specific situations, he doesn't use Rend. Maybe it needs to be broken up a bit to be more clear/accurate?

 

v1.4.2 uploaded:
- Changed a number of skills that judged enemy range on skill-use decisions, to take into account the monster's physical object size. Will help many abilities trigger more accurately.
- Rend timers decreased (spam increased) for each specific circumstance.

Updating Plugin Versions:
Please always DELETE the entire "CompiledAssemblies" folder from within the DB folder (this is completely fine and safe to do - DemonBuddy will rebuild this folder!), while DB is closed, when updating plugin versions.
This is just as a bare-minimum. If you still have issues, try deleting "GilesTrinity.cfg" from your /settings/ folder to reset to default settings (can fix problems - mainly if you haven't done this since upgrading to 1.4 - shouldn't ever need to be done again after v1.4) and reloading DemonBuddy.
As a last-measure, following the instructions on post #1 can fix a number of upgrade/install issues.

 

Was about to post my rend adjustments... got it working nicely. Guess i'll hold back and give this version a shot... thanks a ton Giles

 

Good job Giles

What about an option (or re-code?) for goblins, to ignore everything untill they are dead, not focusing in anything else, no matter what?

 

The problem is, I tested it out in Act1 and got killed by the first set of easy trash mobs. It didn't use rend and it didn't seem to use revenge - was just using frenzy. 1.4 seemed to work ok except for ignoring the last mob of groups (elites or trash) and just standing there taking a pounding. I had to go back to 1.3.1 for now.

 

^ rule of thumb, if you cant go heads up against a trash mob with just a basic attack, you most likely arent geared right to farm that act..

 

Testing 1.4.2 right now. Bot is rending like crazy. I'll probably go in and change the spam timer to be slightly higher, but too often is better than not often enough right? Revenge casting is good as ever(upgraded directly from 1.3.1 to 1.4.2).

Trying to keep an eye on frenzy stacks and make sure it's not rending so much that those are allowed to fall, so far the bot seems to be keeping it up when not avoiding AoE.

Very happy with the performance this version.

 

Working much better now, I think I see the code you added in. I am adjusting the range to 4 foot for the check to see if any new enemy's come into range, it seems to help with the missed rends.