Little Fix for Pickuping Infernal Key and stacking them

First I have to say sorry to Giles.
I don't have much time to check my fix is work or not. which cost him too energy while he should have some good rest at home.

now this is the version that can really pickup keys, stash them and stack them up.
tested on A3 only, if you got problems on picking up keys, please post here and give Giles some time to recover.

Update:
fix-fix for 1.6.3.1
fix any bug about the infernal key
add stats report about the infernal key

1.6.3.1 had some minor bug and cannot stack keys up.


Update Again:
fix for 1.6.3.3
fix bug about the infernal key

Giles did some good job on avoiding ignoring keys, but he also leads to some troubles.
I recovered some patches that i did in 1.6.1.1 and added some dirty trick for identifying keys.
hope this one can truly fix this problem.
test is needed.
sadly my barb is too weak to run this test fast, and i have to sleep for my tomorrow's job.
good luck.

 

So Giles 1.6.3.1 isn't actually taking keys, even though the .1 was supposed to fix exactly that? And now you edited that latest version? Working?

 

testing... I'll reply if I get anything (using with ciggarc's profiles btw)

 

and yes, it does work. Nice job ksmaze.


EDIT: Well, I don't know if it happened to you, but mine grabbed but did not stash the key.
I switched the code "infernal key" to "autokeep key" on the bool ShouldWeStashThis part of the .cs... might work.

}
if (TrueItemType == GilesItemType.InfernalKey)
{
if (bOutputItemScores) Log(thisitem.ThisRealName + " [" + thisitem.ThisInternalName + "] [" + TrueItemType.ToString() + "] = (autokeep key)");
return false;

 

can you tell us what code you changed im just curious

 

and this is only for a3?

 

me or ksmaze?

 

so far I've only checked the a3 profile. Might work on a1 and a2 as well.

 

mine is working on stashing and stacking. but yes, your point is right, you actually should replace "return false" to "return true"
I'm working on it right now, implementing some stats, after that I will upload the right version.

 

this one only added a itemtype in the code. to help DB recognize the infernalkey, and pick it up, stash it, stack it.
no more.

 

think ill use the original till than

 

Update:
fix-fix for 1.6.3.1
fix any bug about the infernal key
add stats report about the infernal key

1.6.3.1 had some minor bug that may cause bot cannot stash them. and it cannot stack keys up.

 

Can not for A1 or A2

 

strange... i tested it on A1, it works. maybe you should download my fixed version.

 

Giles 1.6.3.1 picks up keys fine. No need for this. Running that version and had 3 keys total for the bots stashed this morning.

 

The bot missed a key again...

even with this "fix"

 

Ho a big thx

 

next time it missed it, please use Dump RActors, and send the log here please.
i don't have time for checking right now, but it works on A1 and A3 in my computer at least.

 

Working for me in Act1 & 3 also, havent tested 2

 

Missed key in Act 1
[16:52:17.320 N] [1E816B00] Type: Item Name: DemonTrebuchetKey-11687 ActorSNO: 166943

edit: this is GilesTrinity 1.6.3.3