[Plugin - Prof] Liquid's Disenchant Plugin

I disenchants. Then it does not loot the mats from the loot window. It just stays open forever.

 

Do you have space in your bags? Do you have autoloot enabled?

 

1. yes
2. no

Do I have to?

 

Does this automill too?

 

Yep

Since it's called Liquid Disenchant plugin I think not ^^

 

Anyway to get this working for soulbound greens in bag?

 

Yes, remove the soulbound part in the checklist probably around line 116 in your copy (never sure because I look at my own copy )
Something along the lines of

Code:

(targetItems[a].IsSoulbound || 

Just delete or quote out (double forward slash at the start of the line takes care of it) that line from the list so the next first line would be

Code:

(targetItems[a].IsAccountBound || 

Do keep in mind that you have to put a new opening bracket ( at line 117 since we deleted or quoted out the former one line.

However...

1) I don't take any responsibility if the bot goes berserk and starts disenchanting other items you would NOT like to loose.
2) If you made any more modifications to the code (like DEing blue items) be aware this is also gonna DE your blue bound items.
3) Most likely it's gonna try and DE more items that can't be disenchanted which are green soulbound items (they used to be excluded before this change you want to make).
So keep in mind the startup is gonna take a bit longer and you will see a few more false positives in the logs which should be limited to once per session (start/stop of the bot)

Good luck, Liquid.

 

Works like a pro. I do see it try to disenchant my lock boxes but it only tries once. I can over look that. Amazing when your out in the field grinding rep. Saves those bags from getting full. Also amazing when you get a mailbox filled with greens that need broken down. +Rep for you sir!

 

Yeah, it only checks if the item corresponds to the settings (e.g. uncommon not soulbound item).
It then tries to DE once and if it fails it goes to the ignore list for the rest of the session.

If you have any green lockboxes, I have already reserved space inside the code for them (another kind of lockbox is already actively ignored).
Since there are no reports I didn't bother to add any more.

When you open the file in your favorite texteditor around line 87 you will see the lockbox ignore part.
Just add the item ID there in the same fashion and it should be ignored all future sessions.
You are probably referring to the ghost iron lockboxes (I believe they are of a uncommon quality).

Then save and restart it all, and from then on it should ignore it always.

Thanks and regards, Liquid.

Edit:
Here's what it should look like more or less to cover all green lockboxes:

Code:

            // lockbox
            4632, 4633, 4634, 4636, 4637, 4638, 5758, 5759, 5760, 31952, 43622, 68729, 88567,

 

I managed to cleanup most of my repo's, so here's the link everyone's been asking for.

SVN url: https://github.com/LiquidAtoR/LiquidDisenchant
You can access GitHub with a regular SVN client.

And to prevent anything unwanted about my Repo's (if you decide to browse trough them)...
I'm not gonna release the rest unless I feel like or want to, so don't bother asking about it.
Most of the plugins I wrote for myself, and not for the masses.

 

Does this badass take stuff from the mailbox?

 

No, but whatever comes in your bags will be disenchanted (e.g. open mailbox with BetterInbox wow addon so you can take all 50 at once and the plugin does the rest).

 

Only new stuff to bag? I have some greens that are laying in my bag and it wont find em. I start HB i see it blacklisting one its cant but missing ones it can?

 

As long as the items are of Uncommon Quality, NOT Soulbound yet, and not in the ignore list, they should be disenchanted.

 

I can't use this plugin. The plugin dont detect items i have in bag and when i click "disenchant" myself i see the message in wow that my skill is to low...i try to disenchant items who needs a 225 skill, i have 312.

 

If you see a message in wow, it's not the plugin.
This plugin doesn't print messages in-game.
You obviously have items that need a higher skill level than 225 or they would've been disenchanted.

 

It will be superb if u add Options to DE all greens/blues/epics in bags only.

 

You can just fiddle around with the variables to make it do this.
Just open it up in your favorite editor.
Look for this part (around lines 124 - 142):

Code:

            for (int a = targetItems.Count-1; a >= 0; a--)
            {
                    if (ignoreItems.Contains(targetItems[a].Entry) || alreadyDisenchanted.Contains(targetItems[a]))
                    {
                        targetItems.RemoveAt(a);
                    }
                    else if 
						(targetItems[a].IsSoulbound || 
							targetItems[a].IsAccountBound || 
								ignoreItems.Contains(targetItems[a].Entry) || 
									targetItems[a].Quality == WoWItemQuality.Poor || 
										targetItems[a].Quality == WoWItemQuality.Common ||
											targetItems[a].Quality == WoWItemQuality.Rare ||
												targetItems[a].Quality == WoWItemQuality.Epic)
					{
						alreadyDisenchanted.Add(targetItems[a]);
						targetItems.RemoveAt(a);
					}
            }

and delete what you want it to do (yes, delete the specifications you want it to do, because the way it's done here, it prevents them by adding them to the already done list).
So if you want it to DE soulbound items, delete the first line of code (but leave the opening ( or it goes wrong).
If I read your request correctly it should look like:

Code:

            for (int a = targetItems.Count-1; a >= 0; a--)
            {
                    if (ignoreItems.Contains(targetItems[a].Entry) || alreadyDisenchanted.Contains(targetItems[a]))
                    {
                        targetItems.RemoveAt(a);
                    }
                    else if 
						(targetItems[a].IsAccountBound || 
							ignoreItems.Contains(targetItems[a].Entry) || 
								targetItems[a].Quality == WoWItemQuality.Poor || 
									targetItems[a].Quality == WoWItemQuality.Common)
					{
						alreadyDisenchanted.Add(targetItems[a]);
						targetItems.RemoveAt(a);
					}
            }

This should Disenchant all your items of uncommon, rare and epic quality, whether or not soulbound in your bags (no guarantees, haha).
I will not be able to be held responsible for loss of gear

The way it's currently setup is a 'safe' way not to loose any soulbound items that are part of your gearset.
That way everyone can use it without any unwanted side effects (item x or y has been disenchanted and I wanted to keep it etc etc).
You want it to DE more, you will have to take the effort to change the code to include it ^^

Good luck and regards, Liquid.

 

Thats upper class mate. your efforts highly appreciated.

I'll try that soon and don't worry about item loss, the one thing I'm afraid of if it DE actual equipped gear . While I have loads of cata BC epics need to be DE.

Best regards.

 

As long as it's not in your personal bags, it's not gonna DE it.
So technically, what you have in your bank or equipped should not be affected