TuanHA Shadow Priest

I fixed the 'doing nothing' issue, it appears the code that is wrong was in the MindFlay/IsChanneling part of the statements and not in SW. Here is what I changed:

I first changed SW back, for better performance (note-- SWD doesnt need lineofsight or standing still):

Code:

public Composite SWD()
{
    return new Decorator(
        ret =>
        !Me.Mounted &&
        CurrentTargetIsValid &&
        CurrentTargetIsEnemy &&
        Me.CurrentTarget.HealthPercent <= 20 &&
        Me.HealthPercent >= 20 &&
        !CastingorGCDL() &&
        IsInRange(Me.CurrentTarget, 40) &&
        SpellManager.HasSpell("Shadow Word: Death") &&
        GetSpellCooldown("Shadow Word: Death").TotalMilliseconds <= MyLatency,
        new Action(delegate { CastSpell("Shadow Word: Death", Me.CurrentTarget); })
        );
}

And for MindFlay I changed the following (again fixed, a little more 'open' because you want this to trigger):

Code:

public Composite MindFlay()
{
    return new Decorator(
        ret =>
        !Me.Mounted &&
        Me.Level > 9 &&
        CurrentTargetIsValid &&
        CurrentTargetIsEnemy &&
        IsFacing(Me.CurrentTarget) &&
        !Me.IsMoving &&
        ((!CastingorGCDL() && Me.ChanneledCastingSpellId != 15407) ||
        (Me.ChanneledCastingSpellId == 15407 && Me.CurrentChannelTimeLeft.TotalMilliseconds < MyLatency)) &&
        IsInRange(Me.CurrentTarget, 40) &&
        Me.CurrentTarget.InLineOfSpellSight &&
        SpellManager.HasSpell("Mind Flay"),
        new Action(delegate { CastSpell("Mind Flay", Me.CurrentTarget); })
        );
}

And then you can find the bug in the code in helpers.cs (you said 'Me.CastingSpellId != ...'):

Code:

public static bool Casting()
{
    return Me.IsCasting && Me.ChanneledCastingSpellId != 15407; //Mind Flay
}

And that made it work wonderfully, MindFlay over MindFlay is being clipped by a hair, and Mind Flay is Cancelled when something else proc's.

Can anyone confirm and I am not forgetting something? Just trying to help...

 

Hey bullet2k,

Thank you for your help.

I just update svn hope more dps increase and fix the do nothing symptom.

For the Smite lol i surrender.

There not a single line to cast Smite in my code and how come HB still cast it, can anyone help me on this pls.

 

@jossa90 this routine is for dungeons only, the shield drains too much Mana using it like that. This is most of the time pointless too as you have a healer with you and you shouldnt take damage anyway. You can always cast it yourself anytime you want. And forcing you to focus on the target kinda ruins that for you by limiting your movements, while in Dungeons you need to be free to move during boss fights. The rotation can be better, but lets first see how it does in dungeons, okay?

 

Well, the mind flay thing is kind of essential imo. it's not nessesary to recast VT that often etc.

And the shield.. well it might make things easier for the healer.
Besides, the spell should not cause too many problems.
If your gear is good enough for heroics or raiding, then your mana should also be able to handle this spell also.

 

The Custom class is designed for dungeons/raiding.

Power word shield is just a waste of a GCD every 15 seconds, it's better of being saved for when you need to move fast using body and soul. faster you move faster you can get back to dps.

The rotation is correct, i have simmed it hundreds of time's, it's performing really well for a bot.

Mindflay is not essential, mindflay is our worst spell and is only used as a filler when other more important spells are not ready.

Mindflay does get used in dungeons, i'm assuming you have FDCL or DI, or both, i'm also assuming there was more then one target wich means your priest was busy casting more important procs from these two talents.

We could make it face target, but again not really required as you are in control of movement.

Also not sure what you mean about casting VT that often is not needed?


@bullet2k Thankyou

 

Never mind, seems like you know the shadow specc better than me, haha.
I gotta admit, that I'm more of a healing/tanking person than a dps person.
But i don't mind learning, so something new every now and then is just good I guess.
I can't always be right, haha.

 

@jossa90 the mind flay is part of the fix, previously provided on a separate issue (now you see them up to three times in a row). You may want to update through SVN, and see for yourself. Note, the LazyRaider and CombatRoutines like these are to help with rotations mostly. You can always Fear/Shield/Whatever yourself, assuming you press your HotKey before GlobalCoolDown has finished. Enjoy...

 

many thank-you's for the Mindflay clip to mindflay, was about to ask tunha about this lastnite but he had to go.

 

@bullet2k

Thanks for fixing this issue, now it's working absolutely fine, no more smite / waiting issues (tested in a lfg - heroic)!

 

nice nice, gonna try it when the servers are back up later today

 

Awesome!

 

I don't have a level 90 priest but by reading these post, I guess the Combat Routine worked well.

Big thank too bullet2k, THANK YOU FOR FIXING MY STUPIDITY LOL

 

Cleared MV last night and was top DPS on all but one fight. Many thanks for updating the profile. Elegon is still broken for pillars and sparks so I switched to manual for that encounter. Elegon is a DPS race so I was hoping I could lazyraider it but there would need to be some custom code. For example, the sparks should not be dotted - instead mindspike. Also, the pillars cannot be targeted which may be a limitation of honorbuddy? Not sure. Anyway great work on the profile. I have my own few tweaks I've made and I also wanted to mention you made the right fixes for Halo.

Edit: Just thinking about it more, the Elegon fight would need some complex logic to work well. Three shadow orbs should be built up for devouring plague on the 4th and 5th spark. I'm guessing this kind of logic is outside the scope of this routine but I can provide some of the more complex logic if the authors want to go after boss specifics.

 

We tried every possible possibility to fix the Pillar but still no success.

For unknown reason, HB just don't attack that pillar

It's nothing we can do now... I hope new HB release can fix it.

 

i noticed i removed LastCastSpell != "Shadow Word: Death" && from SWD(), in the fix provided. It is probably better to put that back in, because it has nothing to do with the fix, and it appears to spam this spell...

Also, the Shadow Word: Pain (Multi&Moving) seems to forget to check if SWP is already on target for some mobs. In the Moving/MultiTarget parts, I changed the cast-call to check for that because I am losing mana. I'll test more another time...

 

Something is very wrong with this profile and I just noticed it while raiding today so I think it might be recent. While fighting a boss with no adds, this routine now tends to just sit there and spam SW over and over. Has anybody else been having this problem?

I'm guessing it has something to do with the code the guy above me was talking about.

Another thing I've noticed is the Halo logic appears to be off now. When standing at exactly 25 yards, it never casts it. Halo is set to on and I've tried moving forward and backwards to try to get it to go off but it never does anymore. Today when I was fighting a single mob with no others at the 25yrd range, it was using Halo when the mob was right next to me.

 

Have you tried Tyreal? Its probably the fastest botbase I've tried right now. Just an irritating movement issue.

 

Please give us your log.

 

I don't think the elegon fight will ever be 100%, not until the problems are fix'd within HB at least. we have tried everything to makr it attack the pillars with no luck, and a second rotation for sparks could be made but they are also using a slow targeting method because HB is borken on this fight so would probably not be very good.

At the moment i just pause it during Spark phase and Mindspike spam the orbs to death, no 3 orb DP is needed, you can mindspike up to a 7th spark to death with no problems

I have also encountered the Halo issue, will look into it, have not encounters the SW-D spam though. and the SW-P spam should be fixed in latest svn

 

I know you've done some hard work for this cc, but is there any way you could implement a GUI so it can help with quest bot, my guy doesnt turn to face mobs, he doesnt heal himself or anything, I found another Spriest CC but Im sure its not as good as yours. Would love a small GUI just to help out.