CLU (Codified Likeness Utility) - (Pt. 2)

Frost DW uses a MasterFrost style for its rotation. The behavior you have described is exactly what it's supposed to be doing.

 

I'm getting this error message when using any profile/botbase, and any class. I've only really noticed it on my aff warlock and resto druid when raiding, but the healing output from my druid is terrible when I let CLU do it. I assume it's because of this error. Turning frame lock on makes it significantly faster, but I can't control movement then which is a bit useless in raids.

Code:

[CLU] 3.3.8: ERROR: Could  not add combat log event filter! - Performance may be horrible, and  things may not work properly!

Any suggestions on how to resolve? I've attached the log from my warlock, and have one from my resto druid, but that's full of player names - so would PM if required.

 

Ok, I'll forgive you since it's been more than 20 pages since this was asked. This error has is largely inconsequential. By itself, it should not adversely affect the CC. If you are still having problems with the CC please post them here for assistance.

As an aside for the mods, would it make sense to prune this thread down to a more manageable reply count to get rid of all of the noise?

 

Is there any way to change the rotation type? This rotation really reduces my DPS compared to Singular. But Singular has some weird targeting issues so I don't really like using it.

 

Using a 2h weapon instead would be your only option.

Side note for developers...
The HasBothDis method seems to have a logic bug in it. HasBothDis needs to check if both diseases are there (&& instead of ||). It also needs parentheses added to group the two Frost Fever checks.

Classes\DeathKnight\Common.cs:148-149 should probably look like this instead

Code:

                return [B][COLOR="#FF0000"]([/COLOR][/B]frostFever != null && frostFever.TimeLeft >= TimeSpan.FromSeconds(2)[B][COLOR="#FF0000"]) &&[/COLOR][/B]
                       (bloodPlague != null && bloodPlague.TimeLeft >= TimeSpan.FromSeconds(2));

 

Thanks, I did search but couldn't see anything. The thread is a bit bloated. I am still having issues however, I can end a boss fight with nearly full mana because of how slow it's healing. If I do it by hand I tend to finish 2-3rd on healing done (my gear isn't great), with no mana left.

Like I say, with frame lock on it works great, but there's few bosses where you can get away with not moving at all.

 

Ever since the facing update, my lock won't attack anything. She just stands there and looks at the mob. On the bright side, facing is no longer an issue =p

 

I'm not as familiar with the healing side of the CC, so I can't say for sure. But I don't think that error would have anything to do with it.

I found the relevant piece of code in CLU and looks like it's trying to attach to combat event log twice, once without a filter and once with. The problem is when it tries to attach to the same event log with the filter. The code probably needs to be changed to the following.

CombatLog\CombatLogEvents.cs:101-121

Code:

         private static void AttachCombatLogEvent()
        {
            if (_combatLogAttached)
                return;

            // DO NOT EDIT THIS UNLESS YOU KNOW WHAT YOU'RE DOING!
            // This ensures we only capture certain combat log events, not all of them.
            // This saves on performance, and possible memory leaks. (Leaks due to Lua table issues.)
            [COLOR="#FF0000"][s]Lua.Events.AttachEvent("COMBAT_LOG_EVENT_UNFILTERED", HandleCombatLog);[/s][/COLOR]
            if (
                !Lua.Events.AddFilter(
                    "COMBAT_LOG_EVENT_UNFILTERED",
                    "return args[2] == 'SPELL_CAST_SUCCESS' or args[2] == 'SPELL_AURA_APPLIED' or args[2] == 'SPELL_DAMAGE' or args[2] == 'SPELL_AURA_REFRESH' or args[2] == 'SPELL_AURA_REMOVED'or args[2] == 'SPELL_MISSED' or args[2] == 'RANGE_MISSED' or args[2] =='SWING_MISSED'"))
            {
                CLULogger.TroubleshootLog(
                    "ERROR: Could not add combat log event filter! - Performance may be horrible, and things may not work properly!");
            }

            CLULogger.TroubleshootLog("Attached combat log");
            _combatLogAttached = true;
        }

 

still loving this on my shammy just tried to dps ina dungeon n it wasnt using chain lightning when theres more than one mob, it does it fine when im just questing n junk. i looked at the code n its not quite what im used to. anyone know how to fix it?

 

A little off topic, but is wulf still alive? I haven't seen anything posted from him in two weeks. His last post was November 7th. Hope he's doing ok, and I see he's working on a new CC call PureRotation? What's that?

 

Now it's spam

and don't pull target, just follow them. If target neutral it follow indefinitely and changing pull range don't help.
What are wrong?
CLU 338 update recently from svn.

 

Hello again.
I've look in repbrowser and found next:
Affliction.cs revision 811

Code:

public override Composite Pull
{
  get { return this.SingleRotation; }
}

Affliction.cs revision 812

Code:

        public override Composite Pull
        {
            get
            {
                return new PrioritySelector(
                    new DecoratorContinue(ret => Me.CurrentTarget != null && !Me.IsSafelyFacing(Me.CurrentTarget, 45f), new Action(ret => Me.CurrentTarget.Face())),
                    this.SingleRotation);
            }
        }

after i return old string and comment newest pull began working correctly.

 

Running Raid Bot
General - enable move behind target - True
General - enable movement - True
General - enable targeting - True

Bots does not go behind target, am i doing something wrong? How can it be fixed?

 

@Pull Issues: already know, still in progress of rewriting this
@Move behind issue: i don't know how this can be fixed. do u know how cold it is atm?, we don't want u to read every of the 250+ pages, or all of the 2500+ answeres, we only want a log if u have issues!!! that's all, not more, not minor, only a f****** log - can't help u.

@EnhShaman - pvp is dagradt's stuff, he is very busy because of his job, i will take a look if i can fix it .. or give u the option to set it up by yourself (class settings)

RoloTomasi: this is not a solution atm but u can do this easier^^ instead of changing code by hand, right click on the SVN Folder -> Tortoise SVN -> Update to revision (enter the revision you want, hit enter) -> finished, old version is recovered

Please don't change files if u don't know how to use SVN, cause u won't get any updates for changed files in most of the cases.

@Milz: don't worry bout that error
@KCC thanks for checking the code, i double-check the attaching issue, but from the short part i read, u misunderstood the snippet but nice to see, someone is looking that deep into the code. the first part is attaching the Event, the second one is filtering the return values (to be exact, it tries to get a value from the event, if there's no value, we assume that attaching didn't worked)

@cheesybean: reforge everything to mastery or switch your weapon-style from DW to 2H, for raiding DW style ... masterfrost is the current TopDPS from what i could see with simulation craft

 

Sir, yes sir, log is on the way

 

I would also like an answer to this, because if you have say Mogu rune of Paralysis, it will interupt all dps and just stand there trying to spam a green circle on the floor, which it never actually does.

 

Replace / Remove these trinkets
i'm still testing code for this kind of trinkets!

--- update ---

Movement / Pull / Facing should work again

 

I actually ended up digging further into the code(and will probably get in trouble for this) for Lua.Events.AttachEvent and Lua.Events.AddFilter and found the expected behavior to not be the case.

As of HB v2.5.6561.515, AttachEvent sets a value in a Dictionary in the Lua.Events class with a key using the eventName that is passed as as an argument. It then attaches to that event and sets the handler you passed as the second argument up correctly. This all behaves correctly based on expected behavior.

The problem is when you call AddFilter. The first thing AddFilter does is check the Dictionary of events to see if it contains an event with the same name as the eventName argument you passed. If it does, it returns false indicating that it could not attach another filter. This in essence says, if you have already attached to a given event, do not allow additional handlers to be attached. This would not be what I would have expected to be the correct behavior and explains why this always returns false.

 

combat rogue....

my combat rogue is keep trying to use 'slice and dice' beside any other skill

View attachment 4080 2012-11-23 01.08.txt

what's problem? how can i fix it?

 

Just take out trinket usage. Anyone using this to raid with SHOULD use trinkets at certain points anyways to line them up with other CDs, not just use them willy nilly. It truly is a TERRIBLE idea to incorporate trinket usage into an automated CR anyways.......