• Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic

    • YourBuddy MoP BT - A warrior raiding custom routine

    Discussion in 'Archives' started by nomnomnom, Oct 23, 2012.

    Page 9 of 52
    1. Dagradt

      Dagradt Community Developer

      Joined:
      Jul 26, 2010
      Messages:
      1,423
      Likes Received:
      44
      Trophy Points:
      48
      he lives!!!
       
      Dagradt, Nov 30, 2012
      #161
    2. Dagradt

      Dagradt Community Developer

      Joined:
      Jul 26, 2010
      Messages:
      1,423
      Likes Received:
      44
      Trophy Points:
      48
      PM me your Skype info
       
      Dagradt, Nov 30, 2012
      #162
    3. gorunn

      gorunn Member

      Joined:
      Oct 26, 2012
      Messages:
      197
      Likes Received:
      1
      Trophy Points:
      18
      This look good, Nomnom and Dag exchanging Skypes.. Possible coop of two good authors of exceptional CC's?
       
      gorunn, Nov 30, 2012
      #163
    4. Romao

      Romao New Member

      Joined:
      Nov 19, 2012
      Messages:
      82
      Likes Received:
      0
      Trophy Points:
      0
      This would be a great Christmas gift :D
       
      Romao, Nov 30, 2012
      #164
    5. xsilverdicex

      xsilverdicex New Member

      Joined:
      Jan 15, 2010
      Messages:
      1,389
      Likes Received:
      14
      Trophy Points:
      0
      hey, first of all the single target aspect of this CC is amazing, does the job very well except sometime's there is a 2-3 second delay in combat on pulling. Main problem i am having though is the CC never switches to AOE rotation i have it checked in the GUI, and i'm using the talents/glyphs in your popup image. is there anything else i need to do to make it detect multipul mobs?
       
      xsilverdicex, Dec 1, 2012
      #165
    6. nomnomnom

      nomnomnom Well-Known Member

      Joined:
      Feb 18, 2011
      Messages:
      1,506
      Likes Received:
      73
      Trophy Points:
      48
      I tried to reproduce but I could'nt get it to "not work". Keep in mind that there are several very strict rules regarding AoE for fury, and those are implemented.

      I'd suggest to create a fresh install of your Honorbuddy and try again, if you don't want to try that, provide me with your YBMoP Settings file and a logfile of the encounters.

      ========================================

      @ Everyone --> Revision 45 is up on the SVN!
      Rev 45 should pool up rage even better then previous without wasting DPS. It'll get rid of that rage during CS debuff :). Rev42 --> Rev45 gave me a steady 3k dps increase on target dummy (69k to 72k) (Average, did 4 runs with each version with 30m dmg per run).

      If you feel adventurus, feel free to try out the Experimental rotation. It is NOT finished yet though!
       
      Last edited: Dec 1, 2012
      nomnomnom, Dec 1, 2012
      #166
    7. xsilverdicex

      xsilverdicex New Member

      Joined:
      Jan 15, 2010
      Messages:
      1,389
      Likes Received:
      14
      Trophy Points:
      0
      what are the rule's regarding AOE?
       
      xsilverdicex, Dec 1, 2012
      #167
    8. Apoc

      Apoc Moderator Staff Member Moderator

      Joined:
      Jan 16, 2010
      Messages:
      2,790
      Likes Received:
      94
      Trophy Points:
      48
      Checked through some code, here's some fixes for you.

      1) Always check "fast conditionals" first if you use them often. Eg; CanInterrupt in Dependencies.cs. Check your custom setting *first* then check if the target is casting, and can be interrupted. You always want to "fail" as quickly as possible. (A quick boolean comparison is going to be faster than running through the memory wrapping API)

      2) In "CreateCombat" (Main.cs), I'd suggest removing your string comparison code.

      Code:
      new PrioritySelector(ret => Default() && YBMoP_BT_Settings.Instance.cRotSelect == "Standard",
      Change this to an enum if at all possible. String comparisons are slow, and should be avoided if possible. (Considering you have 2 values, I'd suggest just changing it to a bool value and be done with it)

      3) You don't need to check the target's health % when casting Execute. (This is done for you in SpellManager.CanCast. Special conditionals on spells are checked by WoW itself)

      4) Your checks for HS are bad. You may want to change
      Code:
      Cast("Heroic Strike", ret => Me.CurrentRage >= 110 || !TargetHpCheck() && ((DeadlyCalmAura() && Me.CurrentRage >= 30) || (MeColossusSmashAura() && Me.CurrentRage >= 40))),
      To
      Code:
      Cast("Heroic Strike", ret => Me.RagePercent >= 90 || (!TargetHpCheck() && ((DeadlyCalmAura() && Me.CurrentRage >= 30) || (MeColossusSmashAura() && Me.CurrentRage >= 40)))),
      RagePercent >= 90 takes care of the glyph. (I personally don't always use it, so your code will never dump rage with HS for me)

      5) Storm Bolt requirements check... string comparisons, etc. Fix it. (I'd suggest making a switch statement if that's how you want to do it, as it'll be far faster)

      6) I'm not entirely sure why you even check if you have a main hand when using heroic throw. Simply cast it if the user has it enabled. (CanCast will take care of the rest)

      And the rest basically goes without saying. Just make the above suggested optimizations everywhere, and you should be set.
       
      Apoc, Dec 1, 2012
      #168
    9. nomnomnom

      nomnomnom Well-Known Member

      Joined:
      Feb 18, 2011
      Messages:
      1,506
      Likes Received:
      73
      Trophy Points:
      48
      Thanks for looking through and pointing out your concerns. I'll definitely use your advice to improve this CC, thanks!
       
      nomnomnom, Dec 1, 2012
      #169
    10. nomnomnom

      nomnomnom Well-Known Member

      Joined:
      Feb 18, 2011
      Messages:
      1,506
      Likes Received:
      73
      Trophy Points:
      48
      SVN download URL has changed!!!
       
      nomnomnom, Dec 1, 2012
      #170
    11. Pipedreams

      Pipedreams New Member

      Joined:
      Nov 6, 2012
      Messages:
      17
      Likes Received:
      0
      Trophy Points:
      0
      Mobs are set to be counted with u.IsWithinMeleeRange as a condition, which i believe is 5yds, while whirlwind's range is 8yds (unglyphed). That's probably why you are having issues!

      Edit: This is apparently on the fix list for NomNomNom, it should be an easy one, in the meantime, just stand closer to mobs to trigger aoe.
       
      Last edited: Dec 1, 2012
      Pipedreams, Dec 1, 2012
      #171
    12. simplyxz

      simplyxz New Member

      Joined:
      Nov 13, 2012
      Messages:
      9
      Likes Received:
      0
      Trophy Points:
      0
      Is anyone else getting serious FPS lags when using this profile? When running CCs on my DK they all run fine with no FPS lags, this on the other hand is extremely slow in combat.. Any ideas how to fix this?
       
      simplyxz, Dec 1, 2012
      #172
    13. Pipedreams

      Pipedreams New Member

      Joined:
      Nov 6, 2012
      Messages:
      17
      Likes Received:
      0
      Trophy Points:
      0
      What botbase are you using? Lazyraider in raidbot mode is running perfectly for me.
       
      Pipedreams, Dec 1, 2012
      #173
    14. randomstraw

      randomstraw Community Developer

      Joined:
      Jul 17, 2012
      Messages:
      1,611
      Likes Received:
      10
      Trophy Points:
      38
      radibot causes fps lag here, too. but i guess my maschine just can't handle it.

      using this CC with Tyrael @ 200 Ticks = perfect.
       
      randomstraw, Dec 2, 2012
      #174
    15. nomnomnom

      nomnomnom Well-Known Member

      Joined:
      Feb 18, 2011
      Messages:
      1,506
      Likes Received:
      73
      Trophy Points:
      48
      Keep in mind its not 100% Tyrael compatible yet! Working on that :).

      The lag is caused by either AoE or slow pc. Upcoming version will reduce the resource usage of HB, so that will improve it for everyone :).
       
      nomnomnom, Dec 2, 2012
      #175
    16. daorigin

      daorigin New Member

      Joined:
      Feb 12, 2011
      Messages:
      267
      Likes Received:
      1
      Trophy Points:
      0
      i get dps loss with tyrael - i got 3ghz quad with 8gb of ram n 2gb of gpu that isnt a slow pc but i do see a fps loss with raidbot.
       
      daorigin, Dec 2, 2012
      #176
    17. randomstraw

      randomstraw Community Developer

      Joined:
      Jul 17, 2012
      Messages:
      1,611
      Likes Received:
      10
      Trophy Points:
      38
      oh, its not? :D

      whats missing? for me tyrael works way better than raidbot. raidbot gives me lags. :p
       
      randomstraw, Dec 3, 2012
      #177
    18. Romao

      Romao New Member

      Joined:
      Nov 19, 2012
      Messages:
      82
      Likes Received:
      0
      Trophy Points:
      0
      Have you tried Lazyraider? I play with it on raidbot option. And you can adjust the ticks. It works for me. As i dont have a super PC, Raidbot make my game lag alot.
       
      Romao, Dec 3, 2012
      #178
    19. nomnomnom

      nomnomnom Well-Known Member

      Joined:
      Feb 18, 2011
      Messages:
      1,506
      Likes Received:
      73
      Trophy Points:
      48
      The CC might lag for people, as it tries to run as fast as possible. Probaly AoE situations will turn out even worse. I'd still suggest sticking with Raidbot if your PC can handle it, otherwise indeed Lazyrader and adjust the ticks.

      Upcoming version is in the making. Not a major edit, just optimizing most of the code and implementing Apoc's mentioned changes. Also rotational updates ofcourse :). Few more days!

      People are getting ranked on World of Logs with the current rotation.
       
      nomnomnom, Dec 3, 2012
      #179
    20. Romao

      Romao New Member

      Joined:
      Nov 19, 2012
      Messages:
      82
      Likes Received:
      0
      Trophy Points:
      0
      Since the last update in AoE situation my game lag a little even using Lazyraider, i was getting upset cuz i love this routine and currently raiding with it. Even thought of buying a new PC to run it :cool:. But then try Tyrael and it got fine. Clearly in this last update the CC run alot faster, it was a big increase in the DPS.

      This make me anxious to see this excellent routine get some implement by Apoc.

      Indeed!
       
      Romao, Dec 4, 2012
      #180
    Page 9 of 52

    Share This Page