Fpsware Druid: Shapeshifter

Hello,
While running with DungeonBuddy, I was getting quite a few of these exceptions:

It looks like it was happening when something was hitting the tank but he wasn't targeting something.

 

Hopefully he's out and home resting now, but Fpsware was in the hospital due to a possible spider bite. He was extremely sick and in pain, and has been sending messages from his phone from the hospital. If at all possible, could you please attach your entire log file? If it's too large to attach, then right click and send to compressed file, then attach the compressed file. The snippits of logs aren't as helpful as you might think. The log includes settings, versions, bot bases, and other important information that the snippits don't include.

Please attach the complete log, or complete compressed log, and Fpsware will get back to you as soon as he is physically capable of doing so.

Thank you.

 

I can do you one better, and post a fix. The exception was a null reference exception on line 259, which is:

Code:

                        Group.Tanks.FirstOrDefault().CurrentTarget.Target();

4 lines prior, it's validating that Group.Tanks.FirstOrDefault() isn't null, so that can't be the issue. The only possibility is that CurrentTarget is null, which was matching what I observed - my tank had aggro but wasn't targeting anything. The easy fix is to just validate that CurrentTarget isn't null - the better fix is to also introduce a variable for Group.Tanks.FirstOrDefault() instead of calling a LINQ method 3 times for the same value.

The before:

Code:

            if (ClassParser.CCControlledTargeting && (!Me.GotTarget || !Me.CurrentTarget.IsDead))
                if (Me.IsInInstance && Group.Tanks.FirstOrDefault() != null)
                {
                    if (Group.Tanks.FirstOrDefault().Combat)
                    {
                        Group.Tanks.FirstOrDefault().CurrentTarget.Target();
                        Lua.DoString("StartAttack()");
                    }
                }

The after:

Code:

            if (ClassParser.CCControlledTargeting && (!Me.GotTarget || !Me.CurrentTarget.IsDead))
            {
                var firstTank = Group.Tanks.FirstOrDefault();
                if (Me.IsInInstance && firstTank != null)
                {
                    if (firstTank.Combat && firstTank.CurrentTarget != null)
                    {
                        firstTank.CurrentTarget.Target();
                        Lua.DoString("StartAttack()");
                    }
                }
            }

 

What Zeldrak said

Partial log snippets mean nothing, an error message out of context is utterly useless. Take the follow analogy; a guy says "a building just feel over", so everyone rushes to the scene, the police, the ambulance, fire all turn up. Only to find it was a scheduled demolition. So instead of saying "a building feel over" what he should have said (by including the full log file) is "I was walking by and the street was blocked off so I stopped to see the demolition guys on site and I was lucky enough to see a building feel over.

Moral of the story, never attach snippets, always attach the full log file.

 

As a professional .NET developer I can understand where you're coming from, and would have included a full log if it were necessary. An actual null reference exception complete with offending line number is pretty easy to debug, as the 45 seconds I spent debugging it and fixing it goes to show. Were it some sort of bizarre behavioral stuff, e.g. my rotation was messed up, I'd definitely have included a log.

 

Thanks, there are always some welcome exceptions to the rule. I'll add the change as soon as I'm home.

 

Hi, sorry, one question; how can i force the cc to use swift flight form? (i want that he "mounts" in partybot, when the leader mount)

"Mounting: Using Travel Form since we don't have any mounts yet."

 

Swift Flight Form is controlled by HB.

 

Really like the CC. After trying all the others for Guardian I like this one the best!

 

Thanks. Glad its working for you.

 

@fpsware Hope you get better. Living in Europe now in Winter with all this cold, sometimes i wish to be in a warm place like New Zealand, but then i read this... Nevermind...

Btw, love this CC. Leveled my Druid with this and farming nodes now at 90 flawless.

 

Is there anyway to make this cc not to switch back to cat when i "manually" chose bear form.
In some situations i need to go bear but the cc keeps switching back to cat.

 

No. You are Feral Cat spec, and as such the CC wants you to use Cat form.

 

Top notch

 

would be great to add might of ursoc to every specc, not only guardian. would be nice to add swap to bear with lowhealth as feral. (swipe as kitty would be great also)

 

Love thic cc as feral! But at balance it stands to close to target.

 

Just here to say im using a CC from you for the first time (im a new HB user too), with a RAF duo, on a guardian and you GUI is amazing. Really freaking great job there, i love the bars =)

Great job!

 

Balance is standing at the proper distance for me. Its likely you pull range in the questing / grinding profile you are using.

 

Thanks, glad you like it.

 

If I have your Shadow walker Warlock files, is this included..?
Or how can I fix it to have ALL your files?