[Warlock CC] skiWarlock 3.0 for HB2 - ALL TREES -

Trying the latest revision.

EDIT: So far so good. The issue with casting self buffs has been fixed.

And I'd love to code up that whole Life Tap (Rank 1) logic bit, but that's not really in my skillset. But I tweaked my variables around some and turned on Dark Pact... So that's covering things for now it seems.

 

It seems to have an issue with multiple adds now.

Let's say you have two adds... It will just continually cycle between them without casting anything for a while. Then it will start the spell queue on one of them, but then go back to cycling back and forth again.

The key thing that I've noticed is that it is hitting the "Activity: Combat" loop now quite often. Which is when it seems to swap targets. It does this with single target situations, too, but it obviously isn't an issue then.

Code:

[12:45:49 PM:238] ReadLog: [skiWarlock] Warning: There are 2 attackers
[12:45:49 PM:324] ReadLog: [skiWarlock] Combating Adds: 2
[12:45:49 PM:390] ReadLog: [skiWarlock] Add: 1: Target: Alliance Halaani Guard
[12:45:49 PM:442] ReadLog: [skiWarlock] Add: 1: Pet attack: Alliance Halaani Guard
[12:45:49 PM:541] ReadLog: [skiWarlock] Add: 1: Haunt
[12:45:49 PM:601] Spell_C::CastSpell(48181, 0, 0x0, 0)
[12:45:51 PM:721] Took 2138 ms to cast:Haunt
[12:45:51 PM:804] ReadLog: [skiWarlock] Add: 2: Target: Alliance Halaani Guard
[12:45:52 PM:296] ReadLog: [skiWarlock] Add: 2: Pet attack: Alliance Halaani Guard
[12:45:52 PM:489] ReadLog: Activity: Combat
[12:45:52 PM:571] ReadLog: [skiWarlock] Combating Adds: 2
[12:45:52 PM:629] ReadLog: [skiWarlock] Add: 1: Target: Alliance Halaani Guard
[12:45:53 PM:128] ReadLog: [skiWarlock] Add: 1: Pet attack: Alliance Halaani Guard
[12:45:53 PM:238] ReadLog: [skiWarlock] Add: 2: Target: Alliance Halaani Guard
[12:45:53 PM:710] ReadLog: [skiWarlock] Add: 2: Pet attack: Alliance Halaani Guard
[12:45:53 PM:896] ReadLog: Activity: Combat
[12:45:53 PM:986] ReadLog: [skiWarlock] Combating Adds: 2
[12:45:54 PM:40] ReadLog: [skiWarlock] Add: 1: Target: Alliance Halaani Guard
[12:45:54 PM:621] ReadLog: [skiWarlock] Add: 1: Pet attack: Alliance Halaani Guard
[12:45:54 PM:720] ReadLog: [skiWarlock] Add: 2: Target: Alliance Halaani Guard
[12:45:55 PM:203] ReadLog: [skiWarlock] Add: 2: Pet attack: Alliance Halaani Guard
[12:45:55 PM:393] ReadLog: Activity: Combat
[12:45:55 PM:474] ReadLog: [skiWarlock] Combating Adds: 2
[12:45:55 PM:531] ReadLog: [skiWarlock] Add: 1: Target: Alliance Halaani Guard
[12:45:56 PM:8] ReadLog: [skiWarlock] Add: 1: Pet attack: Alliance Halaani Guard
[12:45:56 PM:108] ReadLog: [skiWarlock] Add: 2: Target: Alliance Halaani Guard
[12:45:56 PM:914] ReadLog: [skiWarlock] Add: 2: Pet attack: Alliance Halaani Guard
[12:45:57 PM:117] ReadLog: Activity: Combat
[12:45:57 PM:195] ReadLog: [skiWarlock] Combating Adds: 2
[12:45:57 PM:248] ReadLog: [skiWarlock] Add: 1: Target: Alliance Halaani Guard
[12:45:57 PM:742] ReadLog: [skiWarlock] Add: 1: Pet attack: Alliance Halaani Guard
[12:45:57 PM:857] ReadLog: [skiWarlock] Add: 2: Target: Alliance Halaani Guard
[12:45:58 PM:355] ReadLog: [skiWarlock] Add: 2: Pet attack: Alliance Halaani Guard
[12:45:58 PM:558] ReadLog: Activity: Combat
[12:45:58 PM:632] ReadLog: [skiWarlock] Combating Adds: 2
[12:45:58 PM:695] ReadLog: [skiWarlock] Add: 1: Target: Alliance Halaani Guard
[12:45:59 PM:177] ReadLog: [skiWarlock] Add: 1: Pet attack: Alliance Halaani Guard
[12:45:59 PM:291] ReadLog: [skiWarlock] Add: 2: Target: Alliance Halaani Guard
[12:46:00 PM:85] ReadLog: [skiWarlock] Add: 2: Pet attack: Alliance Halaani Guard
[12:46:00 PM:159] ReadLog: [skiWarlock] Add: 2: Haunt
[12:46:00 PM:204] Spell_C::CastSpell(48181, 0, 0x0, 0)
[12:46:01 PM:914] Took 1716 ms to cast:Haunt
[12:46:02 PM:58] ReadLog: Activity: Combat
[12:46:02 PM:130] ReadLog: [skiWarlock] Combating Adds: 2
[12:46:02 PM:193] ReadLog: [skiWarlock] Add: 1: Target: Alliance Halaani Guard
[12:46:02 PM:247] ReadLog: [skiWarlock] Add: 1: Pet attack: Alliance Halaani Guard
[12:46:02 PM:351] ReadLog: [skiWarlock] Add: 2: Target: Alliance Halaani Guard
[12:46:02 PM:830] ReadLog: [skiWarlock] Add: 2: Pet attack: Alliance Halaani Guard
[12:46:03 PM:26] ReadLog: Activity: Combat
[12:46:03 PM:82] ReadLog: [skiWarlock] Combat: Pet attack: Alliance Halaani Guard
[12:46:03 PM:172] ReadLog: [skiWarlock] Combating Adds: 2
[12:46:03 PM:233] ReadLog: [skiWarlock] Add: 1: Target: Alliance Halaani Guard
[12:46:03 PM:706] ReadLog: [skiWarlock] Add: 1: Pet attack: Alliance Halaani Guard
[12:46:03 PM:804] ReadLog: [skiWarlock] Add: 2: Target: Alliance Halaani Guard
[12:46:04 PM:625] ReadLog: [skiWarlock] Add: 2: Pet attack: Alliance Halaani Guard
[12:46:04 PM:816] ReadLog: Activity: Combat
[12:46:04 PM:891] ReadLog: [skiWarlock] Combating Adds: 2
[12:46:04 PM:954] ReadLog: [skiWarlock] Add: 1: Target: Alliance Halaani Guard
[12:46:05 PM:674] ReadLog: [skiWarlock] Add: 1: Pet attack: Alliance Halaani Guard
[12:46:05 PM:796] ReadLog: [skiWarlock] Add: 2: Target: Alliance Halaani Guard
[12:46:06 PM:502] ReadLog: [skiWarlock] Add: 2: Pet attack: Alliance Halaani Guard
[12:46:06 PM:734] ReadLog: Activity: Combat
[12:46:06 PM:834] ReadLog: [skiWarlock] Combating Adds: 2
[12:46:06 PM:904] ReadLog: [skiWarlock] Add: 1: Target: Alliance Halaani Guard
[12:46:07 PM:714] ReadLog: [skiWarlock] Add: 1: Pet attack: Alliance Halaani Guard
[12:46:07 PM:875] ReadLog: [skiWarlock] Add: 2: Target: Alliance Halaani Guard
[12:46:08 PM:604] ReadLog: [skiWarlock] Add: 2: Pet attack: Alliance Halaani Guard
[12:46:08 PM:821] ReadLog: Activity: Combat
[12:46:08 PM:948] ReadLog: [skiWarlock] Combating Adds: 2
[12:46:09 PM:11] ReadLog: [skiWarlock] Add: 1: Target: Alliance Halaani Guard
[12:46:09 PM:790] ReadLog: [skiWarlock] Add: 1: Pet attack: Alliance Halaani Guard
[12:46:09 PM:895] ReadLog: [skiWarlock] Add: 2: Target: Alliance Halaani Guard
[12:46:10 PM:632] ReadLog: [skiWarlock] Add: 2: Pet attack: Alliance Halaani Guard
[12:46:10 PM:713] ReadLog: [skiWarlock] Add: 2: Haunt
[12:46:10 PM:759] Spell_C::CastSpell(48181, 0, 0x0, 0)
[12:46:12 PM:579] Took 1810 ms to cast:Haunt
[12:46:12 PM:731] ReadLog: Activity: Combat
[12:46:12 PM:816] ReadLog: [skiWarlock] Combating Adds: 2
[12:46:12 PM:868] ReadLog: [skiWarlock] Add: 1: Target: Alliance Halaani Guard
[12:46:13 PM:372] ReadLog: [skiWarlock] Add: 1: Pet attack: Alliance Halaani Guard
[12:46:13 PM:473] ReadLog: [skiWarlock] Add: 2: Target: Alliance Halaani Guard
[12:46:14 PM:202] ReadLog: [skiWarlock] Add: 2: Pet attack: Alliance Halaani Guard
[12:46:14 PM:407] ReadLog: Activity: Combat
[12:46:14 PM:486] ReadLog: [skiWarlock] Combating Adds: 2
[12:46:14 PM:561] ReadLog: [skiWarlock] Add: 1: Target: Alliance Halaani Guard
[12:46:15 PM:292] ReadLog: [skiWarlock] Add: 1: Pet attack: Alliance Halaani Guard
[12:46:15 PM:387] ReadLog: [skiWarlock] Add: 2: Target: Alliance Halaani Guard
[12:46:16 PM:93] ReadLog: [skiWarlock] Add: 2: Pet attack: Alliance Halaani Guard
[12:46:16 PM:300] ReadLog: Activity: Combat
[12:46:16 PM:373] ReadLog: [skiWarlock] Combating Adds: 2
[12:46:16 PM:436] ReadLog: [skiWarlock] Add: 1: Target: Alliance Halaani Guard
[12:46:16 PM:941] ReadLog: [skiWarlock] Add: 1: Pet attack: Alliance Halaani Guard
[12:46:17 PM:39] ReadLog: [skiWarlock] Add: 2: Target: Alliance Halaani Guard
[12:46:17 PM:777] ReadLog: [skiWarlock] Add: 2: Pet attack: Alliance Halaani Guard
[12:46:18 PM:24] ReadLog: Activity: Combat
[12:46:18 PM:120] ReadLog: [skiWarlock] Combating Adds: 2
[12:46:18 PM:183] ReadLog: [skiWarlock] Add: 1: Target: Alliance Halaani Guard
[12:46:18 PM:994] ReadLog: [skiWarlock] Add: 1: Pet attack: Alliance Halaani Guard
[12:46:19 PM:154] ReadLog: [skiWarlock] Add: 2: Target: Alliance Halaani Guard
[12:46:19 PM:883] ReadLog: [skiWarlock] Add: 2: Pet attack: Alliance Halaani Guard
[12:46:20 PM:109] ReadLog: Activity: Combat
[12:46:20 PM:171] ReadLog: [skiWarlock] Combat: Health Funnel
[12:46:20 PM:224] Spell_C::CastSpell(27259, 0, 0x0, 0)
[12:46:21 PM:721] Took 1514 ms to cast:Health Funnel
[12:46:21 PM:960] ReadLog: [skiWarlock] Funneling!
[12:46:25 PM:0] ReadLog: [skiWarlock] Funneling finished. Pet Health: 33%
[12:46:25 PM:45] ReadLog: [skiWarlock] Combat: This target is a bugged mob.  Blacklisting for 1 hour
[12:46:25 PM:265] ReadLog: Activity: Combat
[12:46:25 PM:311] ReadLog: [skiWarlock] Combating Adds: 2
[12:46:25 PM:355] ReadLog: [skiWarlock] Add: 1: Target: Alliance Halaani Guard
[12:46:25 PM:811] ReadLog: [skiWarlock] Add: 1: Pet attack: Alliance Halaani Guard
[12:46:25 PM:899] ReadLog: [skiWarlock] Add: 2: Target: Alliance Halaani Guard
[12:46:26 PM:744] ReadLog: [skiWarlock] Add: 2: Pet attack: Alliance Halaani Guard
[12:46:26 PM:976] ReadLog: Activity: Combat

There's no reason it should take 10 seconds for it to decide what to do with 2 targets.

An example of the "Activity: Combat" coming up a lot on a single target:

Code:

[1:11:36 PM:31] ReadLog: [skiWarlock] Combat: Pet attack: Storm Rager
[1:11:36 PM:213] ReadLog: [skiWarlock] Combat: Affliction: Haunt
[1:11:36 PM:240] Spell_C::CastSpell(48181, 0, 0x0, 0)
[1:11:37 PM:931] Took 1716 ms to cast:Haunt
[1:11:38 PM:44] ReadLog: Activity: Combat
[1:11:38 PM:49] ReadLog: [skiWarlock] Warning: There are 1 attackers
[1:11:38 PM:52] ReadLog: [skiWarlock] Combat: Pet attack: Storm Rager
[1:11:38 PM:252] ReadLog: [skiWarlock] Combat: Affliction: Corruption
[1:11:38 PM:305] Spell_C::CastSpell(27216, 0, 0x0, 0)
[1:11:39 PM:784] Took 1498 ms to cast:Corruption
[1:11:39 PM:898] ReadLog: Activity: Combat
[1:11:40 PM:83] ReadLog: [skiWarlock] Combat: Affliction: Curse of Agony
[1:11:40 PM:123] Spell_C::CastSpell(27218, 0, 0x0, 0)
[1:11:41 PM:164] Took 1060 ms to cast:Curse of Agony
[1:11:41 PM:279] ReadLog: Activity: Combat
[1:11:41 PM:537] ReadLog: [skiWarlock] Combat: Affliction: Unstable Affliction
[1:11:41 PM:575] Spell_C::CastSpell(30404, 0, 0x0, 0)
[1:11:43 PM:929] Took 2372 ms to cast:Unstable Affliction
[1:11:44 PM:42] ReadLog: Activity: Combat
[1:11:44 PM:303] ReadLog: [skiWarlock] Combat: Affliction: Shadow Bolt
[1:11:44 PM:332] Spell_C::CastSpell(25307, 0, 0x0, 0)
[1:11:47 PM:621] Took 3307 ms to cast:Shadow Bolt

 

It doesn't seem to want to use the Soulstone when dead option anymore. It'll automatically just release from corpse and do the run back from the GY. Nothing in the debug log shows any sort of decision on the subject.

I thought it was doing it on purpose before when I died as there were plenty of aggro critters around the corpse. But not being able to set up a situation where I'd die to yellow critters that would immediately de-aggro. There is something fishy going on here.

 

And the hits keep on coming!
Ski & Thedrunk (lol sounds like a 70s rock band) keep up the good work

 

great to have this updated, however i immediatly found a gamebreaking (in bgs) flaw as it will try to make a spellstone in the beginning of the bg even though you already have one in your inventory in an endless loop. I will keep testing and see if this was a one time thing or something that happens every time

 

I seen this behavior with a Healthstone. It kept summoning a Healthstone even though there was one in inventory (and it got the error saying as such). I would delete the Healthstone and it would work fine for a single combat, then it would summon a new Healthstone... then keep doing it.

 

I am having quite the time with the profile located here: http://www.buddyforum.de/showthread.php?5550-Rewrite-Dwarf-1-60-Questing

Using this build 3.63... Running HB 1.9.9.5... It seems to die a lot around Thundering Exiles out in Arathi Basin with a 38 Warlock fully geared with Heirlooms...

Seems to not really target anything properly and start combat sequence. Kinda like it's dumb...

Or I am just dumb and doing something wrong, which I am willing to admit... but I can't quite put my finger on why...

Any ideas?

 

If anyone would like to post up their spec Settings Profile xml file, i would be happy to include them.

 

Need a log please

HB handles rezing... it seems they have changed something in the core code.

Please post your whole log as an attachment. I need to see if its Fighting Adds and using AOE.

From looking at the code im guessing:
You have Haunt. You dont have Seed of Corruption. You dont have Shadowfury. You dont have Metamorphosis.

Try 3.64 - i have made adjustments to the FightAddsWithAOE detection code

Anyone reporting bugs, please post your debug log as an attachment.
It helps a lot to see what variables are being initialized, spells being used etc

 

You are correct. Affliction only has Rain of Fire as an AE until level 70 when we get Seed of Corruption.

I'll try this out later tonight

EDIT: I don't see 3.64, only 3.63.

Since you can't edit the original post (since you're not ski) can you just post the latest version in a new post in the thread each time you update? Makes it easier for new people to get the latest version without having to dig back through a few pages.

 

skiWarlock v3.65
Updated: Rewrote Soulstone/Spellstone/Firestone code - this should fix the outstanding issues related to these items
Fixed: When low on health/mana and you have no food/water spam
Fixed: Bug that would cause the bot to stale and do nothing if you did not have a pet alive and were in combat - lots of extra Me.GotAlivePet checks added
Added: In combat Pet Summon for Demonolgy when Fel Domination is up
Updated: Rewrote Sould Shard count code - uses HB internal data instead of LUA
Fixed: GUI label updates more frequently

Extra
Check UseSecondaryTalentSpecForPVP in Global Config file. Code is untested - let me know if it works!

Bugs
CombatAdds: If all targets have AOE spells on them, the bot will switch between the adds rapidly looking to cast a spell on - this is working as intended, we just need to give it something else to do when this occurs

skiWarlock v3.64
Added: Pull with Life Tap (Rank 1) setting
Fixed: Disable FightAddsWithAOE detection code updated - for lower level locks without good AOE
Fixed: A bug that caused non Default Setting Profiles from being loaded automatically

 

great to see this, will test right now.
love the gui.

 

my minimum soul shards is set to 5, but he keeps filling my bag up.

 

Log please. Is it trying to delete them?

 

Something that should be tweaked,

When pulling if you hp is lower it will chain cast drain life... it should drain, dot, drain. Currently it will drain, drain, dot.

 

Tweak the variables to get more regeneration or something similar.

 

it was not trying to delete them, just let them stack up.
it also used my imp after i died even tho i had filled my bags up with shards.

 

A Warlock has DoTs even if it isn't spec'd Affliction. Since they have no cast time (and just trigger the GCD), how about if it gets to this point it just starts lobbing DoTs?

The Pull with LT seems to work. If the buff isn't up then it just goes through the loop like normal. Although it doesn't account for the GCD sometimes when it does cast it. So it'll cast the LT, immediately try to cast Haunt... Fail... Then cast Haunt once the GCD finishes.

So far when I've tried to force multiple mobs on the bot it handles them like the older 3.0 version where it'll cross DoT, etc, each of them based on some sort of internal priority (at least that's what it looks like). So that's a good thing.

 

Heh... I'm actually burning through things fast enough now that the bot is needing to use Health Funnel to keep the pet's health up as there's been effectively zero downtime between mobs. Going from 67 to 68 doubled the XP I'm getting per hour. Which is impressive as my DPS didn't go up by that much (even with the new spells).

 

It does not make new soulshards in pvp but prefers to play with imp as demonology, which is a slight concern.