• Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • CLU (Codified Likeness Utility)

    Discussion in 'Archives' started by wulf, Feb 18, 2012.

    Thread Status:
    Not open for further replies.
    1. wulf

      wulf Community Developer

      Joined:
      Dec 29, 2010
      Messages:
      1,832
      Likes Received:
      128
      Trophy Points:
      63
      Good pickup, I forgot to put an OR rather than an AND for wild growth or rejuv not ticking on the target.

      PHP:
      Spells.CastSpell("Nourish"=> Me.CurrentTarget.HealthPercent < (Me.IsInRaid 50 95) && !Buff.TargetHasBuff("Wild Growth") && !Buff.TargetHasBuff("Rejuvenation"), "Nourish (Single)")
      Should be:
      PHP:
      Spells.CastSpell("Nourish"=> Me.CurrentTarget.HealthPercent < (Me.IsInRaid 50 95) && (!Buff.TargetHasBuff("Wild Growth") || !Buff.TargetHasBuff("Rejuvenation")), "Nourish (Single)")
      Because...why nourish when we have HoT's ticking...

      Ahhh...I forgot about Harmony...thanks Venus112. I will make changes tonight...Looks like resto is going to get some love now :D
       
      Last edited: Jun 26, 2012
    2. Venus112

      Venus112 New Member

      Joined:
      Jun 17, 2010
      Messages:
      1,509
      Likes Received:
      13
      Trophy Points:
      0
      Just good it was caught, eh? :)

      Going to test your Disc CC now, non-AA build.

      Let's see how it goes
       
    3. Ama

      Ama New Member

      Joined:
      Jun 6, 2011
      Messages:
      1,171
      Likes Received:
      33
      Trophy Points:
      0
      I've been messing around with your Disc rotation. I won't post what I have, b/c its not perfect. :p ... But I think what your healing CCs are lacking is aggro detection. I usually use it to determine who to shield/renew. It's also pretty good for determining the active tank.

      These may be helpful. I prefer an aggo check on use rather than the list, but I noticed you have a lot of lists in you cc.

      PHP:
      public static IEnumerable<WoWUnitAggroed 
             
      get 
             
      {
                 var 
      hostiles ObjectManager.GetObjectsOfType<WoWUnit>(truetrue).Where(=> u.IsAlive && u.IsTargetingMyPartyMember && !u.IsFriendly && u.Combat).ToList();
                 var 
      aggroed = new List<WoWUnit>();

                 foreach (
      WoWUnit ahole in hostiles)
                 {
                     if (!
      aggroed.Any(=> x.Guid == ahole.CurrentTarget.Guid))
                         
      aggroed.Add(ahole.CurrentTarget);
                 }
                 return 
      aggroed
             } 
         }
      }

      public static 
      bool PlayerAggroed(WoWPlayer p)
      {
           var 
      hostiles ObjectManager.GetObjectsOfType<WoWUnit>(truetrue).Where(=> u.IsAlive && u.IsTargetingMyPartyMember && !u.IsFriendly && u.Combat).ToList();
           return 
      hostiles.Any(=> x.CurrentTarget.Guid == p.Guid);
      }
       
    4. wulf

      wulf Community Developer

      Joined:
      Dec 29, 2010
      Messages:
      1,832
      Likes Received:
      128
      Trophy Points:
      63
      Ama, thanks for the code! Maybe we could simplify it within the rotation like this. (I am at work so it may need tweaking)

      PHP:
                          // Put a shield || renew on a group member that has high threat
                          
      Healer.FindRaidMember(=> true=> !x.Dead && x.CurrentTarget.ThreatInfo.RawPercent 90 && !x.isTank, (ab) => (int)(a.CurrentHealth b.CurrentHealth),
                              
      Spells.CastSpell("Power Word: Shield"=> CanShield && !Buff.TargetHasBuff("Power Word: Shield"), "Shield (High threat!)"),
                              
      Spells.CastSpell("Renew"=> !Buff.TargetHasBuff("Renew"), "Renew (High threat!)")
                          ),
      The code above is reliant on me creating the internal bool isTank that will include or exclude the tanks depending on what you want (see above example).

      it works/looks like this.
      Healer.FindRaidMember(Condition to be true before we do anything else, filter the list of players, perform a comparison on them ie: maxhealth or current health or max mana),
      // all done we have found and targeted a player lets attempt to throw a spell on them.
      PrioritySelector(
      Spells.CastSpell("Power Word: Shield", a => CanShield && !Buff.TargetHasBuff("Power Word: Shield"), "Shield (High threat!)"),
      Spells.CastSpell("Renew", a => !Buff.TargetHasBuff("Renew"), "Renew (High threat!)"))
       
      Last edited: Jun 26, 2012
    5. Ama

      Ama New Member

      Joined:
      Jun 6, 2011
      Messages:
      1,171
      Likes Received:
      33
      Trophy Points:
      0
      Yeah, I didn't know there was a such thing as ThreatInfo.RawPercent. :)
       
    6. Soeski

      Soeski Member

      Joined:
      Jan 15, 2010
      Messages:
      971
      Likes Received:
      2
      Trophy Points:
      18
      Wulf, Ama, I like your CC's very much and use them both, they complement eachother nicely. But seeing this thread makes me realise you're in the process of making the same Disc AA/Non-AA healing CC. Actually helping out eachother on creating the best and most effective CC's. Your powers/knowledge combined will definately make the best CC around I guess.
      If you keep your CC seperated but for 99% the same, how would I know which one to use? :)
      In short, why don't you guys combine forces even more and create one Uber CC?
       
    7. weischbier

      weischbier Guest

      "To whom much has been given, much will be expected"
       
    8. Soeski

      Soeski Member

      Joined:
      Jan 15, 2010
      Messages:
      971
      Likes Received:
      2
      Trophy Points:
      18
      Right... Luke 12:48b :)
      So you're gonna get involved too? Nice :p
       
    9. Ama

      Ama New Member

      Joined:
      Jun 6, 2011
      Messages:
      1,171
      Likes Received:
      33
      Trophy Points:
      0
      For dps/tank IMO, CLU is the best cc on here. Healing is a little different though. I don't think any of the all-in-one CCs quite nail it. I made NoobRage so the average dude could make a CC if he wishes. I did the healing classes b/c I love healing. Disc/AA especially :)

      I have a good feeling that CLU will get healing down, Wulf has done a lot of really great work. It isn't easy to write classes that you haven't played. I still don't know what a shaman or a druid are.
       
    10. hbaioni

      hbaioni New Member

      Joined:
      Oct 17, 2011
      Messages:
      299
      Likes Received:
      1
      Trophy Points:
      0
      Wulf, I tested your CC (Disc Priest) and here's the results: In heroics, it worked fine. I noticed however, that it is a little slow to react, compared to other classes. It lets the players lose health, while other classes heal more proactively. In peroth'arn, the boss that leaves the entire party at 25%, it should have used Divine Hymn, however, it did not, I had to do it manually. I was able to complete the dungeon, with these minor problems.
      Now... when i tried it in Raid Finder... well, it was a different story. My healing wasn't good. I was the last in recount... I healed for 8k, a very, very low percentage. The best healer in the raid healed for 20k+, so, it was a huge difference. Moreover, the toon seemed to remain idle for a very, very long time... At one moment, one of the raid members asked: "Priest AFK??????" I had to answer him that i was having heavy lag... I'm sorry, but it doesn't heal like a raid healer would... I'm currently using noobrage's holy CC, and it always places me in the first or second place, but more important, it heals a lot, you can see the toon healing all the time... The only problem with that class is that is very inefficient in terms of mana handling... I really like how your class manages mana, but the HPS is below what someone would expect...
       
    11. amputations

      amputations Active Member

      Joined:
      Jan 6, 2011
      Messages:
      2,262
      Likes Received:
      11
      Trophy Points:
      38
    12. Soeski

      Soeski Member

      Joined:
      Jan 15, 2010
      Messages:
      971
      Likes Received:
      2
      Trophy Points:
      18
      I notice the idle'ing also, sometimes. Every time that happens, I do not have a target. (For AA healing, that is). Without a target, the CC only heals now and then and can not use Smite/Holy Fire. As soon as I hit TAB, the healing starts again. Without a target, the CC let's the group members drop to 80% or lower before doing anything.
      Also funny you mention Peroth'arn, I noticed exactly the same thing. Didn't use Divine Hymn, but instead tried healing everyone one by one. I also lost a DPS on that fight, CC let him die.
      Haven't tried it with 2.6.9 though, this was 2.6.8.
       
    13. hbaioni

      hbaioni New Member

      Joined:
      Oct 17, 2011
      Messages:
      299
      Likes Received:
      1
      Trophy Points:
      0
      Ok, here's my gear:
      Level 85 Tauren Priest | WoW World of Warcraft Armory Profiles | Masked Armory

      I re-specced to holy, but the gear is the same for both specs. You will all agree that you can't heal for 8k with this gear... By the way, this happens only with Wulf's CC, Ama's CC is good in terms of HPS, but the mana management is bad... I agree with the idea of both of them working together to create a good Healing Priest CC. I'm thinking of something like ShamWoW in terms of HPS and Mana Management... That would be just perfect...
       
    14. myslex

      myslex Member

      Joined:
      Apr 1, 2010
      Messages:
      36
      Likes Received:
      0
      Trophy Points:
      6
      Ah yes, this feature is enabled. Movement is working as intended. However, I think I should add that im using this CC farming low level mobs, and still it does not automatically target/attack these unless targeted _BY_ them, or _manually_ targeted by me..
       
    15. Ama

      Ama New Member

      Joined:
      Jun 6, 2011
      Messages:
      1,171
      Likes Received:
      33
      Trophy Points:
      0
      The only thing is... This isn't my project and I don't know too much about how CLU works. I'm mostly studying to get an feel of treesharp so I can make swtor noobrage. But I am playing around with it. If I come up with any improvements, I will surely send them Wulf's way.
       
    16. hbaioni

      hbaioni New Member

      Joined:
      Oct 17, 2011
      Messages:
      299
      Likes Received:
      1
      Trophy Points:
      0
      Well, I think the community means that both of you could improve your CCs taking on consideration the strengths and weaknesses of the two CCs... Wulf's CC lacks of good hps, and yours lacks of good mana management... we're suggesting that perhaps one could implement what the other has... You could improve NoobRage and Wulf could improve CLU.
       
    17. Sippinhaterade

      Sippinhaterade Member

      Joined:
      Jul 10, 2011
      Messages:
      387
      Likes Received:
      2
      Trophy Points:
      18
      I am still have serious issues with the priest CC. Disc(AA) works most of the time using Lazyrider but NEVER Raidbot. It will be working fine for an entire run then it will stop working all together. I cant even begin to get Holy working.

      Could it be a gear issue? I am sitting at 371 on this guy.
       

      Attached Files:

      Last edited: Jun 27, 2012
    18. Thunderage

      Thunderage New Member

      Joined:
      Jan 13, 2011
      Messages:
      84
      Likes Received:
      0
      Trophy Points:
      0
      I get this same problem...
       
    19. wulf

      wulf Community Developer

      Joined:
      Dec 29, 2010
      Messages:
      1,832
      Likes Received:
      128
      Trophy Points:
      63
      Raid bot will not work - well my linked version wont - as it does not have Restbehaviour compisite..in short use lazyraider until i can patch Raidbot to use Res...wtf....wait...there is a HealBehavior!

      Ok guys I think I see some issues...I am using Restbehavior to Heal out of combat, and Combatbehavior to heal during combat...but now I see a Healbehavior..I must investigate..until then use lazyraider for healing.



      A note about how CLU heals...I understand about proactive healing but if you look at CLU's overhealing its leaps and bounds less than other healers playing the game (maybe not other CC's)..after there mana runs out, who starts healing the rest of the raid ;)

      what im trying to say is..lets not create a CC to mimmick OTT players with uber gear that can splash prayer of mending on cooldown for the entire raid, but lets create a CC that will heal....when healing is needed..with a splash of pro-active healing sprinkled in.

      CLU is more than capable of robbing your mana and topping the charts as that is what was happing originally with CLU..after the "general" healing abilitie is in place I will add GUI options for you to tweak each individual heal..maybe put in a slider that will populate preset values for "Im a scrooge on mana" to " I want the FULL AFFECT BABY! drain my mana!"


      Off to work again....next week full of coding CLU!
       
      Last edited: Jun 27, 2012
    20. Soeski

      Soeski Member

      Joined:
      Jan 15, 2010
      Messages:
      971
      Likes Received:
      2
      Trophy Points:
      18
      Hey Wulf,
      Disc CC AA is working quite nice now! No idle'ing anymore, healing quite fast and efficient. Still go OOM quite fast in LFR, but ok. In Heroics things go better and better.
      Questions though. I now see you're using renew while moving, I assumed Renew was not in Disc AA at all? You put it in somewhere now? :)
      Second: Where did you leave Fade? Getting raped sometimes by adds, it shields me, tries to heal me, but never fades. Please put it (back) in :)
      Resto Druid not tested yet, bed time again (1:21am).
       
    Thread Status:
    Not open for further replies.

    Share This Page