Singular Arms modified for PvP, working with new HB

Because the old arms CC for PvP, which i downloaded from here, now stopped working, i've decided to modify new Singular to PvP situations. I'm actually don't know language used in CCs, so i've just edited existing one using my head and basic programming skills.

Here changes what i did:

• Added using of slows (will prefer Piercing Howl if learned, otherwise Hamstring)
• Added using of defensive cooldowns (Demoralizing Banner on 40%, Enraged Regeneration on 35%, Rallying Cry on 30%, Die by the Sword and Disarm on 25% [last ones not simultaneously])
• Removed restrictions of Avatar and Bloodbath to be used only on bosses, Skull Banner now will be used only in combo with Recklessness
• Shockwave moved from AoE rotation to normal, target requirement reduced to 1; Shockwave and Storm Bolt will not be casted if target is already stunned
• Dragon Roar removed from AoE rotation, deleted radius check (will cast only if target in melee radius, to prevent wasting it on pets or in middle of charge)
• Added Shattering Throw if target is in bubble/bop/iceblock (not tested much, but should works)
• Moved Berserker Rage to defensive (will use it to break fear, not tested much too)
• Added Intimidating Shout to AoE rotation
• Execute\nonExecute situations merged into one (dunno why there was two almost identically pieces of code, HS with 3+ stacks of TFB is anyway better than Execute)
• Removed requirement of CS debuff for Slam (for what else to dump rage, if already >60%?)
• Moved Whirlwind down in priority list for AoE (almost useless in PvP, but still better than Overpower IMO)

It still doesn't support Shield Wall, tier 5 talents and immobilizing shout (or how that t3 left ability named), also i didn't touch Bladestorm (still in AoE), because it requires too many checks for breaking roots etc. Please notice, by adding decent amount of buff\debuff checking in code it'll result in unavoidable perfomance reduction, and i don't know how to optimize for lags reduction. On my Core2Duo PC bot constantly freezes in battle, but it freezes same with default Singular whatever All credits goes to original CC creator Apoc, as it says in code comments.

Attention! This one was modified for PvP random Battlegrounds, so using it in PvE behavior or other may result in reduced DPS instead of original CC, but i've tried to not change much in "PvE section" (well, i'm sure tanks will be mad if it fears packs )

To install it, just download arms.cs and place it in ...\<Honorbuddy folder>\Routines\Singular\ClassSpecific\Warrior\
If you want to keep old CC, just rename existing there arms.cs into something, then copy this one.

View attachment Arms.cs

Feel free to comment or optimize it, my first time postin as you can see

PS english is not my native, sorry for mistakes...

PS2 would be nice, if someone will tell how to add using of Safeguard to nearest ally if rooted\immobilized

EDIT: it having problem with detecting priests fears for berserker rage, please help if someone can, i'm trying to fix but nothing simple works...

Changed Sections:
Buffs:

Code:

Spell.BuffSelf("Battle Stance"),                 
Spell.BuffSelf("Die by the Sword", ret => Me.HealthPercent <= 25),
Spell.BuffSelf("Rallying Cry", ret => Me.HealthPercent <= 30),
Spell.BuffSelf("Enraged Regeneration", ret => Me.HealthPercent <= 35 && (Me.ActiveAuras.ContainsKey("Enrage") || StyxWoW.Me.RagePercent >= 60)),
Spell.CastOnGround("Demoralizing Banner", ctx => StyxWoW.Me.Location, ret => Me.HealthPercent <= 40 && !Me.ActiveAuras.ContainsKey("Skull Banner")),
Spell.BuffSelf("Recklessness", ret => (Me.CurrentTarget.IsBoss || SingularRoutine.CurrentWoWContext != WoWContext.Instances) && Me.CurrentTarget.IsWithinMeleeRange ),
Spell.BuffSelf("Skull Banner", ret => Me.ActiveAuras.ContainsKey("Recklessness") ),
Spell.BuffSelf("Avatar", ret => (Me.CurrentTarget.IsBoss || SingularRoutine.CurrentWoWContext != WoWContext.Instances) && Me.CurrentTarget.IsWithinMeleeRange ),
Spell.BuffSelf("Bloodbath", ret => (Me.CurrentTarget.IsBoss || SingularRoutine.CurrentWoWContext != WoWContext.Instances) && Me.CurrentTarget.IsWithinMeleeRange ),
Spell.BuffSelf("Berserker Rage", ret => Unit.HasAuraWithMechanic(StyxWoW.Me, WoWSpellMechanic.Horrified, WoWSpellMechanic.Fleeing))

Normal rotation:

Code:

// Only drop DC if we need to use HS for TFB. This lets us avoid breaking HS as a rage dump, when we don't want it to be one.
new Throttle( Spell.Cast("Deadly Calm", ret => NeedTasteForBloodDump)),
new Throttle( Spell.Cast("Heroic Strike", ret => NeedHeroicStrikeDump)),
Spell.Cast("Shattering Throw", ret => StyxWoW.Me.RagePercent >= 25 && Unit.HasAuraWithMechanic(StyxWoW.Me.CurrentTarget, WoWSpellMechanic.Invulnerable, WoWSpellMechanic.Invulnerable2)),
Spell.Cast("Piercing Howl", ret => Me.CurrentTarget.IsPlayer && SpellManager.CanCast("Piercing Howl") && !StyxWoW.Me.CurrentTarget.HasAura("Piercing Howl") && Me.CurrentTarget.Distance <= 15),
Spell.Cast("Hamstring", ret => Me.CurrentTarget.IsPlayer && !SpellManager.CanCast("Piercing Howl") && !StyxWoW.Me.CurrentTarget.HasAura("Hamstring")),
Spell.Cast("Disarm", ret => Me.HealthPercent <= 24 && !Me.ActiveAuras.ContainsKey("Die by the Sword")),
Spell.Cast("Colossus Smash", ret => !StyxWoW.Me.CurrentTarget.HasAura("Colossus Smash")),
Spell.Cast("Execute", ret => StyxWoW.Me.CurrentTarget.HealthPercent <= 20),
Spell.Cast("Mortal Strike"),
Spell.Cast("Dragon Roar", ret => (Me.CurrentTarget.IsBoss || SingularRoutine.CurrentWoWContext != WoWContext.Instances) && Me.CurrentTarget.IsWithinMeleeRange),
Spell.Cast("Shockwave", ret => Me.CurrentTarget.IsWithinMeleeRange && !Unit.HasAuraWithMechanic(StyxWoW.Me.CurrentTarget, WoWSpellMechanic.Stunned)),
Spell.Cast("Storm Bolt", ret => !Unit.HasAuraWithMechanic(StyxWoW.Me.CurrentTarget, WoWSpellMechanic.Stunned)),
Spell.Cast("Overpower"),
Spell.Cast("Slam", ret => StyxWoW.Me.RagePercent >= 60)

AoE rotation:

Code:

Spell.Cast("Thunder Clap"),
Spell.Cast("Intimidating Shout", ret => Me.CurrentTarget.Distance <= 8),
Spell.Cast("Bladestorm", ret => aoeCount(ret) >= 3),
Spell.Cast("Mortal Strike"),
Spell.Cast("Colossus Smash", ret => !StyxWoW.Me.CurrentTarget.HasMyAura("Colossus Smash")),
Spell.Cast("Whirlwind"),
Spell.Cast("Overpower")

 

This CC working great for meI used for Pvp and Grinding Perfekt.......!
I hope you can do this for Fury too??

 

Hey, could you add option to disable burst? i dont like when it bursts as soon as i go in combat?

 

It bursts when target is in melee range, or if in dungeons then only on bosses. Because of different CDs for all bursts, it pops all at once only in first encounter. If you want to disable bursts just open ARMS.CS with your notepad, find these lines and delete it. (save copy of existing file, if you'll want to revert)

Code:

Spell.BuffSelf("Recklessness", ret => (Me.CurrentTarget.IsBoss || SingularRoutine.CurrentWoWContext != WoWContext.Instances) && Me.CurrentTarget.IsWithinMeleeRange ),
Spell.BuffSelf("Skull Banner", ret => Me.ActiveAuras.ContainsKey("Recklessness") ),
Spell.BuffSelf("Avatar", ret => (Me.CurrentTarget.IsBoss || SingularRoutine.CurrentWoWContext != WoWContext.Instances) && Me.CurrentTarget.IsWithinMeleeRange ),
Spell.BuffSelf("Bloodbath", ret => (Me.CurrentTarget.IsBoss || SingularRoutine.CurrentWoWContext != WoWContext.Instances) && Me.CurrentTarget.IsWithinMeleeRange ),

EDIT: or if you want to use bursts only on bosses and PvP replace current lines with these (Bloodbath still by CD):

Code:

Spell.BuffSelf("Recklessness", ret => (Me.CurrentTarget.IsBoss || Me.CurrentTarget.IsPlayer) && Me.CurrentTarget.IsWithinMeleeRange ),
Spell.BuffSelf("Skull Banner", ret => Me.ActiveAuras.ContainsKey("Recklessness") ),
Spell.BuffSelf("Avatar", ret => (Me.CurrentTarget.IsBoss || Me.CurrentTarget.IsPlayer) && Me.CurrentTarget.IsWithinMeleeRange ),
Spell.BuffSelf("Bloodbath", ret => Me.CurrentTarget.IsWithinMeleeRange ),
// Bloodbath used by cd

 

I can do same for Fury, but first i wanna solve all problems with Arms one

 

Hello. I tried to use your cc, but I get the following error messages:

Reloading AssemblyLoader<ICombatRoutine> - [RoutineManager] ReloadRoutineAssemblies called.
Compiler Error: d:\HBpvp\Routines\Singular\ClassSpecific\Warrior\Arms.cs(62,35) : error CS0117: "Singular.ClassSpecific.Warrior.Common" enth?lt keine Definition f?r "SelectedShout".
Compiler Error: d:\HBpvp\Routines\Singular\ClassSpecific\Warrior\Arms.cs(64,24) : error CS0117: "Singular.ClassSpecific.Warrior.Common" enth?lt keine Definition f?r "CreateChargeBehavior".
Compiler Error: d:\HBpvp\Routines\Singular\ClassSpecific\Warrior\Arms.cs(78,24) : error CS0246: Der Typ- oder Namespacename "Throttle" konnte nicht gefunden werden. (Fehlt eine Using-Direktive oder ein Assemblyverweis?)
Compiler Error: d:\HBpvp\Routines\Singular\ClassSpecific\Warrior\Arms.cs(116,29) : error CS0246: Der Typ- oder Namespacename "Throttle" konnte nicht gefunden werden. (Fehlt eine Using-Direktive oder ein Assemblyverweis?)
Compiler Error: d:\HBpvp\Routines\Singular\ClassSpecific\Warrior\Arms.cs(132,37) : error CS0246: Der Typ- oder Namespacename "Throttle" konnte nicht gefunden werden. (Fehlt eine Using-Direktive oder ein Assemblyverweis?)
Compiler Error: d:\HBpvp\Routines\Singular\ClassSpecific\Warrior\Arms.cs(133,37) : error CS0246: Der Typ- oder Namespacename "Throttle" konnte nicht gefunden werden. (Fehlt eine Using-Direktive oder ein Assemblyverweis?)
Compiler Error: d:\HBpvp\Routines\Singular\ClassSpecific\Warrior\Arms.cs(152,32) : error CS0117: "Singular.ClassSpecific.Warrior.Common" enth?lt keine Definition f?r "CreateChargeBehavior".
Compiler Error: d:\HBpvp\Routines\Singular\ClassSpecific\Warrior\Arms.cs(281,24) : error CS0246: Der Typ- oder Namespacename "ThrottlePasses" konnte nicht gefunden werden. (Fehlt eine Using-Direktive oder ein Assemblyverweis?)

As you can see, I use the German client. maybe thats the problem.

 

not using beserker rage when feared

 

what about mass shild reflect??

 

This one doesn't work also i get this message "This profile does not contain any profiles fitting the character!
Bot Stopped! Reason: This profile does not contain any profiles fitting the character!

 

Ok! It does work,i wasn't paying attention and had it on combat bot,duh on me.....

 

Could you please update this one for new HB ?

 

Hey guys i have updated this to work with the new HB and i also made some slight changes to make this CC better, one of them is that it now default uses defensive stance. In pvp IMO defensive stance is the best out of the 3 unless you need to swap for using something like shields and spell reflect but i do this manual. I may update and add more to this CC at a later date.

 

Hello, this CC for Singular is not good for me. File is corrupt!

 

Oh nice... this updated Yeha

 

'Singular.Settings.SingularSettings.Warrior' cannot be used like a method.

gotten a error when using your version.

 

I'm having this same issue