First, thanks for continuing the updates. I've been testing the ninja routine pretty extensively over the past several weeks, and there's some minor or situational tweaks I think might help optimize dps. The two most important to me are narrowing TA arc and refreshing Huton when there's no target, although I'm probably skewed towards a raid perspective. None of these are major, and the routine as it is certainly works extremely well.
Suiton still doublecasts. I believe that although !Core.Me.HasAura("Suiton") was added as a condition to Suiton,
Code:
(SATATimer.Cooldown.TotalMilliseconds >= 1000 || !settings.UseSuiton || Core.Me.ClassLevel <= 45 || (Core.Me.HasAura("Kassatsu") && !settings.KassatsuSuiton)
in Raiton conditions still returns false, so ninjutsu state never changes. Changing it to
Code:
(SATATimer.Cooldown.TotalMilliseconds >= 1000 || !settings.UseSuiton || Core.Me.ClassLevel <= 45 || (Core.Me.HasAura("Kassatsu") && !settings.KassatsuSuiton) || Core.Me.HasAura("Suiton"))
seems to fix the issue.
Huton should probably be off the ninjutsu hp limit. I'd imagine you'd want to keep the buff up regardless of what you're hitting.
Is there any way to perform actions when you have no target? I know that Magitek has/had that capability using ExCombatAssist for healing, but I'm not really sure how it works. Specifically, I'd like to refresh Huton if I dont have a target (perhaps with a separate, higher clip timer). The last two turns of Final Coil have a significant amount of downtime where you're dodging things or waiting around, so that when mobs show up again your Huton is off (assuming you didn't manually refresh) and you waste time and a ninjustu putting it back up.
Trick Attack gets used out of position often when moving around. I know that's due to the response delay between the bot, client, and server, but I'm wondering if its possible to narrow the part of the arc that IsBehind refers to, so it happens less often. Trick Attack should be on the dot health threshold as well. Not much point in debuffing something with 1000 hp left. Whether to have Suiton on the threshold as well, or leave it on the ninjutsu threshold, I suppose is a matter of if the player wants to use SA.
Varying health thresholds. Mutilate and Shadow Fang have different durations and potencies, so its not as efficient to have just one number for both of them. Something like Core.Me.CurrentTarget.CurrentHealth >= settings.DOTLimit*3/2 for Mutilate, etc. Can also include Dancing Edge in there, as if the mob is really low you might as well use Aeolian rather than applying DE debuff for the last couple seconds.
In regards to Goad, a couple of options that might help. Dragoons get the trait to increase tp from invigorate, so their goad 'threshold' could be 100 lower than the other classes. Option to enable goad usage on tanks, possibly with a higher threshold since they don't have access to invigorate.