CLU (Codified Likeness Utility)

I was wondering how the holy paladun is doing in pve, raids and dungeons. I have a old holy pally that needs some playing

 

guys there is a serious flaw in the Party AoE healing distance detection I am working on it..this is why all the AoE heals (PoH, Wild Growth, Holy Radiance, etc) are not casting when they should

If that makes no sense to you, All party members were within a 40yrd radius of me (player3 was right beside me)..the large numbers you see are suppose to be the distance (30f) but the detection I am using is giving huge numbers back, apologies for not picking it up sooner..

should be fixed soon.

 

can u tell me the routine / method / composite to have a look at?

okay i think i found the bug

Code:

p.Location.Distance2DSqr(player.Location) < maxDistanceBetweenPlayers

should be

Code:

p.Location.Distance2DSqr(player.Location) < maxDistanceBetweenPlayers * maxDistanceBetweenPlayers

most time your code is not kickin cause a distance of 8y is 64y (sqr -> square and not sqareRoot^^)
Found this in TargetBase.cs
private Composite FindAreaHealSubroutine(int minAverageHealth, int maxAverageHealth, float maxDistanceBetweenPlayers, int minUnits, string label)
haven't checked all the other Targetting Routines, but i think u did this mistake on other places too

---edit---

yep double checked it with holy radiance

u call

Code:

// Holy Radiance
                    Healer.FindAreaHeal(a => true, 10, 80, 30f, (Me.IsInRaid ? 5 : 3),
                        Spells.CastSpell("Holy Radiance", a => HolyPower < 3 && Me.ManaPercent > 15, "Holy Radiance")),

with this call all units has to be in a Distance of 5.477y to meet the requirements of Holy Radiance (sqrt 30 = 5.477)

 

var hits = players.Where(p => p.Location.Distance2DSqr(player.Location) < maxDistanceBetweenPlayers);

will upload the latest to SVN for you.

 

That was fast! that was a bit of a Doh! moment.

 

yeah checked the files and took the one that i thought it would be the correct one^^ while waiting for answer

 

latest svn is still reporting odd numbers....

everyone was in a circle no bigger than 20yrds.

 

Noticed indeed that my Priest was not using PoH at all, I manually popped it. Didn't mention it to you before. Not a big deal though, it's a 8 min CD so I don't want to pop it anyway at the last minute of a fight or so. Haven't noticed my Druid (Wild Growth) not doing it right though; it's doing a lot of Wild Growths...

I especially like the enthusiasm and passion you put in this; it's really appreciated. Stormchasing seems to be a good help as well!

 

Thanks Soeski, I don't know what I would do without Stormchasing sometimes haha.

 

this is only a bug in your output

Code:

match.Location.Distance2DSqr(best.Location)

this again returns the SQUARE of the Distance, not the SQUAREROOT

 

way too many beers tonight lol...time to put the coding goggles down

ok thats better

Math.Sqrt(match.Location.Distance2DSqr(best.Location) ...hic

 

Just out of Curiosity, where are you located anyway? I notice when I'm going to bed, you're going to work (real life job).
Also right now, when you're talking about beers tonight, I just finished lunch (1:30pm)... hehe.

 

did u ever tried

Code:

match.Location.Distance2D(best.Location)

i see atm no reason to use the Distance2DSqr but ... that's your code^^ do it like u prefer it ... and ...CHEERS

 

I come from a land down under

 

Ah, then I get it! Land of the kangaroo or something hehe. That's at least 9 timezones away from mine then hehe... it's about midnight at your place then. Explains why my midnight is your morning to go to work

 

Change Log
-------------

* 29/6/2012 [2.7.0]

Patchs added for Warlock Pets and Ele and enh shaman weapon issues - thanks stormchasing.
Fix for DPS-ing the Burning Tendons and Deathwing head.
Fix for LoS healing
Fix for AoE healing detection.
Resto Druid changes/tweaks (still not happy with it.)

Stay tuned...party healing is now working!!!!

Disc Priest has Party Healing enabled, should revert to area healing when out of Raid.

 

Wulf, nice to mention to you:
Last night, LFR. 6 healers, 3 priests, 1 shaman and 1 druid.
Breakdown:

Shaman: 13K HPS
Druid: 12K HPS
Priest 1: 10K HPS
Myself: 8K HPS
Priest 3: 7K HPS

But guess what; although I was the second lowest healer in the charts, I also checked the overhealing charts. Breakdown:

Shaman: >14K OHPS (56%)
Druid: ~13K OHPS (>50%)
Priest 1: ~9K OHPS (>40%)
Myself: ~5K OHPS (29%) !!
Priest 3: ~6K OHPS (>40%)

Soooo... we can safely assume the Priest is very efficient; I did not go OOM this time as well!! (LFR Fall of DW).
I can only say; great work and according results. Of course this was before the fix you've just made with PoH...

/edit: Also did the same run with my Resto Druid with Noobrage. Overhealing 50%... and no mana issues at all. Having said that, Innervate is not THAT great at all. During a fight it usually gets me 10% more mana than before Innervate, but certainly not from empty to full. No where near that...

 

Any news on this Low level mob targeting business Wulf?

AGain, REALLY appreciate your work buddy

 

Will check it out first thing tommorow mate. I haven't forgotten you

 

At what point does CLU change to AOE healing for a Holy Priest?