Default Combat Test Edition

On test edition f12 did work. What I meant by same problem is referring to this post above sorry, just realized that wasn't clear. But yes it really just the AOE heal and the Tank (string) not working as you said. Please let me know if you need me to test. Once we can get this fixed ill release out a Sorcerer: Corruption healing routine that's up to date and will test that in HM's and raids before hand. After that ill move on to the next healing class

 

Ok so test edition only has AOE heal broke? or what is broke with tank string on test? Aevitas is fixing the weird dps issues and I'm waiting for that before going much further. Cryo somehow had his bot casting DPS through the heal string which was very wonky to say the least. I'm hoping the HPS will return 0 too when the char is dead. We shall see after the next update goes live.

 

Yes on my testing only the test edition aoe heal didn't work. It only worked on PureSwtor and defaulcombat routine.

This is what's broke on test edition and pure. All these spells are to be cast on the tank but they don't. On my test it auto cast it on me even after using f12 to set the tank.

 

But regular default combat cast on the tank correctly?

Working on the AOE stuff now I think I may have that, changing rest due to something I found as well. Update shortly.

 

New revision is up didn't test anything on healing as of yet but a lot of it looks better. So I think Cyro's issue was the echo I was using was on the actual cast routine, put a check there. Changed rest routine to bump char forward again as after extensive testing you can't sendkeys to the client if it's not in focus anymore. I tried everything and even when I forced it into focus it didn't go. Bump forward wasn't ever the run into the sunset bug, the not checking and stopping moving before entering attempted rest was.

Also found a old fix for the isvalidtarget that never made it into the core. Was something Leo posted around the time I fixed rest it was a try/catch so I added that.

This new bot version has my PC hitching with every single dps cast, noted it to Aevitas on the feedback page. Thought it was my code till I tried stock and had the same problem. You can test with my latest revision and new bot but expect hitching when casting. Cyro if you can try this version with either the buddywing you had or the new one I am interested to see if it doesn't fire off better for you.

 

Did a quick test with companion on a fp and indeed it keep changing back to select myself, incombat, outofcombat eventually when health is full it switch to companion or let me select a target then the bot dps.
Operative medicine
Latest version of bw and rev15 on combatdefault test edition

 

I know why it's going back to yourself and not comp, just need to figure out how to fix it.

Code:

                            if (Tank == null)
                                Tank = Me.PartyMembers(false).ToList().Where(c => c.Name.Contains(TankName)).FirstOrDefault();

That is the failed tank selection, I tested all other tank selections and they work correct. This is setting my character as Tank which it shouldn't. If I put comp above it works like it should making the comp the tank. But I want comp to be one of the last checks.

 

Ok so I have 1 more part to identify on the tank automated selection. And that's where it creates a list Tanks. I need to look at pure to identify how that's referenced and or used. So I'm very proud of this release as the tank selection is actually dead on now. There are several ways to set the tank and as of now we can only have 1 tank at a time.

1 - Focused Tank, Set your focus target with alt-f and you will now make them your tank. Not sure how or if dps will pass or not.
2 - f12 selection Selecting f12 will mark whatever tank you want to call the choice is completely yours.
3 - I didn't pick a tank, If you have a companion they will be automatically selected as the tank. <- since it's by name be careful of friends pets in open world as they can have the same name as someone you pass by.
4 - You didn't pick a tank and you don't have a companion (oh crap) your tank selection is your self.

A lot of the Pure code was broke in the regards of tank selection. I still need to dig into the Tanks list for multiple tanks. Operative routine doesn't have pre-kolto casts so for testing I just added it and removed it when done. This helped visualize the tank selection as well as lots and lots of log writes. The targeting looks pretty decent but I wouldn't want to really grind as a healer. I couldn't get attacks to work and the targeting was blipping between mobs and companion.

I need to know if cleanses will work both in default and with this build, I also need to find out if the AOE heals are working now. I cleared out the heal logging as if you weren't casting a heal it could bugger.

For the first time in forever I had to set my SWTOR affinity due to this build of buddywing. It did smooth out but I haven't had to do that in forever.

 

Update, Was looking for something in Pure and stumbled across his Scavenging routine he ripped from Joes. Did some testing and other than having Comp harvest and you hit node 1 second later as well but it works great. Gave the code to the GitHub request so Aevitas can figure out the double harvest and so he can add it to the core code.

But until then I did add it to this test build. The info I found on multiple tanks wasn't good a few comments in the code of not sure if it still worked and not working on other parts. Let me know if the Aoe is fixed and if not then I will sort of reverse the process I took. I pulled the whole Pure healing routine and modified it. If Aoe isn't working then I will take Default Combat and add all of the different fixes I have created along with the extra checks. We will see were this goes in the near future but overall we have made some great leaps and bounds here.

 

Okay I will test the healing with the new changes when I get home and post the results

To answer this question:

defaultcombat didn't cast on tank correctly.

 

Tank I have all fixed now, the tank selection was super hosed in both Pure and Default Combat. But I did figure it all out and got it there.

 

rev 19 didnt compile.

Got these errors:
Compiler Error: c:\SWTOR Stuff\BuddyWing heal\Routines\DefaultCombat\ProximityInteract.cs( 15 ,7) : warning CS0105
Compiler Error: c:\SWTOR Stuff\BuddyWing heal\Routines\DefaultCombat\DefaultCombat.cs(89,21) : error CS0103

 

hrmm removed blank check from f12, I'll fix in a sec

Interact I removed, was something I was messing with for scavenging. It doesn't affect the scavenging add as that is a separate file. I was playing with doing it as a plugin. Don't know what your showing for default combat, buddywing compiled just fine and VS shows no issues. Do you have all 3 references current?

Only other thought is are you missing the Scavenge.cs file? That's where the error points.

That was odd it didn't auto add the file. I had to right click it and add. It's updated and Scavenge.cs is now showing.

 

Try Now.

 

Scavenge.ScavengeCorpse on defaultcombat.cs still giving error, so i puted as comment for test and it compiled

Quick run on tactical me and companion

If i select a target out of range, the companion or myself, it will precast koltoprobe. If i select nothing it will do nothing (i guess thats whats expected). if i maintain a target it will maintain the 2 stacks of KP on the companion.

I removed some gear, put back and slect myself, then the bot will blink around 3 or 4 times between me and companion because try to heal me but also put the 2 kp charges on the companion.

In situations that both get some damage it keep blinking between me and companion in the midle of casts.

Then i set myself as tank with f12 and the bot wont heal companion anymore.


On another build, dont remember wich, the cast were made whitout actually selecting the targets, something like mouseover. Was there somehing like that or im just nuts? XD

edit. nvm the scavenge, the test was with rev20

 

I just committed scavenge so it should work now. I never had it not switch fast between, See we create the lists then hand them to buddywing to determine how to select targets. It may not have switched fast but it was likely when it was super broke. I'll have to try selecting myself as tank and see if the comp gets healed as the comp should still show on the regular healtarget list.

The have target is a part of the combat bot selection with movement disabled. You can fake the system and have a fake quest profile which Cyro taught me a long time ago but with a total blank default combat you have to do base target selection yourself.

Also for companion as tank you don't have to do any selection it should do it by default.

Now I did identify Tank selection was causing the super fast swap, when I disabled all tank selection that stopped. Not sure what could be done to fix that except change tank detection to a much higher run count. Like check for tank every 100 runs instead of every 3,

 

rev 22

Discovered that the problem with the bot stoping healing the companion was related to f9 pause not with f12 selecting.

If i use f9 it wont recognize tank changing with f12 and wont heal companion regardless of setting anything with f12 or not

Can i use a fake quest profile for lazyraiding? Is there a post where i can get or learn how to create one?

edit: another thing i discovered it break f12 and companion healing its if we dismiss and resummon it.

 

Yeah give it a whirl, see I hit up the forums way back about auto targeting when using combat bot profile. Cyro came up with the answer. This will crank your log with errors but will work as if you were questing or running a grind profile.

So I hit up the forums at another date about skipping through conversations and I think it was Cyrogenesis that came to the rescue again. If you use this while controlling quest fights it will change targets automatically, fight till done, skip conversations choosing dark options (really is there another option?) Great for banging through quests. Sooo as far as hitting f9 or f10, That's going to be at users own risk as far as I'm concerned. I don't know of anyway to change that. Let me know how the test goes and yes your log file WILL explode with this setup. Need to find another option I could possible change the main checks to create another way to have a movement/targeting profile without error.

The dismiss and resummon it mist cause buddywing to not get a proper me.companion != null etc. That would end up being a core bot issue.

 

So Cass I know you have some programming ability and I could always use a hand. So to track down something like dismissing and resuming the companion somewhere in the tank detection I would put something like.

Code:

if (Me.Companion == null)
Logger.Write("I have no companion");

I can only do so much in fixing everything due to limits in time and or ability, but if I can help teach those who can help better we can really turn the bot around. I use a lot of logger.write in my testing as it allows me to echo out what's occurring behind the hood so I can fix it.

Also to anyone out there if your up to the task I could use additional help and could add you for SVN access to collaborate and turn default combat around. The first step in making buddywing better is to get the combat bot as good as we can. Then when they fix the mesh/conversation issues we can turn this whole bot around.

Benefit to having this bot working better is more players will migrate here. For every so many players you wind up with a developer that helps to make it better. That is why everyone is like "well honor buddy has this or that" simply more users = more developers.

 

I just downloaded the new buddywing and updated default combat test edition rev 22. I tried it on a tactical fp and I picked one of the dps as a tank with f12. Bot said that person was set to tank. But its weird cause the bot never stoped casting healing spells. And spells that's suppose to be casted on the tank only still didn't happen. Here is a log


View attachment BuddyWing 6124 2016-04-03-06.41.43.txt


I just did a hardmode fp and set the tank with f12. It just healed that tank non stop even out of combat. occasionally sometimes it would target another and will cast a healing spell even if that person has full life. But it doesn't stop casting