• Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • [PAID] GarrisonButler

    Discussion in 'Honorbuddy Store Botbases' started by deams, Nov 29, 2014.

    1. Prostak

      Prostak Member

      Joined:
      Mar 17, 2013
      Messages:
      249
      Likes Received:
      16
      Trophy Points:
      18
      Let me thank you for this great work. I've published a simple Questing addon for Garrison chores myself: https://www.thebuddyforum.com/honor...es/farming/191666-garrison-chores-mine-4.html , but I think I can now retire it. And having worked on the Garrison I can recognize the amount of work that went into this.

      Some notes on behavior. Mine run is impressively fast, no stucks or misses on 10 toons. Missions are great too. I have not checked the quality of the mission selection, but I can always place them manually on the toons I care about. Having them placed automatically on secondary toons is a great relief.

      Problems. I have 4 stucks on 10 toons. 3 seem to be easily corrected. If I may, I have some suggestions based on my own experience with Garrison automation.

      1. 2 stucks were on moving to Anvil (for a Blacksmithing daily) while the toon was over or behind the Mission table. Anvil seems undetectable from this place. Suggestion: Do Blacksmithing daily while near the Anvil. Or, do not try to find the Anvil, go directly to the known location: there is always one near the Mine orders guys. It is called "Thermal Anvil" but it is quite the same functionally.

      2. Stuck inside the Dwarfen bunker after placing the order. Path need some minor addition. I will post the log if this repeats.

      3. Stuck while moving from Herb Garden (pick orders on, place orders off) to Gladiator building (level 2 place). On the screen it was wild jumps as if the toon was trying to unstuck. In the log there is something more complicated:
      [ShipmentStart] Could not find unit (86639), moving to default location.
      If this message is spammed, please post the ID of the PNJ for your work orders on the forum post of Garrison Buddy!
      Not sure what is PNJ, lol, but the log is attached.
      View attachment 108704 2014-12-27 23.20.zip

      Again, thank you for your nice work.
       
    2. deams

      deams Community Developer

      Joined:
      Oct 20, 2014
      Messages:
      714
      Likes Received:
      25
      Trophy Points:
      0
      Thanks :)

      Hey Prostak,
      Good job for the profile, impressive work without touching the code!
      Thanks for the bug reports, the Anvil will be fixed in one or 2 releases (But they should be pretty fast once I'm back home).
      Concerning the Dwarven Bunker I am still designing the code to avoid getting stuck inside, was a bit of a challenge to find an elegant way to do so.
      For the stuck/not really stuck issue, will look into the logs!

      Once again, thank you for coming by and describing everything with logs!
       
    3. deams

      deams Community Developer

      Joined:
      Oct 20, 2014
      Messages:
      714
      Likes Received:
      25
      Trophy Points:
      0
      WARNING

      After verification of the GarrisonButler release from the BuddyTeam, it appears that there is currently a small risk for the users to be detected.
      Please be careful while using it, it is a minor security risk but I think you had to be warned and I advise you to wait for it to be safe.

      Modified the code to comply with the security rules, I am waiting for the confirmation.
      Will let you know asap!
       
      Last edited: Dec 28, 2014
    4. wr9966

      wr9966 Member

      Joined:
      Jan 15, 2010
      Messages:
      112
      Likes Received:
      0
      Trophy Points:
      16

      Do you mean there is an increased detection risk? Or that there is a possible hack risk?
       
    5. deams

      deams Community Developer

      Joined:
      Oct 20, 2014
      Messages:
      714
      Likes Received:
      25
      Trophy Points:
      0
      There's an increased detection risk, a small one but still. No hack risk from the botbase.
       
    6. Wullie

      Wullie New Member

      Joined:
      Jun 8, 2013
      Messages:
      411
      Likes Received:
      3
      Trophy Points:
      0
      What is the nature of the increased detection risk? Is it still present in the new version?
       
    7. Lexxer

      Lexxer New Member

      Joined:
      May 30, 2013
      Messages:
      104
      Likes Received:
      0
      Trophy Points:
      0
      deams can you may add a interaction with the Plugin "Masterplan" to solve all missions above x% ?
      this would make it much better couse currently you just solve missions if you have enough guys to counter it, but this is not needed most times

      it would be awesome if he also solve chance 70% or higher
       
    8. deams

      deams Community Developer

      Joined:
      Oct 20, 2014
      Messages:
      714
      Likes Received:
      25
      Trophy Points:
      0
      Even though I doubt Blizzard cares that much for such a botbase, it would be even more dangerous to post the nature of the risk before getting it fixed.
      But let's say, they would need to look for it specifically, so it might only be a risk for people getting investigated. And even if they look at it, nothing link it directly to GarrisonButler.
      The chance of it getting you ban is near 0 in fact. But I prefer to be careful. :)

      I am still waiting for the confirmation, might not happen today since it's Sunday but will communicate here any info.
      A bit fucked up, if you forgive my french, but at least GarrisonButler is finally on the road to leave the BETA stage!
       
    9. klepp0906

      klepp0906 Banned

      Joined:
      Apr 25, 2013
      Messages:
      1,352
      Likes Received:
      8
      Trophy Points:
      38
      garrisonbutler = garrisonbuddy rename?
       
    10. deams

      deams Community Developer

      Joined:
      Oct 20, 2014
      Messages:
      714
      Likes Received:
      25
      Trophy Points:
      0
      Yes!
       
    11. shelaine

      shelaine New Member

      Joined:
      Sep 8, 2014
      Messages:
      214
      Likes Received:
      4
      Trophy Points:
      0
      hm, no matter what I name it - GarrisonBuddy or GarrisonButler, the botbase doesn't show up under Botbases for me anymore since the latest HB release... ?
       
    12. klepp0906

      klepp0906 Banned

      Joined:
      Apr 25, 2013
      Messages:
      1,352
      Likes Received:
      8
      Trophy Points:
      38
      ack - i updated via SVN and now it wont show up in my botbases dropdown. Any .. idea? or did you intentionally brick it due to the "issue"?
       
    13. mrJones2k

      mrJones2k Member

      Joined:
      Mar 14, 2010
      Messages:
      86
      Likes Received:
      0
      Trophy Points:
      6
      read the file and first post

      WARNING

      After verification of the next release from the BuddyTeam, it appears that there is currently a risk for the users.
      Please be careful while using it, it is a minor security risk but I think you had to be warned.

      Modified the code to comply with the security rules, I am waiting for the confirmation.
      Will let you know asap!
       
    14. klepp0906

      klepp0906 Banned

      Joined:
      Apr 25, 2013
      Messages:
      1,352
      Likes Received:
      8
      Trophy Points:
      38
      yea.... thanks for the.. obvious.... and the reiteration of the.. obvious.

      although you dont need to be careful using it if you CANT use it because the SVN is empty and the zip file is pulled down :p
       
    15. deams

      deams Community Developer

      Joined:
      Oct 20, 2014
      Messages:
      714
      Likes Received:
      25
      Trophy Points:
      0
      If I missed it before, can you post another log please? :)


      I wasn't gonna pull it down at first, but ended up going for a risk free politic.
       
      klepp0906 likes this.
    16. Lexxer

      Lexxer New Member

      Joined:
      May 30, 2013
      Messages:
      104
      Likes Received:
      0
      Trophy Points:
      0
      hope you mean this "exploit" with the currently bugthing that he can send missions without follower
       
    17. klepp0906

      klepp0906 Banned

      Joined:
      Apr 25, 2013
      Messages:
      1,352
      Likes Received:
      8
      Trophy Points:
      38
      tooootally understandable. Safe > sorry. In the end, its simply easier that way :p Not to say we arent eager to have it back lol.
       
    18. deams

      deams Community Developer

      Joined:
      Oct 20, 2014
      Messages:
      714
      Likes Received:
      25
      Trophy Points:
      0
      What do you mean?
      I never saw this happening, or even someone talking about it on any channels.
       
    19. Lexxer

      Lexxer New Member

      Joined:
      May 30, 2013
      Messages:
      104
      Likes Received:
      0
      Trophy Points:
      0
      sometimes he fall into a loop ( he try to start mission but didnt do )
      when you help then while bot is running, ( you need to close the current selected mission ) then he leave the loop and he start a mission with 0 or 50% without a follower.

      edit
      [​IMG]

      View attachment 35348 2014-12-28 12.06.txt

      on the end of the log you see the loop
       
      Last edited: Dec 28, 2014
    20. deams

      deams Community Developer

      Joined:
      Oct 20, 2014
      Messages:
      714
      Likes Received:
      25
      Trophy Points:
      0
      Do you base it on the visual information, the logs, the result of the mission?
      I just tried to modify the code to do it on purpose, couldn't send the mission.
      If you base it on the UI it is possible that it just doesn't refresh properly and show wrong info while sending. It is also really fast between adding the followers and sending the mission.

      EDIT: Seems my eyes were closed when looking at your screen...
      That's one hell of a bad bug. Will definitely put it second after the security issue on the To Do list.
       
      Last edited: Dec 28, 2014

    Share This Page