That seems to fix it. Sorry, must have posted just as you made the edit. Thank you very much for adding in potion support, very much appreciated.
Anyone that uses this in a mid to high range end game raiding group would you mind sharing your clipping/kassatsu/etc settings? I main bard and can do the same for that job, but I'm curious as to what a Ninja main that uses it in a raid environment and tested their settings has come up with as optimizations.
Default settings with Goad disabled so I can manually do it since by default it does't Goad tanks. I easily pull off 500+ DPS with BIS gear optimised for each turn in FCOB (no expensive crafting gear, just AIW/DW). T10 I can do 600+ if I don't get charge... And the other melee uses LB .
Default settings work for the most part. Changes I would make are decreasing Goad TP (if its too high you end up Goading a dps before they use invigorate. I usually use it on a tank ~30s into the fight, then let it run automatically from there), setting Second Wind to 0 so you can use it manually, and allowing Kassatsu + Everything (Doton crits the ticks anyways so there's no reason not to, and delaying Suiton aka Trick Attack is a large raid dps loss. Kass + Huton is personal preference; it rarely happens, and whether its optimal depends on the situation and your Huton Clip setting). Blood for Blood is more ambiguous; ideally you'd want to use it manually, as a lot of mechanics in FCOB deal tons of damage, and if you just pop B4b whenever its up you can easily die to Charges and Megaflares and stuff. However, with better gear and echo this is less of an issue, so if you're bad at remembering and want to maximize dps, keep it on and roll the dice I guess. The setting that matters the most is probably DoT HP Limit. Using Mutilate on something with 1000 hp is just as bad as not using it on something with 100k hp, so you'll have to experiment with whats the right number for you. A big problem is that the same number is used for both Mutilate and Shadow Fang, even though one is almost twice as long as the other. I use a setting of 20k hp, but I've also edited the routine to use double that number for Mutilate, along with some other tweaks like setting an HP Limit for Trick Attack, not using Kass+Suiton again if you already have the Suiton buff, Goading tanks, etc. Think I hit a little over 530dps in T13 a while back, unmerged, with 10% echo, and not using pots or cheeses to boost my dps like keeping adds alive longer (cough DnT).
Digging the new update, however, through my experience I've encountered that the NIN/RGE profile will not throw Poison Pots. Dex Pots work fine, its just Poison pots. Not sure on BRD side of things since I use Kupper for NIN exclusively.
Would you be kind to share the settings file? I'd understand if you don't want to, but I'd like to try those settings. I'm not good at coding.
Here what I use, updated recently for the new build. View attachment RogueNinja.cs View attachment NinjaSettings.cs Ichiba did a great job with the routine; there was just some small stuff that annoyed me, and I hope I'm not stepping on anyone's toes. As mentioned earlier, includes goading tanks, higher Mut hp limit, no double Suiton, TA hp limit, logic to choose between Raiton and Fuma, etc. Added all up it honestly probably only makes a couple % difference in dps. One important change is that I only AoE manually, so I set 'R' as the key to hold down to use aoes. It'll spam Death Blossom (really hope ninjas get a better aoe skill in 3.0), and use Katon/Doton instead of Suiton/Raiton/Fuma. Doton logic is purely based off DoT hp limit, so if you're in a fight with a lot of mob movement, well, you've been warned. Also a setting to only use B4B when it can be sync'd with TA. For use when you don't want B4B to pop mindlessly on cd, but do want it when it'd be most effective.
I know Ichiba is busy so this isn't really a personal aimed mainly at him, but I'm having issues with the CR not using the DEX potion before Barrage, occasionally it will use it before the barrage, but the vast majority of the time it uses it afterwards if at all. Is there an easy edit I can do that will make sure that Barrage will not be cast prior to the pot as long as the X-Pot is not on CD? To echo Dark Pietro, I too am having issues with the CR using poison pots now as well. Also a slight off-topic question but if anyone knows off the top of their head, is there any difference in performance between EX-ComAssist and standard ComAssist?