works great only other thing i can think of is it swaps seals for you on aoe even if you dont want it to also the seal of righteous box stays checked even after saving it as unchecked like the avenging wrath was other than that very excellent 390 ilvl ret pally 56k on 5 man heroic bosses with me using CD's
I can't replicate this error with Seal of Righteousness Tried it out on mobs and CC did what it was told to. Tried lowering amount of mobs for aoe to 2 and attacked 4, CC didn't switch seal a single time with Seal and divine storm disabled
While I appreciate help, I would like people not to share our coding with their changes as this gives out false unsupported versions. Any suggestions should be posted here or files sent to me. People download just about everything and I don't support others codes. I already told you that I would take a look at it, but I am on my way on vacation right now - so all I ask is a bit of patience
I don't see the harm in it, full credit is of course yours and it works perfectly. If I'm breaking forum rules or something feel free to get a mod to delete it or whatever.
I have saved the file and I will look it over. What I ask is simply that you delete the file and let me do the changes needed. Give me a little time, pretty much all I am asking
Hey, as some of you may have heard I've recently offered my help to the Lazyraider team and one of the CC's Venus112 wanted me to have a look at was this one. I have prepared an alpha test version of the latest release of Avenger, see post attachment for the file. This is a complete rewrite from previous versions and should hopefully perform better. At present it should follow the ret rotation as per usual and stack cooldowns intelligently as one might expect. I haven't had a chance to test it on anything but the training dummy, so I would really appreciate it if someone could take the time to test it out in a heroic or raiding environment. As usual the recommended botbase is Raid Bot. Don't worry if you notice that trinket and gloves aren't being used as they have yet to be implemented. If you notice any issues I would really love a log. Thanks folks!
Checked the code and your rotation is still wrong, fixed that. Cool downs are working perfectly and it even gets the zealotry priority right yay. Here is the version with the correct rotation. E: I also changed inq refresh timer to 3 seconds which is what it should be at. E2: After testing it out, seems to be about a 2k dps increase from my edit of the the last version of the cc E3: Consecration should only be used as a filler above other spells when there are 4+ adds available, maybe add in a check to see, will try adding in myself using existing code. (Sucess!) E4: Divine plea shouldn't be used EVER purely from a dps standpoint, it's a wasted gcd, I think adding an option for what % of mana you want to use it at would be great, I changed mine to 15%.
If you have any feedback in the future, I would appreciate if you could explain the issue in plain text rather than rewriting code. Digging through code to check for differences takes a lot more effort than reading a written report. Also I think it's Venus112's policy that edited versions are not to be posted in this thread, so if you could take your attachment down it would be greatly appreciated. Thanks. HoW > Exo > TV is just as valid as TV > HoW > Exo according to Elitist Jerks, neither is wrong. It depends entirely on the player's gear. In your edit you placed Judgement above Exo and HoW though which is definitely an issue -- judgement should always have the lowest priority of the "main" abilities, regardless of rotation. Thanks for pointing out the Inq refresh timer issue, I didn't notice that. I'll update it for the next version. Glad to hear that you've noticed a DPS increase from v1.6 as well. Cheers!
Judgement gives holy power with 2 piece t13 making it higher priority. The ej post is outdated, if you look at the clcret thread on the last pages you'll find the updated rotation and reasoning. This file has the edits to cons/divine plea. I'll ditch the files as you view them, or I can send them to you if I figure out how >_<
You are correct about T132P but I haven't yet got around to implementing tier piece set checks hence why Judgement has a lower priority. Later versions will include automatic rotation modification depending on tier bonuses and a toggle between the two rotations. Could you provide a link which has the most up to date (more up to date than EJ and their spreadsheet) rotation information so I can research and make changes appropriately. Regarding consecration, according to EJ consecration is a filler regardless. If you disagree I need links! Regarding divine plea, it is only used as a filler when nothing else is available, hence turning an empty gcd into a useful gcd, not wasting one. And seriously, stop posting modified versions in this thread and remove your attachments. Having several edits floating around won't lead to anything good and I'm not digging through your code for edits to find out what you changed. If you want something to be modified I need clear, concise feedback, and if you disagree with EJ, a link to the resource(s) you're using with theory crafting showing why.
Ret FCFS Rotation Helper - Page 31 - Elitist Jerks has the correct rotation. Consecration is a filler but is the lowest priority, and should only be used above holy wrath (Second lowest) when 4 adds or more are available, I never said it shouldn't be used at all. Read the aoe section The Retribution Concordance - 4.3, Voice of the DPS - Elitist Jerks Every edit I've made I've told you about in plain English, I don't need you to modify anything, it's easier to do it myself, then upload for you to double check. Like I said, I'm more that willing to pm files to you if you'd rather it done that way. Also, you're right about divine plea but it seems to waste about half a gcd, as my abilities will come off cd in that time, meaning not using it is still a dps increase.
Consecration is already under HW so no change is necessary. The issue with your edits are that they are pointless -- I am not going to use the code, so it would be faster for both you and I if you just explained the issue. No offence intended of course, I appreciate the feedback. Thanks for the link, I'll have a look over it tomorrow. Once I've had an opportunity to implement some new features I'll post up a new release, including the option to toggle between the two rotations. I'll also clean up the UI a little. Cheers!
With consecration though, what I was trying to do was add in 2 priorities, one when 4 or more adds are present and have that above HW, and one when it's just being used as a normal filler. All I did was throw in the DS conditions for aoe and place it above HW and it works fine. Can't wait to see the new release
Guys how does this perform for Arena? Can it target fellow Horde players in a duel/arena? Thanks. EDIT: True bro, I was having a brain fart and actually wanted the EZRet post. Thanks!
