It's a CC that does not use Necrotic Strike, so unless something has changed in PvP that i didn't know of - you'll not get any good results from this. It's a CC for PvE
CC freezes sometimes after using heroic will However it works properly for soaking if you ams you will stay out
I made a few changes to this CC to fix some issues it was having with the Deathwing and Ultraxion fights. I've attached the Plaguebringer.cs file containing my changes. It also fixes a freeze that happens if you don't have a pet out and can't summon one. These changes are based off SVN trunk revision 93. ***Removed at request of CC author***
Nothing has been fixed by me. I'm trying to be on holidays right now, but I noticed this and wanted to say that we do not support others codes It's already been stated that I am on vacation this week, so i won't spend any time coding when I'm on vacation. Will fix the issues through svn this weekend probably Ksu: while I appreciate help with finding errors, its not easy for me to look through the entire code to find what you have changed - it is better to post suggestions that contain code fragments as they are easier to spot and doesn't force me to spend hours looking for differences. And we also don't condone other people posting edited versions of our CCs, as that can lead to problems for the users
If i missed reading not to post edited versions of CCs somewhere, I appologize. I will put together all of the changes shortly as code snippets and post them here. I have removed the attachment from my previous post to prevent confusion.
If this is still out of line, please let me know and I will work with you directly through PMs instead. To summarize the changes that I made, the issues I was running into were that during the Ultraxion fight and Deathwing fight, the distance calculation to current target was always longer than the check for DnD allowed in order to cast. This prevented it from casting DnD on those two fights and would then cause all other casts to stop because of the dependency on DnD being on cooldown. **Original code** Code: if (Diseases() && DnD() [B]&& Me.Location.Distance(Me.CurrentTarget.Location) <= 10[/B]) { Lua.DoString("CastSpellByName('Death and Decay');"); { LegacySpellManager.ClickRemoteLocation(StyxWoW.Me.CurrentTarget.Location); } } I changed this to function as follows. The IsDeathwing() and IsUltraxion() methods simply check to see if you current target is one of the targets in those fights. (Currently rewriting this part to be cleaner) Code: if (Diseases() && DnD() && (IsDeathwing() || IsUltraxion())) { Lua.DoString("CastSpellByName('Death and Decay');"); { LegacySpellManager.ClickRemoteLocation(StyxWoW.Me.Location); } } if (Diseases() && DnD() && Me.Location.Distance(Me.CurrentTarget.Location) <= 10) { Lua.DoString("CastSpellByName('Death and Decay');"); { LegacySpellManager.ClickRemoteLocation(StyxWoW.Me.CurrentTarget.Location); } } Definitions for the IsUltraxion() and IsDeathwing() methods Code: public bool IsDeathwing() { if (PlagueSettings.Instance.DSNOR || PlagueSettings.Instance.DSHC || PlagueSettings.Instance.DSLFR) { if(Me.CurrentTarget.Name == "Arm Tentacle" || Me.CurrentTarget.Name == "Wing Tentacle" || Me.CurrentTarget.Name == "Deathwing" || Me.CurrentTarget.Name == "Mutated Corruption") { return true; } } return false; } public bool IsUltraxion() { if (PlagueSettings.Instance.DSNOR || PlagueSettings.Instance.DSHC || PlagueSettings.Instance.DSLFR) { if(Me.CurrentTarget.Name == "Ultraxion") { return true; } } return false; } The other change that I made had to do with flooding the debug window with error messages if your pet was dismissed and it was on cooldown during combat. Code: private bool DT() { if(!Me.GotAlivePet) { Lua.DoString("RunMacroText('/Cast Raise Dead');"); return false; } return Me.Pet.ActiveAuras.ContainsKey("Shadow Infusion") && Me.Pet.Auras["Shadow Infusion"].StackCount == 5; } One other thing, I would love to help out more if possible. I have been a software developer working in C# for the last 4 years and would be willing to provide my coding expertise for code review/clean up as requested.
i use death and decay targetted on yourself instead of the mob, and then simply a check for 10 yards, and it works fine for deathwing and ultraxion.
New update available through SVN Plaguebringer 1.5 Will now only use Death Coil if we're above 80 Runic Power OR target doesn't have Unholy Blight (If it's a boss) - Working on this still Problems death and decay should be fixed Thank you KsuCoolCat for suggestions for code fixes
Although it does work to use Distance2D to cast DnD on the Ultraxion and Deathwing fights, I worry that it is an overall dps loss at least on the Ultraxion fight since it can never hit him but uses an Unholy rune that could be used for something else. I'm going to do some testing on the next reset to see if not casting it at all on Ultraxion results in a dps increase.
I'd call that a bug in WoW, but i'll upload a new version that fixes that (no use of DnD on ultraxion).
No sweat. Will be uploading a new CC soon that handles Death Coil better on bosses ---EDIT--- New version available through SVN Plaguebringer 1.6 *Now uses Death Coils better on bosses. If Summon Gargoyle isn't on cooldown, CC will pool to 80 runic power before using Death Coil If target doesn't have Unholy Blight, CC will use Death Coil If/when Summon Gargoyle is on cooldown, CC will spam Death Coils instead of pooling runic power *Should no longer use Death And Decay on Ultraxion
The change to prevent DnD from casting on Ultraxion results in Festering Strike and Scourge Strike being unable to cast. Since Death and Decay is never cast, the call to DnD() will always return true which will cause the following blocks of code to never execute Code: if (!DnD() && Diseases() && Me.FrostRuneCount > 0 && (Me.BloodRuneCount > 0 || Me.DeathRuneCount > 0)) { if (CastSpell("Festering Strike")) { Logging.Write(Color.Aqua, ">> Festering Strike <<"); } } ... if (!DnD() && Diseases() && (Me.UnholyRuneCount > 0 || Me.DeathRuneCount > 0)) { if (CastSpell("Scourge Strike")) { Logging.Write(Color.Aqua, ">> Scourge Strike <<"); } } If, instead, you change the DnD() method to the following, all of the DnD() method calls will return false allowing the above code to execute as expected and preventing Death and Decay from being cast (it always thinks it's on cooldown for the Ultraxion fight) Code: public bool DnD() { // If we are fighting Ultraxion, we want to consider Death and Decay to always be on "cooldown" if (Me.CurrentTarget.Name == "Ultraxion") { return false; } return SpellManager.HasSpell("Death and Decay") && !SpellManager.Spells["Death and Decay"].Cooldown && SpellManager.CanCast("Death and Decay"); } You can then leave the code to cast Death and Decay as it was previously. Code: if (Diseases() && DnD() && (Me.CurrentTarget.IsWithinMeleeRange || Me.Location.Distance(Me.CurrentTarget.Location) <= 10 || Me.Location.Distance2D(Me.CurrentTarget.Location) <= 10)) { Lua.DoString("CastSpellByName('Death and Decay');"); { LegacySpellManager.ClickRemoteLocation(StyxWoW.Me.Location); } }
Please Re-SVN I've done a quick bug fix for 1.6, that should fix Plaguebringer not using all spells on Ultraxion (thank you KsuCoolCat for noticing and reporting)
New update available through SVN Plaguebringer v. 1.7 *Added new Dragon Soul Logics, that should work no matter what difficulty you are playing on
