I havent been able to implement the code you so kindly handed over to me, im afraid. It either spams all the spells which its not supposed to spam or it doesnt cast any spells at all. So what ive done which ive been spending hours on now is to delete the whole CC and writing everything from scratch, testing one spell at a time. So far, i havent even begun writing any offensive spells. Although im quite certain it'll double cast when i get there.
In this way right after it casts living bomb it will set it to not cast again, but will check for the aura. Once the target has the aura it will reset the livingbomblimit boolean to false so that it will again check if the dot has dropped off. Hope you understand.
Yeah, this is great! I implemented this in my new warlock CC to stop Soul Fire from double casting. It worked at first! But now all of the sudden it doesnt work at all. I havent even touched any of the codes. Really weird ;S Code: if(PlayerHasBuff("Improved Soul Fire") && ISFLimit) { ISFLimit = false; } if(!PlayerHasBuff("Improved Soul Fire") && !ISFLimit) { if (CastSpell("Soul Fire")==true); ISFLimit = true; }
Code: if(PlayerHasBuff("Improved Soul Fire") && ISFLimit) { ISFLimit = false; } if(!PlayerHasBuff("Improved Soul Fire") && !ISFLimit && CastSpell("Soul Fire")) { ISFLimit = true; } Just to shorten it up. You don't need to do CastSpell("Whatever") == true since CastSpell returns a boolean value it will either be true or false. To check if it didn't work then do a !CastSpell("Whatever") And it should be working 100%. No reason that should fail, unless your PlayerHasBuff() does something odd... I'm not sure exactly what it's doing so.
I tried using Me.HasAura/Me.Auras.ContainsKey instead of PlayerHasBuff to see if it was that which interfered. However when trying those codes out I noticed something weird. Soul Fire was working great until the buff expired while I was in the middle of casting "Immolate". After that, it stopped working! Who knows whats wrong. I'll keep going through the profile though till i can find the fault. You've already been great help! I dont expect you to write the whole CC for me
Have you been seeing any in-game errors like "Already have a spell casting" red popups? Because it may have attempted to cast it, which actually failed in-game, but the code doesn't check for that since it just presses a cast of it, and forgets. At which point the code now has it set to wait for the aura to appear, but it never will. Should add a 5 second timer that starts when it is set to true, and change it to If(TargetHasAura || ISFTimer.IsDone) { ISFTimer.Reset(); ISFLimit = false; }
Thanks alot for the tip! I finally managed to pull that one off after adding a second independent StopWatch Code: private Stopwatch _ISF = new Stopwatch(); public override void Combat() if(!Me.Auras.ContainsKey("Improved Soul Fire") && !_ISF.IsRunning || Me.Auras.ContainsKey("Improved Soul Fire") && !ISFLimit) { _ISF.Start(); ISFLimit = false; } if(!Me.Auras.ContainsKey("Improved Soul Fire") && _ISF.Elapsed.TotalSeconds >=5 || ISFLimit && !Me.Auras.ContainsKey("Improved Soul Fire")) { ISFLimit = true; if (CastSpell("Soul Fire")); _ISF.Stop(); _ISF.Reset(); } Panda to the rescue!
Pyromancer v2.4 Update. Scorch (Critical Mass) Living Bomb AoE Rotation All of the above has either been improved, removed or altered. Although this may seem like a small update its a rather big one. I've updated most of the code and put some hard work into the combat region. Ive done my best to prevent Living Bomb from double casting, I really doubt youll be seeing that again. The same thing with Scorch, i doubt youll see that double cast aswell. Ive added a stopwatch to Flamestrike, so it only casts every 8-9th second if theres 3 adds or more of course. Ive also added Fire Blast, so it should now spread living bomb and other dots when theres 3 adds or more. I hope you like this update, and please report bugs if there are any. -Shaddar.
Totally going to try this after i finish my mage. looks great though shaddar any expected dps numbers??
Depends on your gear of course! It does the standar raid rotation to get max dps! On my mage i get anything from 18k -> 30k in Dragon Soul. Cast Scorch to get Critical Mass if no one else in the raid has applied Winter's Chill/Critical Mass/Shadow and flame Cast Flame Orb whenever its off cooldown Keep Living Bomb up (let it explode before it reapplies) Pyroblast on proc Combustion when Living Bomb & Ignite & Pyroblast! Fireball as a filler (Scorch if your mana drops < 5000)
Its not supposed to use either fireball or pyroblast(non proc) at AoE packs, however it should be using Scorch as a filler on AoE packs, ill take a look at that when I have time too! Hopefully ill get to it today, if not itll be updated tomorrow morning.
