[Plugin] Giles Trinity

Giles,

I am posting my item stats log. For some reason the bot is seeing ilvl 62 and ilvl 63 items but its not picking them all up. If you compare them in the attached log you will see that it seems to have missed some 62 and 63 rares.

 

serenity adapted
need to test it out

but i changed the following

return new GilesPower(SNOPower.Monk_Serenity, 0f, vNullLocation, iCurrentWorldID, -1, USE_ANY_TIME, USE_SLOWLY);
to
return new GilesPower(SNOPower.Monk_Serenity, 0f, vNullLocation, iCurrentWorldID, -1, USE_ANY_TIME, USE_INSTANTLY);

will restart demonbuddy and check how it works

 

Mmmm :-s when arcane sentry or frozen spAWns he stops moving and attacks are very rare like 1 hit per second..thats what i notice so far..in rest is looking good nice job

 

hey giles, just wanted to say thanks for the quick up date right after u came home from vacation, i know i dont have that kind of dedication. Im also glad you started to accept donations, gotta keep DB getting better cause we all know the devs havent done as much as you have. I was wondering if this new version you changed the priority of rend to that over revenge? I havent been able to see much of a difference from when i did it myself but when i initially did it there was a drastic change over 5.3.2 or whatever the latest version of combat replacer was. Thanks again!

 

Either I'm lucky or this just increased my gph alot.

 

ok change for serenity seems to work for me it is casting it now might highten the limit a bit. Default it is on 50%

ok survived with serenity what before was impossible for me

[22:20:04.945 D] ChampionBase
[22:20:04.945 D] Health Link
[22:20:04.945 D] Desecrator
[22:20:04.945 D] Vortex
[22:20:04.945 D] Molten

this worked also for this
[22:40:36.447 D] Rare
[22:40:36.447 D] Jailer
[22:40:36.447 D] ArcaneEnchanted
[22:40:36.447 D] Extra Health
[22:40:36.447 D] Frozen

so for me this solves the serenity issue

 

Sometimes he doesnt recognize the item stats:
Jewelry - Amulet 'Champion Amulet'. Score = 0
(no scorable attributes)

I wonder if some good rares are sold because of that, because he literally does not brin in any usefull rares anymore, been farming for 5,6 hours now and no useful rare to sell...

 

Areas Where it goes back and forth/stuck [Then Leaves the game Waste of NV so I am posting the are with pic/coordinates given by DB]:

#1: http://tinyurl.com/Stuck01
#2: http://tinyurl.com/stuk02 [Donno why but it just froze may be fixed after v1.1]
#3: http://tinyurl.com/stuck03


Note: Co-ordinates are above the client pic Position: I believe thats the one. so ya.

 

Agreed, IMO, too much rend, way too much. And something's wrong with frenzy with 1.1

 

Edit: So i think what is actually doing is not attacking when avoiding range negative spells(arcane,poison pools,frozen balls,etc) and he is trying to avoid alot even if he gets hit (my class barb)and just stands there maybe flipping a coin to attack or not...what i`m saying i just double the death counts from 10 to 20

 

Giles new version is missing loot again combat looks a lot cleaner.

 

Giles, I'm not sure if you understand why we want to spam leap in combat. Most of us use the "Iron Impact" rune which increases your armor by 300% for 4 seconds after you leap. THIS is why we want to use leap ON COOLDOWN in combat. Not for avoidance. I don't want to leap at 75% hp. I don't want to leap out of plague pools. I want to leap ON COOLDOWN while fighting. The skill/rune is the very crux of many of our builds, and it is crucial that it's implemented properly. If you don't want to force everyone to use it on cooldown, maybe at least add a tick box for those of us that do. Thank you.

 

I had 1/2 of mine running 1.0.1 and the others running your latest one 1.1 and both seemed to be lacking a lot of items, I usually get at least 1 full tab, there was only 1/3 of a stash tab filled, so I'm assuming it's still missing loot :/

Leap is a little better, but it's still not using it everytime its up, you should make it spam leap 100% of the time, same with warcry/charge.
Rend is awesome now and working correctly, along with revenge (Aside from the fact it uses revenge regardless if theres enemies near it) but its much better this way, instant spamming.

The biggest issue is the loot though, It seems to be missing more now

 

I have found a workaround for the leap issue, if you remove this bit of code from the cs file he will not leap outside of combat.

find and delete:
// Leap movement for a barb
if (GilesTrinity.hashPowerHotbarAbilities.Contains(SNOPower.Barbarian_Leap) &&
DateTime.Now.Subtract(GilesTrinity.dictAbilityLastUse[SNOPower.Barbarian_Leap]).TotalMilliseconds >= GilesTrinity.dictAbilityRepeatDelay[SNOPower.Barbarian_Leap] &&
fDistanceNeeded >= 25f && fDistanceNeeded <= 35f &&
PowerManager.CanCast(SNOPower.Barbarian_Leap) && !ShrinesInArea(vMoveToTarget))
{
Vector3 vTargetAimPoint = MathEx.CalculatePointFrom(vMoveToTarget, vMyCurrentPosition, fDistanceNeeded - 2f);
ZetaDia.Me.UsePower(SNOPower.Barbarian_Leap, vTargetAimPoint, GilesTrinity.iCurrentWorldID, -1);
GilesTrinity.dictAbilityLastUse[SNOPower.Barbarian_Leap] = DateTime.Now;
return;
}

And this will cause him to leap even when at full health.
Find and change:

// Leaps used on when off-cooldown, or when out-of-range
if (!bBuffsOnly && targetCheckTarget != null && !bFindPureRanged && !bAvoidanceEmergency && !playerStatus.bIsIncapacitated && hashPowerHotbarAbilities.Contains(SNOPower.Barbarian_Leap) &&
(playerStatus.dCurrentHealthPct <= 0.75 || fDistanceFromTarget >= 18f) &&
GilesUseTimer(SNOPower.Barbarian_Leap, true) && PowerManager.CanCast(SNOPower.Barbarian_Leap))

to:

// Leaps used on when off-cooldown, or when out-of-range
if (!bBuffsOnly && targetCheckTarget != null && !bFindPureRanged && !bAvoidanceEmergency && !playerStatus.bIsIncapacitated && hashPowerHotbarAbilities.Contains(SNOPower.Barbarian_Leap) &&
(playerStatus.dCurrentHealthPct <= 1 || fDistanceFromTarget >= 18f) &&
GilesUseTimer(SNOPower.Barbarian_Leap, true) && PowerManager.CanCast(SNOPower.Barbarian_Leap))

Thank you Giles for making such clear and to the point notes in your code

 

yup..too much avoidance for me....cuz of that im still using the combat replacer....its much much more better....im not a programmer ....but could u just copy everything from combat replacer and put it in ur trinity..just like that?..

the only flaw of trinity is the avoidance....

 

Thanks Giles, your the man!

 

Probably a DB issue.
You're always going to miss some until DB is improved.

 

Ok only problem I am seeing right now for WD is it keeps killing Grunts instead of the summoners / elite groups so it is taking forever to kill them and is wasting time by doing so.

Also thanks so much for fixing Acid Cloud and WD routine in general Giles.

 

Mine is looting properly - I haven't seen it miss any loots, at all. As far as the game recognizing an item correctly (and not as an erroneous item), I'm not sure. I suppose I could look at the logs and see what has been sold. 1000% improvement, overall. 1 thing: I noticed that my barb uses sprint out of combat, but in combat (e.g., chasing a fleeing ranged mob), it does not use sprint. The exception is when it is whirlwinding, it uses sprint for fury generation. I am not sure if it uses sprint to chase mobs when WW is on the skill bar, because I do not use this build due to fury conservation issues (it always ends a battle with little to no fury, and thus I can't sprint to the next encounter).
Important part bolded for TLDR.

 

hmm interesting when I first installed fresh with 1.1 plugin and ran db it was missing loot. after I restarted db it is now loot properly weird?