• Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • Singular - A community driven All-In-One CC - It Just Plain Works - (Pt. 2)

    Discussion in 'Archives' started by Xanathos, Apr 19, 2011.

    1. benkoren

      benkoren New Member

      Joined:
      Jan 18, 2011
      Messages:
      356
      Likes Received:
      28
      Trophy Points:
      0
      Attached is an updated version of Marksman that fixed the Readiness logic when chaining. The issue was that if you did RF -> RD -> RF -> wait for cds.....it would pop RD -> RF instead of RF -> RD -> RF. That's fixed now. Also, I added checks for Steady Shot to make sure the char isn't moving so that you're not spammed with the "Can't do that while moving" message. See attachment.
       

      Attached Files:

    2. Kickazz006

      Kickazz006 Well-Known Member Moderator

      Joined:
      Jan 15, 2010
      Messages:
      20,567
      Likes Received:
      302
      Trophy Points:
      83
      this bot keeps blacklisting mobs in combat with other mobs

      but then it also gets in combat and stands there :(

      you can test this with tauren 1-5 paladin

      =(
       
    3. Kickazz006

      Kickazz006 Well-Known Member Moderator

      Joined:
      Jan 15, 2010
      Messages:
      20,567
      Likes Received:
      302
      Trophy Points:
      83
      bot also doesn't like to nav to targets if it needs to go up a ramp, around a rock, around a corner... it just stands there instead chillin (easily tested in my H or A bc profile... every 5-10 mins)
       
      Last edited: Dec 8, 2011
    4. Kickazz006

      Kickazz006 Well-Known Member Moderator

      Joined:
      Jan 15, 2010
      Messages:
      20,567
      Likes Received:
      302
      Trophy Points:
      83
      hey guys...

      can we get a fix for melee pulling for objects that are in the sky? maybe a check for like if Me.Z is # < current target, pull spell; warrior = heroic throw / shoot / throw, rogue = shoot / throw
       
    5. Kickazz006

      Kickazz006 Well-Known Member Moderator

      Joined:
      Jan 15, 2010
      Messages:
      20,567
      Likes Received:
      302
      Trophy Points:
      83
      the bot has major issues targetting correctly... it can have a mob targetted and it beating on the char, and then it just stands there sometimes... and it's not blacklisted. pally and dk both
       
    6. Martinescu

      Martinescu New Member

      Joined:
      May 13, 2011
      Messages:
      24
      Likes Received:
      0
      Trophy Points:
      1
      Hi!
      Asking before, but im pretty sure you are busy with patch changes. Using this amazing CC with prot pala as raider (Lazy raider). All perfect, just 1 thing. After combat, if someone is died, CC start spamming buff, BoK or Bom if Motw is on. I must off bot quickly cause it looks weird. Thanks.
       
    7. benkoren

      benkoren New Member

      Joined:
      Jan 18, 2011
      Messages:
      356
      Likes Received:
      28
      Trophy Points:
      0
      Just a heads up, I'm going to be adding options in the Class Specific settings for MM hunters and Frost DKs so they can flip on/off their cooldown usage.

      Also a sidenote on Frost DKs........be careful with the new version, you will do crazy damage if you have good gear. My damage went up by 10-25% depending on the fight and raised a few eyebrows in my guild (iLvl 392).

      - Ben
       
    8. Ruinit

      Ruinit Member

      Joined:
      Nov 1, 2010
      Messages:
      992
      Likes Received:
      4
      Trophy Points:
      18
      Warrior and feral also fwiw. But I have posted many times and still there.
       
    9. vitalic

      vitalic Banned

      Joined:
      Jun 21, 2010
      Messages:
      99
      Likes Received:
      0
      Trophy Points:
      0
      Code:
      CreateSpellCast("Soul Fire", ret => Me.HasAura("Decimation")),
      From Demonology.cs, it's casting soul fire even when it doesn't have the aura, any ideas?
       
    10. benkoren

      benkoren New Member

      Joined:
      Jan 18, 2011
      Messages:
      356
      Likes Received:
      28
      Trophy Points:
      0
      @Martinescu: Apoc fixed the pally buffing in rev 442 this afternoon - update and you're set.

      @Apoc: The attachment on this post has a fix for a cooldown on the MM hunter: http://www.thebuddyforum.com/honorb...cc-just-plain-works-pt-2-a-22.html#post405024
       
      Last edited: Dec 8, 2011
    11. Apoc

      Apoc Moderator Staff Member Moderator

      Joined:
      Jan 16, 2010
      Messages:
      2,790
      Likes Received:
      94
      Trophy Points:
      48
      Please use v2 of Singular. I no longer provide support for v1. (v2 will be packaged with HB in the next few releases once we confirm its stable.)
       
    12. no1knowsy

      no1knowsy Well-Known Member

      Joined:
      Feb 28, 2010
      Messages:
      3,927
      Likes Received:
      57
      Trophy Points:
      48
      :D
      Sounds good.
       
    13. Kickazz006

      Kickazz006 Well-Known Member Moderator

      Joined:
      Jan 15, 2010
      Messages:
      20,567
      Likes Received:
      302
      Trophy Points:
      83
      the main issue that prevents it from being a release is that melee it constantly just stands there getting attacked and not attacking, blacklisting mobs that are in combat and standing there until dc, and standing 15 yards away from a mob targeting it and standing there

      fix those and it should be good to go

      also, pallies - default holy light should not be 90% ... maybe 75 default. also, why would you double holy light? every time it casts holy light, it casts it 2 times in a row
       
    14. vitalic

      vitalic Banned

      Joined:
      Jun 21, 2010
      Messages:
      99
      Likes Received:
      0
      Trophy Points:
      0
      im sure i read that someone found the source of that bug, it was related to to the isfacing detection or something
       
    15. vitalic

      vitalic Banned

      Joined:
      Jun 21, 2010
      Messages:
      99
      Likes Received:
      0
      Trophy Points:
      0
      apoc v2 is double-casting immolate but it shouldn't be, my latency is 60ms so dont think thats an issue. im not sure if waitforcast() is working properly because my log is being spammed with spells during casts. log attached

      p.s. another problem i noticed is it tries to call a pet due to the 1 second delay for the pet spawning after dismount, any way to fix this?
       

      Attached Files:

      Last edited: Dec 8, 2011
    16. benkoren

      benkoren New Member

      Joined:
      Jan 18, 2011
      Messages:
      356
      Likes Received:
      28
      Trophy Points:
      0
      Frost DK and Ele Shaman

      For the Ele shaman I just added in the code to move within LOS and face the target.

      - Ben
       

      Attached Files:

      Last edited: Dec 9, 2011
    17. antareja

      antareja New Member

      Joined:
      Jan 15, 2010
      Messages:
      16
      Likes Received:
      0
      Trophy Points:
      0
      How to disable Targeting..?
      LazyRaider with
      Disable Movement: True
      Tanking - Disable Targeting: True
      Targeting - Disable Targeting: True

      Still, singular always pull another target..
       
      Last edited: Dec 9, 2011
    18. vitalic

      vitalic Banned

      Joined:
      Jun 21, 2010
      Messages:
      99
      Likes Received:
      0
      Trophy Points:
      0
      patch for warlock pet dismount behavior, noticed your comment and tried it and seems to have fixed the problem

      Code:
      Index: PetManager.cs
      ===================================================================
      --- PetManager.cs	(revision 444)
      +++ PetManager.cs	(working copy)
      @@ -48,7 +48,7 @@
                   // NOTE: This is a bit hackish. This fires VERY OFTEN in major cities. But should prevent us from summoning right after dismounting.
                   // Lua.Events.AttachEvent("COMPANION_UPDATE", (s, e) => CallPetTimer.Reset());
                   // Note: To be changed to OnDismount with new release
      -            Mount.OnMountUp += (s, e) =>
      +            Mount.OnDismount += (s, e) =>
                                          {
                                              if (StyxWoW.Me.Class == WoWClass.Warlock || StyxWoW.Me.PetNumber > 0)
                                              {
      
      any idea about the spell spam yet? i've been trying to work it out but to no avail, it's spamming immolate while immolate is being casted, so something about the waitforcast logic is broken
       
    19. vitalic

      vitalic Banned

      Joined:
      Jun 21, 2010
      Messages:
      99
      Likes Received:
      0
      Trophy Points:
      0
      i have a temporary fix for the targeting issues:

      Code:
      Index: Movement.cs
      ===================================================================
      --- Movement.cs	(revision 444)
      +++ Movement.cs	(working copy)
      @@ -67,7 +67,7 @@
               public static Composite CreateFaceTargetBehavior()
               {
                   return new Decorator(
      -                ret => !SingularSettings.Instance.DisableAllMovement && !StyxWoW.Me.IsMoving && StyxWoW.Me.CurrentTarget != null && !StyxWoW.Me.IsSafelyFacing(StyxWoW.Me.CurrentTarget, 70f),
      +                ret => !SingularSettings.Instance.DisableAllMovement && !StyxWoW.Me.IsMoving && StyxWoW.Me.CurrentTarget != null && StyxWoW.Me.CurrentTarget.IsBehind(StyxWoW.Me),
                       new Action(ret => StyxWoW.Me.CurrentTarget.Face()));
               }
       
      
      credits to nah4o for the original find described in this post: http://www.thebuddyforum.com/archives/38178-release-honorbuddy-2-0-0-5462-a-5.html#post400555
       
    20. tumbum

      tumbum Active Member

      Joined:
      Mar 17, 2011
      Messages:
      3,341
      Likes Received:
      13
      Trophy Points:
      38
      Isnt it possible to set a Pet Slot as Hunter? Because the Toon only summons Pet1 no other Pets, and my Tank Pet is on Slot 2 :(
       

    Share This Page